Filipe Manana f177d73949 Btrfs: fix emptiness check for dirtied extent buffers at check_leaf() ... We can not simply use the owner field from an extent buffer's header to get the id of the respective tree when the extent buffer is from a relocation tree. When we create the root for a relocation tree we leave (on purpose) the owner field with the same value as the subvolume's tree root (we do this at ctree.c:btrfs_copy_root()). So we must ignore extent buffers from relocation trees, which have the BTRFS_HEADER_FLAG_RELOC flag set, because otherwise we will always consider the extent buffer as not being the root of the tree (the root of original subvolume tree is always different from the root of the respective relocation tree). This lead to assertion failures when running with the integrity checker enabled (CONFIG_BTRFS_FS_CHECK_INTEGRITY=y) such as the following: [ 643.393409] BTRFS critical (device sdg): corrupt leaf, non-root leaf's nritems is 0: block=38506496, root=260, slot=0 [ 643.397609] BTRFS info (device sdg): leaf 38506496 total ptrs 0 free space 3995 [ 643.407075] assertion failed: 0, file: fs/btrfs/disk-io.c, line: 4078 [ 643.408425] ------------[ cut here ]------------ [ 643.409112] kernel BUG at fs/btrfs/ctree.h:3419! [ 643.409773] invalid opcode: 0000 [#1] PREEMPT SMP [ 643.410447] Modules linked in: dm_flakey dm_mod crc32c_generic btrfs xor raid6_pq ppdev psmouse acpi_cpufreq parport_pc evdev parport tpm_tis tpm_tis_core pcspkr serio_raw i2c_piix4 sg tpm i2c_core button processor loop autofs4 ext4 crc16 jbd2 mbcache sr_mod cdrom sd_mod ata_generic virtio_scsi ata_piix libata virtio_pci virtio_ring scsi_mod virtio e1000 floppy [ 643.414356] CPU: 11 PID: 32726 Comm: btrfs Not tainted 4.8.0-rc8-btrfs-next-35+ #1 [ 643.414356] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.9.1-0-gb3ef39f-prebuilt.qemu-project.org 04/01/2014 [ 643.414356] task: ffff880145e95b00 task.stack: ffff88014826c000 [ 643.414356] RIP: 0010:[<ffffffffa0352759>] [<ffffffffa0352759>] assfail.constprop.41+0x1c/0x1e [btrfs] [ 643.414356] RSP: 0018:ffff88014826fa28 EFLAGS: 00010292 [ 643.414356] RAX: 0000000000000039 RBX: ffff88014e2d7c38 RCX: 0000000000000001 [ 643.414356] RDX: ffff88023f4d2f58 RSI: ffffffff81806c63 RDI: 00000000ffffffff [ 643.414356] RBP: ffff88014826fa28 R08: 0000000000000001 R09: 0000000000000000 [ 643.414356] R10: ffff88014826f918 R11: ffffffff82f3c5ed R12: ffff880172910000 [ 643.414356] R13: ffff880233992230 R14: ffff8801a68a3310 R15: fffffffffffffff8 [ 643.414356] FS: 00007f9ca305e8c0(0000) GS:ffff88023f4c0000(0000) knlGS:0000000000000000 [ 643.414356] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 643.414356] CR2: 00007f9ca3071000 CR3: 000000015d01b000 CR4: 00000000000006e0 [ 643.414356] Stack: [ 643.414356] ffff88014826fa50 ffffffffa02d655a 000000000000000a ffff88014e2d7c38 [ 643.414356] 0000000000000000 ffff88014826faa8 ffffffffa02b72f3 ffff88014826fab8 [ 643.414356] 00ffffffa03228e4 0000000000000000 0000000000000000 ffff8801bbd4e000 [ 643.414356] Call Trace: [ 643.414356] [<ffffffffa02d655a>] btrfs_mark_buffer_dirty+0xdf/0xe5 [btrfs] [ 643.414356] [<ffffffffa02b72f3>] btrfs_copy_root+0x18a/0x1d1 [btrfs] [ 643.414356] [<ffffffffa0322921>] create_reloc_root+0x72/0x1ba [btrfs] [ 643.414356] [<ffffffffa03267c2>] btrfs_init_reloc_root+0x7b/0xa7 [btrfs] [ 643.414356] [<ffffffffa02d9e44>] record_root_in_trans+0xdf/0xed [btrfs] [ 643.414356] [<ffffffffa02db04e>] btrfs_record_root_in_trans+0x50/0x6a [btrfs] [ 643.414356] [<ffffffffa030ad2b>] create_subvol+0x472/0x773 [btrfs] [ 643.414356] [<ffffffffa030b406>] btrfs_mksubvol+0x3da/0x463 [btrfs] [ 643.414356] [<ffffffffa030b406>] ? btrfs_mksubvol+0x3da/0x463 [btrfs] [ 643.414356] [<ffffffff810781ac>] ? preempt_count_add+0x65/0x68 [ 643.414356] [<ffffffff811a6e97>] ? __mnt_want_write+0x62/0x77 [ 643.414356] [<ffffffffa030b55d>] btrfs_ioctl_snap_create_transid+0xce/0x187 [btrfs] [ 643.414356] [<ffffffffa030b67d>] btrfs_ioctl_snap_create+0x67/0x81 [btrfs] [ 643.414356] [<ffffffffa030ecfd>] btrfs_ioctl+0x508/0x20dd [btrfs] [ 643.414356] [<ffffffff81293e39>] ? __this_cpu_preempt_check+0x13/0x15 [ 643.414356] [<ffffffff81155eca>] ? handle_mm_fault+0x976/0x9ab [ 643.414356] [<ffffffff81091300>] ? arch_local_irq_save+0x9/0xc [ 643.414356] [<ffffffff8119a2b0>] vfs_ioctl+0x18/0x34 [ 643.414356] [<ffffffff8119a8e8>] do_vfs_ioctl+0x581/0x600 [ 643.414356] [<ffffffff814b9552>] ? entry_SYSCALL_64_fastpath+0x5/0xa8 [ 643.414356] [<ffffffff81093fe9>] ? trace_hardirqs_on_caller+0x17b/0x197 [ 643.414356] [<ffffffff8119a9be>] SyS_ioctl+0x57/0x79 [ 643.414356] [<ffffffff814b9565>] entry_SYSCALL_64_fastpath+0x18/0xa8 [ 643.414356] [<ffffffff81091b08>] ? trace_hardirqs_off_caller+0x3f/0xaa [ 643.414356] Code: 89 83 88 00 00 00 31 c0 5b 41 5c 41 5d 5d c3 55 89 f1 48 c7 c2 98 bc 35 a0 48 89 fe 48 c7 c7 05 be 35 a0 48 89 e5 e8 13 46 dd e0 <0f> 0b 55 89 f1 48 c7 c2 9f d3 35 a0 48 89 fe 48 c7 c7 7a d5 35 [ 643.414356] RIP [<ffffffffa0352759>] assfail.constprop.41+0x1c/0x1e [btrfs] [ 643.414356] RSP <ffff88014826fa28> [ 643.468267] ---[ end trace 6a1b3fb1a9d7d6e3 ]--- This can be easily reproduced by running xfstests with the integrity checker enabled. Fixes: 1ba98d086f (Btrfs: detect corruption when non-root leaf has zero item) Cc: stable@vger.kernel.org # 4.8+ Signed-off-by: Filipe Manana <fdmanana@suse.com> Reviewed-by: Liu Bo <bo.li.liu@oracle.com>		2016-11-23 20:24:35 +00:00
..
9p	Merge branch 'for-linus-2' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2016-08-07 10:01:14 -04:00
adfs	Merge branch 'for-linus-2' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2016-08-07 10:01:14 -04:00
affs	get rid of 'parent' argument of ->d_compare()	2016-07-31 16:37:25 -04:00
afs	rxrpc: Fix races between skb free, ACK generation and replying	2016-08-06 00:08:40 -04:00
autofs4	autofs: use dentry flags to block walks during expire	2016-09-19 15:36:17 -07:00
befs	fs/befs/io.c:befs_bread(): remove unneeded initialization to NULL	2016-05-23 17:04:14 -07:00
bfs	more trivial ->iterate_shared conversions	2016-05-09 11:41:14 -04:00
btrfs	Btrfs: fix emptiness check for dirtied extent buffers at check_leaf()	2016-11-23 20:24:35 +00:00
cachefiles	cachefiles: Fix race between inactivating and culling a cache object	2016-08-03 13:33:26 -04:00
ceph	ceph: do not modify fi->frag in need_reset_readdir()	2016-09-05 14:30:35 +02:00
cifs	Move check for prefix path to within cifs_get_root()	2016-09-09 23:58:07 -05:00
coda	drop redundant ->owner initializations	2016-05-29 19:08:00 -04:00
configfs	configfs: Return -EFBIG from configfs_write_bin_file.	2016-09-16 12:58:28 +02:00
cramfs	more trivial ->iterate_shared conversions	2016-05-09 11:41:14 -04:00
crypto	fscrypto: require write access to mount to set encryption policy	2016-09-10 01:18:57 -04:00
debugfs	Merge branch 'd_real' of git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs into work.misc	2016-06-30 23:34:49 -04:00
devpts	devpts: return NULL pts 'priv' entry for non-devpts nodes	2016-09-03 11:02:50 -07:00
dlm	dlm: fix malfunction of dlm_tool caused by debugfs changes	2016-08-26 13:22:14 -05:00
ecryptfs	ecryptfs: don't allow mmap when the lower fs doesn't support it	2016-07-08 10:35:28 -05:00
efivarfs	get rid of 'parent' argument of ->d_compare()	2016-07-31 16:37:25 -04:00
efs	fs/efs/super.c: fix return value	2016-05-20 17:58:30 -07:00
exofs	block, fs, mm, drivers: use bio set/get op accessors	2016-06-07 13:41:38 -06:00
exportfs	introduce a parallel variant of ->iterate()	2016-05-02 19:49:29 -04:00
ext2	Merge branch 'work.const-qstr' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2016-08-06 09:49:02 -04:00
ext4	fscrypto: require write access to mount to set encryption policy	2016-09-10 01:18:57 -04:00
f2fs	fscrypto: require write access to mount to set encryption policy	2016-09-10 01:18:57 -04:00
fat	Merge branch 'for-linus-2' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2016-08-07 10:01:14 -04:00
freevxfs	freevxfs: update Kconfig information	2016-06-13 10:20:39 +02:00
fscache	Merge branch 'd_real' of git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs into work.misc	2016-06-30 23:34:49 -04:00
fuse	fuse: direct-io: don't dirty ITER_BVEC pages	2016-08-24 18:17:04 +02:00
gfs2	fs: return EPERM on immutable inode	2016-08-07 10:03:31 -04:00
hfs	Merge branch 'for-linus-2' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2016-08-07 10:01:14 -04:00
hfsplus	Merge branch 'for-linus-2' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2016-08-07 10:01:14 -04:00
hostfs	hostfs: Freeing an ERR_PTR in hostfs_fill_sb_common()	2016-08-04 00:18:10 +02:00
hpfs	get rid of 'parent' argument of ->d_compare()	2016-07-31 16:37:25 -04:00
hugetlbfs
isofs	get rid of 'parent' argument of ->d_compare()	2016-07-31 16:37:25 -04:00
jbd2	The major change this cycle is deleting ext4's copy of the file system	2016-07-26 18:35:55 -07:00
jffs2	vfs: make the string hashes salt the hash	2016-06-10 20:21:46 -07:00
jfs	get rid of 'parent' argument of ->d_compare()	2016-07-31 16:37:25 -04:00
kernfs	kernfs: don't depend on d_find_any_alias() when generating notifications	2016-08-31 14:48:52 +02:00
lockd	Merge branch 'work.misc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2016-07-28 12:59:05 -07:00
logfs	Merge branch 'work.const-qstr' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2016-08-06 09:49:02 -04:00
minix	simple local filesystems: switch to ->iterate_shared()	2016-05-02 19:49:32 -04:00
ncpfs	get rid of 'parent' argument of ->d_compare()	2016-07-31 16:37:25 -04:00
nfs	NFSv4.1: Fix the CREATE_SESSION slot number accounting	2016-09-11 14:56:44 -04:00
nfs_common
nfsd	nfsd: don't return an unhashed lock stateid after taking mutex	2016-08-12 16:10:25 -04:00
nilfs2	nilfs2: move ioctl interface and disk layout to uapi separately	2016-08-02 19:35:21 -04:00
nls
notify	fanotify: fix list corruption in fanotify_get_response()	2016-09-19 15:36:17 -07:00
ntfs	Merge branch 'work.misc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2016-07-28 12:59:05 -07:00
ocfs2	Revert "ocfs2: bump up o2cb network protocol version"	2016-09-19 15:36:17 -07:00
omfs	more trivial ->iterate_shared conversions	2016-05-09 11:41:14 -04:00
openpromfs	more trivial ->iterate_shared conversions	2016-05-09 11:41:14 -04:00
orangefs	orangefs: Account for jiffies wraparound.	2016-08-02 15:39:13 -04:00
overlayfs	ovl: fix workdir creation	2016-09-05 13:55:20 +02:00
proc	fs/proc/kcore.c: Add bounce buffer for ktext data	2016-09-20 13:32:49 -07:00
pstore	ramoops: use persistent_ram_free() instead of kfree() for freeing prz	2016-08-05 11:21:46 -07:00
qnx4	more trivial ->iterate_shared conversions	2016-05-09 11:41:14 -04:00
qnx6	more trivial ->iterate_shared conversions	2016-05-09 11:41:14 -04:00
quota	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace	2016-07-29 15:54:19 -07:00
ramfs	ipc/shm: fix crash if CONFIG_SHMEM is not set	2016-09-19 15:36:17 -07:00
reiserfs	reiserfs: fix "new_insert_key may be used uninitialized ..."	2016-08-02 19:35:22 -04:00
romfs	romfs, squashfs: switch to ->iterate_shared()	2016-05-09 11:41:15 -04:00
squashfs	fs: have ll_rw_block users pass in op and flags separately	2016-06-07 13:41:38 -06:00
sysfs	sysfs: correctly handle read offset on PREALLOC attrs	2016-08-31 15:14:44 +02:00
sysv	vfs: make the string hashes salt the hash	2016-06-10 20:21:46 -07:00
tracefs	tracefs: ->d_parent is never NULL or negative...	2016-05-29 16:22:07 -04:00
ubifs	ubifs: Fix xattr generic handler usage	2016-08-23 23:02:52 +02:00
udf	Merge branch 'for-4.8/drivers' of git://git.kernel.dk/linux-block	2016-07-26 15:37:51 -07:00
ufs	Merge branch 'work.misc' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2016-07-28 12:59:05 -07:00
xfs	xfs: track log done items directly in the deferred pending work item	2016-08-30 13:51:39 +10:00
aio.c	aio: mark AIO pseudo-fs noexec	2016-09-15 15:49:28 -07:00
anon_inodes.c
attr.c	vfs: Don't modify inodes with a uid or gid unknown to the vfs	2016-07-05 15:06:46 -05:00
bad_inode.c	switch ->setxattr() to passing dentry and inode separately	2016-05-27 20:09:16 -04:00
binfmt_aout.c	fs: fix binfmt_aout.c build error	2016-05-28 16:34:59 -07:00
binfmt_elf_fdpic.c	elf_fdpic_transfer_args_to_stack(): make it generic	2016-07-25 16:51:49 +10:00
binfmt_elf.c	binfmt_elf: switch to new creds when switching to new mm	2016-08-31 09:13:56 -07:00
binfmt_em86.c	fs/binfmt_em86.c: fix incompatible pointer type	2016-08-02 19:35:15 -04:00
binfmt_flat.c	binfmt_flat: allow compressed flat binary format to work on MMU systems	2016-07-28 13:29:12 +10:00
binfmt_misc.c	binfmt_misc for-linus on 20160727	2016-08-07 10:13:14 -04:00
binfmt_script.c
block_dev.c	fs/block_dev: fix potential NULL ptr deref in freeze_bdev()	2016-08-25 08:38:26 -06:00
buffer.c	xfs: update for 4.8-rc1	2016-07-27 09:53:35 -07:00
char_dev.c	chardev: add missing line break in pr_warn	2016-07-14 16:21:53 +09:00
compat_binfmt_elf.c
compat_ioctl.c	[media] cec: add compat32 ioctl support	2016-06-28 10:00:13 -03:00
compat.c	Fix a number of bugs, most notably a potential stale data exposure	2016-05-24 12:55:26 -07:00
coredump.c	coredump: fix dumping through pipes	2016-06-07 22:07:09 -04:00
dax.c	libnvdimm for 4.8	2016-07-28 17:38:16 -07:00
dcache.c	Merge branch 'for-linus-2' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2016-08-07 10:01:14 -04:00
dcookies.c
direct-io.c	direct-io: use bio set/get op accessors	2016-06-07 13:41:38 -06:00
drop_caches.c
eventfd.c
eventpoll.c	fs: poll/select/recvmmsg: use timespec64 for timeout events	2016-05-19 19:12:14 -07:00
exec.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/gerg/m68knommu	2016-08-04 18:04:44 -04:00
fcntl.c
fhandle.c
file_table.c
file.c	give readdir(2)/getdents(2)/etc. uniform exclusion with lseek()	2016-05-02 19:49:28 -04:00
filesystems.c
fs_pin.c
fs_struct.c
fs-writeback.c	mm, writeback: flush plugged IO in wakeup_flusher_threads()	2016-08-09 19:58:06 -06:00
inode.c	Merge branch 'for-linus-2' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2016-08-07 10:01:14 -04:00
internal.h	binfmt_misc for-linus on 20160727	2016-08-07 10:13:14 -04:00
ioctl.c	vfs: cap dedupe request structure size at PAGE_SIZE	2016-09-15 13:29:52 -07:00
iomap.c	iomap: don't set FIEMAP_EXTENT_MERGED for extent based filesystems	2016-08-29 11:33:58 +10:00
Kconfig	Highlights:	2016-08-04 19:59:06 -04:00
Kconfig.binfmt	m68k: enable binfmt_flat on systems with an MMU	2016-07-28 13:29:13 +10:00
libfs.c	lockless next_positive()	2016-06-20 17:11:29 -04:00
locks.c	locks: use file_inode()	2016-07-01 10:24:18 -04:00
Makefile	fs: introduce iomap infrastructure	2016-06-21 09:23:11 +10:00
mbcache.c
mount.h
mpage.c	block/mm: make bdev_ops->rw_page() take a bool for read/write	2016-08-07 14:41:02 -06:00
namei.c	fs: return EPERM on immutable inode	2016-08-07 10:03:31 -04:00
namespace.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace	2016-07-29 15:54:19 -07:00
no-block.c
nsfs.c
open.c	binfmt_misc for-linus on 20160727	2016-08-07 10:13:14 -04:00
pipe.c	mm: memcontrol: only mark charged pages with PageKmemcg	2016-08-09 10:14:10 -07:00
pnode.c	propogate_mnt: Handle the first propogated copy being a slave	2016-05-05 09:54:45 -05:00
pnode.h
posix_acl.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace	2016-07-29 15:54:19 -07:00
proc_namespace.c
read_write.c	x86/syscalls: Add compat_sys_preadv64v2/compat_sys_pwritev64v2	2016-07-15 10:30:26 +02:00
readdir.c	restore killability of old mutex_lock_killable(&inode->i_mutex) users	2016-05-26 00:13:25 -04:00
select.c	fs: poll/select/recvmmsg: use timespec64 for timeout events	2016-05-19 19:12:14 -07:00
seq_file.c	fs/seq_file: fix out-of-bounds read	2016-08-26 17:39:35 -07:00
signalfd.c
splice.c	Merge branch 'ovl-fixes' into for-linus	2016-05-11 00:00:29 -04:00
stack.c
stat.c
statfs.c
super.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace	2016-07-29 15:54:19 -07:00
sync.c
timerfd.c	timerfd: Reject ALARM timerfds without CAP_WAKE_ALARM	2016-06-09 23:42:38 +02:00
userfaultfd.c	mm: introduce fault_env	2016-07-26 16:19:19 -07:00
utimes.c	fs: return EPERM on immutable inode	2016-08-07 10:03:31 -04:00
xattr.c	vfs: Don't modify inodes with a uid or gid unknown to the vfs	2016-07-05 15:06:46 -05:00