Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-12-24 20:01:55 +00:00
Code Issues Packages Projects Releases Wiki Activity
f0c6225531
linux/drivers/media/pci/saa7134
History
Arnd Bergmann 0a7790be18 media: subdev: disallow ioctl for saa6588/davinci 
The saa6588_ioctl() function expects to get called from other kernel
functions with a 'saa6588_command' pointer, but I found nothing stops it
from getting called from user space instead, which seems rather dangerous.

The same thing happens in the davinci vpbe driver with its VENC_GET_FLD
command.

As a quick fix, add a separate .command() callback pointer for this
driver and change the two callers over to that.  This change can easily
get backported to stable kernels if necessary, but since there are only
two drivers, we may want to eventually replace this with a set of more
specialized callbacks in the long run.

Fixes: c3fda7f835 ("V4L/DVB (10537): saa6588: convert to v4l2_subdev.")
Cc: stable@vger.kernel.org
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
2021-06-17 10:18:37 +02:00
..
Kconfig Revert "media: Kconfig: better support hybrid TV devices" 2020-04-14 11:00:30 +02:00
Makefile media: don't include drivers/media/i2c at cflags 2017-12-28 14:14:09 -05:00
saa7134-alsa.c media: pci: fix common ALSA DMA-mapping related codes 2020-09-26 10:34:44 +02:00
saa7134-cards.c media: Use fallthrough pseudo-keyword 2020-08-29 08:35:27 +02:00
saa7134-core.c media: saa7134: fix saa7134_initdev error handling logic 2021-06-17 09:26:42 +02:00
saa7134-dvb.c media: saa7134: keep demod i2c gate closed on Medion 7134 2019-08-26 10:45:19 -03:00
saa7134-empress.c media: v4l2-subdev: add subdev-wide state struct 2021-06-17 10:01:27 +02:00
saa7134-go7007.c media: media/pci: use vb2_video_unregister_device() 2020-08-28 15:01:54 +02:00
saa7134-i2c.c media: saa7134: fix terminology around saa7134_i2c_eeprom_md7134_gate() 2019-08-26 10:45:49 -03:00
saa7134-input.c media: pci: saa7134: convert to use i2c_new_client_device() 2020-04-14 11:29:10 +02:00
saa7134-reg.h
saa7134-ts.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157 2019-05-30 11:26:37 -07:00
saa7134-tvaudio.c media: saa7134: drop a NO-BREAK SPACE 2021-06-04 08:10:26 +02:00
saa7134-vbi.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157 2019-05-30 11:26:37 -07:00
saa7134-video.c media: subdev: disallow ioctl for saa6588/davinci 2021-06-17 10:18:37 +02:00
saa7134.h media: saa7134-alsa.c: number of pages should be unsigned long 2020-09-03 11:13:46 +02:00