linux/drivers/nfc/st-nci
Fedor Pchelkin 25ff6f8a5a nfc: fix memory leak of se_io context in nfc_genl_se_io
The callback context for sending/receiving APDUs to/from the selected
secure element is allocated inside nfc_genl_se_io and supposed to be
eventually freed in se_io_cb callback function. However, there are several
error paths where the bwi_timer is not charged to call se_io_cb later, and
the cb_context is leaked.

The patch proposes to free the cb_context explicitly on those error paths.

At the moment we can't simply check 'dev->ops->se_io()' return value as it
may be negative in both cases: when the timer was charged and was not.

Fixes: 5ce3f32b52 ("NFC: netlink: SE API implementation")
Reported-by: syzbot+df64c0a2e8d68e78a4fa@syzkaller.appspotmail.com
Signed-off-by: Fedor Pchelkin <pchelkin@ispras.ru>
Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: David S. Miller <davem@davemloft.net>
2023-02-26 14:55:13 +00:00
..
core.c nfc: st-nci: remove unused header includes 2021-08-26 09:13:36 +01:00
i2c.c nfc: st-nci: Convert to i2c's .probe_new() 2022-11-23 12:50:08 -08:00
Kconfig treewide: replace '---help---' in Kconfig files with 'help' 2020-06-14 01:57:21 +09:00
Makefile
ndlc.c nfc: st-nci: drop unneeded debug prints 2021-10-11 17:00:51 -07:00
ndlc.h nfc: constify nfc_phy_ops 2021-07-25 09:21:21 +01:00
se.c nfc: fix memory leak of se_io context in nfc_genl_se_io 2023-02-26 14:55:13 +00:00
spi.c spi: make remove callback a void function 2022-02-09 13:00:45 +00:00
st-nci.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 399 2019-06-05 17:37:12 +02:00
vendor_cmds.c nfc: use *_set_vendor_cmds() helpers 2022-01-27 13:53:26 +00:00