mirror of
https://github.com/torvalds/linux.git
synced 2024-12-29 14:21:47 +00:00
ef24ba7091
NO_IRQ has been == 0 on powerpc for just over ten years (since commit
0ebfff1491 ("[POWERPC] Add new interrupt mapping core and change
platforms to use it")). It's also 0 on most other arches.
Although it's fairly harmless, every now and then it causes confusion
when a driver is built on powerpc and another arch which doesn't define
NO_IRQ. There's at least 6 definitions of NO_IRQ in drivers/, at least
some of which are to work around that problem.
So we'd like to remove it. This is fairly trivial in the arch code, we
just convert:
if (irq == NO_IRQ) to if (!irq)
if (irq != NO_IRQ) to if (irq)
irq = NO_IRQ; to irq = 0;
return NO_IRQ; to return 0;
And a few other odd cases as well.
At least for now we keep the #define NO_IRQ, because there is driver
code that uses NO_IRQ and the fixes to remove those will go via other
trees.
Note we also change some occurrences in PPC sound drivers, drivers/ps3,
and drivers/macintosh.
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
133 lines
3.1 KiB
C
133 lines
3.1 KiB
C
/*
|
|
* PS3 SMP routines.
|
|
*
|
|
* Copyright (C) 2006 Sony Computer Entertainment Inc.
|
|
* Copyright 2006 Sony Corp.
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; version 2 of the License.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
|
|
*/
|
|
|
|
#include <linux/kernel.h>
|
|
#include <linux/smp.h>
|
|
|
|
#include <asm/machdep.h>
|
|
#include <asm/udbg.h>
|
|
|
|
#include "platform.h"
|
|
|
|
#if defined(DEBUG)
|
|
#define DBG udbg_printf
|
|
#else
|
|
#define DBG pr_debug
|
|
#endif
|
|
|
|
/**
|
|
* ps3_ipi_virqs - a per cpu array of virqs for ipi use
|
|
*/
|
|
|
|
#define MSG_COUNT 4
|
|
static DEFINE_PER_CPU(unsigned int [MSG_COUNT], ps3_ipi_virqs);
|
|
|
|
static void ps3_smp_message_pass(int cpu, int msg)
|
|
{
|
|
int result;
|
|
unsigned int virq;
|
|
|
|
if (msg >= MSG_COUNT) {
|
|
DBG("%s:%d: bad msg: %d\n", __func__, __LINE__, msg);
|
|
return;
|
|
}
|
|
|
|
virq = per_cpu(ps3_ipi_virqs, cpu)[msg];
|
|
result = ps3_send_event_locally(virq);
|
|
|
|
if (result)
|
|
DBG("%s:%d: ps3_send_event_locally(%d, %d) failed"
|
|
" (%d)\n", __func__, __LINE__, cpu, msg, result);
|
|
}
|
|
|
|
static void __init ps3_smp_probe(void)
|
|
{
|
|
int cpu;
|
|
|
|
for (cpu = 0; cpu < 2; cpu++) {
|
|
int result;
|
|
unsigned int *virqs = per_cpu(ps3_ipi_virqs, cpu);
|
|
int i;
|
|
|
|
DBG(" -> %s:%d: (%d)\n", __func__, __LINE__, cpu);
|
|
|
|
/*
|
|
* Check assumptions on ps3_ipi_virqs[] indexing. If this
|
|
* check fails, then a different mapping of PPC_MSG_
|
|
* to index needs to be setup.
|
|
*/
|
|
|
|
BUILD_BUG_ON(PPC_MSG_CALL_FUNCTION != 0);
|
|
BUILD_BUG_ON(PPC_MSG_RESCHEDULE != 1);
|
|
BUILD_BUG_ON(PPC_MSG_TICK_BROADCAST != 2);
|
|
BUILD_BUG_ON(PPC_MSG_DEBUGGER_BREAK != 3);
|
|
|
|
for (i = 0; i < MSG_COUNT; i++) {
|
|
result = ps3_event_receive_port_setup(cpu, &virqs[i]);
|
|
|
|
if (result)
|
|
continue;
|
|
|
|
DBG("%s:%d: (%d, %d) => virq %u\n",
|
|
__func__, __LINE__, cpu, i, virqs[i]);
|
|
|
|
result = smp_request_message_ipi(virqs[i], i);
|
|
|
|
if (result)
|
|
virqs[i] = 0;
|
|
else
|
|
ps3_register_ipi_irq(cpu, virqs[i]);
|
|
}
|
|
|
|
ps3_register_ipi_debug_brk(cpu, virqs[PPC_MSG_DEBUGGER_BREAK]);
|
|
|
|
DBG(" <- %s:%d: (%d)\n", __func__, __LINE__, cpu);
|
|
}
|
|
}
|
|
|
|
void ps3_smp_cleanup_cpu(int cpu)
|
|
{
|
|
unsigned int *virqs = per_cpu(ps3_ipi_virqs, cpu);
|
|
int i;
|
|
|
|
DBG(" -> %s:%d: (%d)\n", __func__, __LINE__, cpu);
|
|
|
|
for (i = 0; i < MSG_COUNT; i++) {
|
|
/* Can't call free_irq from interrupt context. */
|
|
ps3_event_receive_port_destroy(virqs[i]);
|
|
virqs[i] = 0;
|
|
}
|
|
|
|
DBG(" <- %s:%d: (%d)\n", __func__, __LINE__, cpu);
|
|
}
|
|
|
|
static struct smp_ops_t ps3_smp_ops = {
|
|
.probe = ps3_smp_probe,
|
|
.message_pass = ps3_smp_message_pass,
|
|
.kick_cpu = smp_generic_kick_cpu,
|
|
};
|
|
|
|
void smp_init_ps3(void)
|
|
{
|
|
DBG(" -> %s\n", __func__);
|
|
smp_ops = &ps3_smp_ops;
|
|
DBG(" <- %s\n", __func__);
|
|
}
|