mirror of
https://github.com/torvalds/linux.git
synced 2024-12-28 05:41:55 +00:00
8478132a87
This reverts commit 4dd1837d75.
Moving the exports for assembly code into the assembly files breaks
KSYM trimming, but also breaks modversions.
While fixing the KSYM trimming is trivial, fixing modversions brings
us to a technically worse position that we had prior to the above
change:
- We end up with the prototype definitions divorsed from everything
else, which means that adding or removing assembly level ksyms
become more fragile:
* if adding a new assembly ksyms export, a missed prototype in
asm-prototypes.h results in a successful build if no module in
the selected configuration makes use of the symbol.
* when removing a ksyms export, asm-prototypes.h will get forgotten,
with armksyms.c, you'll get a build error if you forget to touch
the file.
- We end up with the same amount of include files and prototypes,
they're just in a header file instead of a .c file with their
exports.
As for lines of code, we don't get much of a size reduction:
(original commit)
47 files changed, 131 insertions(+), 208 deletions(-)
(fix for ksyms trimming)
7 files changed, 18 insertions(+), 5 deletions(-)
(two fixes for modversions)
1 file changed, 34 insertions(+)
3 files changed, 7 insertions(+), 2 deletions(-)
which results in a net total of only 25 lines deleted.
As there does not seem to be much benefit from this change of approach,
revert the change.
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
38 lines
610 B
ArmAsm
38 lines
610 B
ArmAsm
#include <linux/linkage.h>
|
|
#include <asm/assembler.h>
|
|
|
|
#if __LINUX_ARM_ARCH__ >= 6
|
|
ENTRY(__bswapsi2)
|
|
rev r0, r0
|
|
bx lr
|
|
ENDPROC(__bswapsi2)
|
|
|
|
ENTRY(__bswapdi2)
|
|
rev r3, r0
|
|
rev r0, r1
|
|
mov r1, r3
|
|
bx lr
|
|
ENDPROC(__bswapdi2)
|
|
#else
|
|
ENTRY(__bswapsi2)
|
|
eor r3, r0, r0, ror #16
|
|
mov r3, r3, lsr #8
|
|
bic r3, r3, #0xff00
|
|
eor r0, r3, r0, ror #8
|
|
ret lr
|
|
ENDPROC(__bswapsi2)
|
|
|
|
ENTRY(__bswapdi2)
|
|
mov ip, r1
|
|
eor r3, ip, ip, ror #16
|
|
eor r1, r0, r0, ror #16
|
|
mov r1, r1, lsr #8
|
|
mov r3, r3, lsr #8
|
|
bic r3, r3, #0xff00
|
|
bic r1, r1, #0xff00
|
|
eor r1, r1, r0, ror #8
|
|
eor r0, r3, ip, ror #8
|
|
ret lr
|
|
ENDPROC(__bswapdi2)
|
|
#endif
|