mirror of
https://github.com/torvalds/linux.git
synced 2024-11-25 05:32:00 +00:00
77ab9d4d44
acpi_video_set_dmi_backlight_type() is troublesome because it may end up getting called after other backlight drivers have already called acpi_video_get_backlight_type() resulting in the other drivers already being registered even though they should not. In case of the acpi_video backlight, acpi_video_set_dmi_backlight_type() actually calls acpi_video_unregister_backlight() since that is often probed earlier, leading to userspace seeing the acpi_video0 class device being briefly available, leading to races in userspace where udev probe-rules try to access the device and it is already gone. All callers have been fixed to no longer call it, so remove acpi_video_set_dmi_backlight_type() now. This means we now also no longer need acpi_video_unregister_backlight() for the remove acpi_video backlight after it was wrongly registered hack, so remove that too. Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
101 lines
2.9 KiB
C
101 lines
2.9 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
#ifndef __ACPI_VIDEO_H
|
|
#define __ACPI_VIDEO_H
|
|
|
|
#include <linux/errno.h> /* for ENODEV */
|
|
#include <linux/types.h> /* for bool */
|
|
|
|
struct acpi_video_brightness_flags {
|
|
u8 _BCL_no_ac_battery_levels:1; /* no AC/Battery levels in _BCL */
|
|
u8 _BCL_reversed:1; /* _BCL package is in a reversed order */
|
|
u8 _BQC_use_index:1; /* _BQC returns an index value */
|
|
};
|
|
|
|
struct acpi_video_device_brightness {
|
|
int curr;
|
|
int count;
|
|
int *levels;
|
|
struct acpi_video_brightness_flags flags;
|
|
};
|
|
|
|
struct acpi_device;
|
|
|
|
#define ACPI_VIDEO_CLASS "video"
|
|
|
|
#define ACPI_VIDEO_DISPLAY_CRT 1
|
|
#define ACPI_VIDEO_DISPLAY_TV 2
|
|
#define ACPI_VIDEO_DISPLAY_DVI 3
|
|
#define ACPI_VIDEO_DISPLAY_LCD 4
|
|
|
|
#define ACPI_VIDEO_DISPLAY_LEGACY_MONITOR 0x0100
|
|
#define ACPI_VIDEO_DISPLAY_LEGACY_PANEL 0x0110
|
|
#define ACPI_VIDEO_DISPLAY_LEGACY_TV 0x0200
|
|
|
|
#define ACPI_VIDEO_NOTIFY_SWITCH 0x80
|
|
#define ACPI_VIDEO_NOTIFY_PROBE 0x81
|
|
#define ACPI_VIDEO_NOTIFY_CYCLE 0x82
|
|
#define ACPI_VIDEO_NOTIFY_NEXT_OUTPUT 0x83
|
|
#define ACPI_VIDEO_NOTIFY_PREV_OUTPUT 0x84
|
|
#define ACPI_VIDEO_NOTIFY_CYCLE_BRIGHTNESS 0x85
|
|
#define ACPI_VIDEO_NOTIFY_INC_BRIGHTNESS 0x86
|
|
#define ACPI_VIDEO_NOTIFY_DEC_BRIGHTNESS 0x87
|
|
#define ACPI_VIDEO_NOTIFY_ZERO_BRIGHTNESS 0x88
|
|
#define ACPI_VIDEO_NOTIFY_DISPLAY_OFF 0x89
|
|
|
|
enum acpi_backlight_type {
|
|
acpi_backlight_undef = -1,
|
|
acpi_backlight_none = 0,
|
|
acpi_backlight_video,
|
|
acpi_backlight_vendor,
|
|
acpi_backlight_native,
|
|
acpi_backlight_nvidia_wmi_ec,
|
|
acpi_backlight_apple_gmux,
|
|
};
|
|
|
|
#if IS_ENABLED(CONFIG_ACPI_VIDEO)
|
|
extern int acpi_video_register(void);
|
|
extern void acpi_video_unregister(void);
|
|
extern void acpi_video_register_backlight(void);
|
|
extern int acpi_video_get_edid(struct acpi_device *device, int type,
|
|
int device_id, void **edid);
|
|
extern enum acpi_backlight_type acpi_video_get_backlight_type(void);
|
|
extern bool acpi_video_backlight_use_native(void);
|
|
/*
|
|
* Note: The value returned by acpi_video_handles_brightness_key_presses()
|
|
* may change over time and should not be cached.
|
|
*/
|
|
extern bool acpi_video_handles_brightness_key_presses(void);
|
|
extern int acpi_video_get_levels(struct acpi_device *device,
|
|
struct acpi_video_device_brightness **dev_br,
|
|
int *pmax_level);
|
|
#else
|
|
static inline int acpi_video_register(void) { return -ENODEV; }
|
|
static inline void acpi_video_unregister(void) { return; }
|
|
static inline void acpi_video_register_backlight(void) { return; }
|
|
static inline int acpi_video_get_edid(struct acpi_device *device, int type,
|
|
int device_id, void **edid)
|
|
{
|
|
return -ENODEV;
|
|
}
|
|
static inline enum acpi_backlight_type acpi_video_get_backlight_type(void)
|
|
{
|
|
return acpi_backlight_vendor;
|
|
}
|
|
static inline bool acpi_video_backlight_use_native(void)
|
|
{
|
|
return true;
|
|
}
|
|
static inline bool acpi_video_handles_brightness_key_presses(void)
|
|
{
|
|
return false;
|
|
}
|
|
static inline int acpi_video_get_levels(struct acpi_device *device,
|
|
struct acpi_video_device_brightness **dev_br,
|
|
int *pmax_level)
|
|
{
|
|
return -ENODEV;
|
|
}
|
|
#endif
|
|
|
|
#endif
|