Sean Christopherson ea61294bef Revert "KVM: Prevent module exit until all VMs are freed" ... Revert KVM's misguided attempt to "fix" a use-after-module-unload bug that was actually due to failure to flush a workqueue, not a lack of module refcounting. Pinning the KVM module until kvm_vm_destroy() doesn't prevent use-after-free due to the module being unloaded, as userspace can invoke delete_module() the instant the last reference to KVM is put, i.e. can cause all KVM code to be unmapped while KVM is actively executing said code. Generally speaking, the many instances of module_put(THIS_MODULE) notwithstanding, outside of a few special paths, a module can never safely put the last reference to itself without creating deadlock, i.e. something external to the module *must* put the last reference. In other words, having VMs grab a reference to the KVM module is futile, pointless, and as evidenced by the now-reverted commit 70375c2d8f ("Revert "KVM: set owner of cpu and vm file operations""), actively dangerous. This reverts commit 405294f29f and commit 5f6de5cbeb. Fixes: 405294f29f ("KVM: Unconditionally get a ref to /dev/kvm module when creating a VM") Fixes: 5f6de5cbeb ("KVM: Prevent module exit until all VMs are freed") Link: https://lore.kernel.org/r/20231018204624.1905300-4-seanjc@google.com Signed-off-by: Sean Christopherson <seanjc@google.com>		2023-12-01 08:12:30 -08:00
..
async_pf.c	mm/gup: remove vmas parameter from get_user_pages_remote()	2023-06-09 16:25:26 -07:00
async_pf.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 504	2019-06-19 17:09:56 +02:00
binary_stats.c	KVM: stats: remove dead stores	2021-08-13 03:35:15 -04:00
coalesced_mmio.c	KVM: destruct kvm_io_device while unregistering it from kvm_io_bus	2023-06-13 14:18:09 -07:00
coalesced_mmio.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
dirty_ring.c	KVM: Support dirty ring in conjunction with bitmap	2022-11-10 13:11:58 +00:00
eventfd.c	kvm/eventfd: use list_for_each_entry when deassign ioeventfd	2023-06-13 14:25:39 -07:00
irqchip.c	KVM: replace direct irq.h inclusion	2022-11-09 12:31:37 -05:00
Kconfig	KVM: Remove CONFIG_HAVE_KVM_ARCH_TLB_FLUSH_ALL	2023-08-17 09:35:14 +01:00
kvm_main.c	Revert "KVM: Prevent module exit until all VMs are freed"	2023-12-01 08:12:30 -08:00
kvm_mm.h	kvm: Remove the unused macro KVM_MMU_READ_{,UN}LOCK()	2022-12-27 06:00:51 -05:00
Makefile.kvm	KVM: Reinstate gfn_to_pfn_cache with invalidation support	2022-01-07 10:44:44 -05:00
pfncache.c	KVM: Skip unnecessary "unmap" if gpc is already valid during refresh	2022-11-30 19:25:24 +00:00
vfio.c	kvm/vfio: avoid bouncing the mutex when adding and deleting groups	2023-08-03 12:01:56 -06:00
vfio.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00