Zachary Amsden e9f86e351f [PATCH] x86: remove redundant TSS clearing ... When reviewing GDT updates, I found the code: set_tss_desc(cpu,t); /* This just modifies memory; ... */ per_cpu(cpu_gdt_table, cpu)[GDT_ENTRY_TSS].b &= 0xfffffdff; This second line is unnecessary, since set_tss_desc() has already cleared the busy bit. Commented disassembly, line 1: c028b8bd: 8b 0c 86 mov (%esi,%eax,4),%ecx c028b8c0: 01 cb add %ecx,%ebx c028b8c2: 8d 0c 39 lea (%ecx,%edi,1),%ecx => %ecx = per_cpu(cpu_gdt_table, cpu) c028b8c5: 8d 91 80 00 00 00 lea 0x80(%ecx),%edx => %edx = &per_cpu(cpu_gdt_table, cpu)[GDT_ENTRY_TSS] c028b8cb: 66 c7 42 00 73 20 movw $0x2073,0x0(%edx) c028b8d1: 66 89 5a 02 mov %bx,0x2(%edx) c028b8d5: c1 cb 10 ror $0x10,%ebx c028b8d8: 88 5a 04 mov %bl,0x4(%edx) c028b8db: c6 42 05 89 movb $0x89,0x5(%edx) => ((char *)%edx)[5] = 0x89 (equivalent) ((char *)per_cpu(cpu_gdt_table, cpu)[GDT_ENTRY_TSS])[5] = 0x89 c028b8df: c6 42 06 00 movb $0x0,0x6(%edx) c028b8e3: 88 7a 07 mov %bh,0x7(%edx) c028b8e6: c1 cb 10 ror $0x10,%ebx => other bits Commented disassembly, line 2: c028b8e9: 8b 14 86 mov (%esi,%eax,4),%edx c028b8ec: 8d 04 3a lea (%edx,%edi,1),%eax => %eax = per_cpu(cpu_gdt_table, cpu) c028b8ef: 81 a0 84 00 00 00 ff andl $0xfffffdff,0x84(%eax) => per_cpu(cpu_gdt_table, cpu)[GDT_ENTRY_TSS].b &= 0xfffffdff; (equivalent) ((char *)per_cpu(cpu_gdt_table, cpu)[GDT_ENTRY_TSS])[5] &= 0xfd Note that (0x89 & ~0xfd) == 0; i.e, set_tss_desc(cpu,t) has already stored the type field in the GDT with the busy bit clear. Eliminating redundant and obscure code is always a good thing; in fact, I pointed out this same optimization many moons ago in arch/i386/setup.c, back when it used to be called that. Signed-off-by: Zachary Amsden <zach@vmware.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>		2005-09-05 00:06:13 -07:00
..
boot	[PATCH] coverity: i386: build.c: negative return to unsigned fix	2005-06-28 21:20:33 -07:00
crypto	[PATCH] arch/i386/crypto/aes.c: fix sparse warnings	2005-06-25 16:24:59 -07:00
kernel	[PATCH] x86: make IOPL explicit	2005-09-05 00:06:12 -07:00
lib	[PATCH] Remove i386_ksyms.c, almost.	2005-06-23 09:45:11 -07:00
mach-default	[PATCH] x86_64: CPU hotplug support	2005-06-25 16:24:30 -07:00
mach-es7000	[PATCH] ES7000 platform update (i386)	2005-09-05 00:06:10 -07:00
mach-generic	[PATCH] x86: sutomatically enable bigsmp when we have more than 8 CPUs	2005-09-05 00:06:10 -07:00
mach-visws	[PATCH] visws: linkage fix	2005-08-07 10:00:38 -07:00
mach-voyager	[PATCH] x86: more asm cleanups	2005-09-05 00:06:12 -07:00
math-emu	[PATCH] i386: inline assembler: cleanup and encapsulate descriptor and task register management	2005-09-05 00:06:11 -07:00
mm	[PATCH] i386: use set_pte macros in a couple places where they were missing	2005-09-05 00:06:12 -07:00
oprofile	[PATCH] xen: x86: Rename usermode macro	2005-06-23 09:45:14 -07:00
pci	[PATCH] x86: pci_assign_unassigned_resources() update	2005-08-30 11:14:48 -07:00
power	[PATCH] x86: remove redundant TSS clearing	2005-09-05 00:06:13 -07:00
defconfig	[PATCH] swsusp: kill config_pm_disk	2005-06-25 16:24:32 -07:00
Kconfig	[PATCH] sparsemem extreme implementation	2005-09-05 00:05:38 -07:00
Kconfig.debug	[PATCH] i386: add missing Kconfig help text	2005-07-27 16:25:58 -07:00
Makefile	[PATCH] biarch compiler support for i386	2005-06-23 09:45:07 -07:00