mirror of
https://github.com/torvalds/linux.git
synced 2024-12-28 05:41:55 +00:00
e8184e10f8
As pointed out by Andreas Schwab, pointers passed to ARAnyM NatFeat calls
should be physical addresses, not virtual addresses.
Fortunately on Atari, physical and virtual kernel addresses are the same,
as long as normal kernel memory is concerned, so this usually worked fine
without conversion.
But for modules, pointers to literal strings are located in vmalloc()ed
memory. Depending on the version of ARAnyM, this causes the nf_get_id()
call to just fail, or worse, crash ARAnyM itself with e.g.
Gotcha! Illegal memory access. Atari PC = $968c
This is a big issue for distro kernels, who want to have all drivers as
loadable modules in an initrd.
Add a wrapper for nf_get_id() that copies the literal to the stack to
work around this issue.
Reported-by: Thorsten Glaser <tg@debian.org>
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: stable@vger.kernel.org
94 lines
1.8 KiB
C
94 lines
1.8 KiB
C
/*
|
|
* natfeat.c - ARAnyM hardware support via Native Features (natfeats)
|
|
*
|
|
* Copyright (c) 2005 Petr Stehlik of ARAnyM dev team
|
|
*
|
|
* Reworked for Linux by Roman Zippel <zippel@linux-m68k.org>
|
|
*
|
|
* This software may be used and distributed according to the terms of
|
|
* the GNU General Public License (GPL), incorporated herein by reference.
|
|
*/
|
|
|
|
#include <linux/types.h>
|
|
#include <linux/console.h>
|
|
#include <linux/string.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/io.h>
|
|
#include <asm/machdep.h>
|
|
#include <asm/natfeat.h>
|
|
|
|
extern long nf_get_id2(const char *feature_name);
|
|
|
|
asm("\n"
|
|
" .global nf_get_id2,nf_call\n"
|
|
"nf_get_id2:\n"
|
|
" .short 0x7300\n"
|
|
" rts\n"
|
|
"nf_call:\n"
|
|
" .short 0x7301\n"
|
|
" rts\n"
|
|
"1: moveq.l #0,%d0\n"
|
|
" rts\n"
|
|
" .section __ex_table,\"a\"\n"
|
|
" .long nf_get_id2,1b\n"
|
|
" .long nf_call,1b\n"
|
|
" .previous");
|
|
EXPORT_SYMBOL_GPL(nf_call);
|
|
|
|
long nf_get_id(const char *feature_name)
|
|
{
|
|
/* feature_name may be in vmalloc()ed memory, so make a copy */
|
|
char name_copy[32];
|
|
size_t n;
|
|
|
|
n = strlcpy(name_copy, feature_name, sizeof(name_copy));
|
|
if (n >= sizeof(name_copy))
|
|
return 0;
|
|
|
|
return nf_get_id2(name_copy);
|
|
}
|
|
EXPORT_SYMBOL_GPL(nf_get_id);
|
|
|
|
void nfprint(const char *fmt, ...)
|
|
{
|
|
static char buf[256];
|
|
va_list ap;
|
|
int n;
|
|
|
|
va_start(ap, fmt);
|
|
n = vsnprintf(buf, 256, fmt, ap);
|
|
nf_call(nf_get_id("NF_STDERR"), buf);
|
|
va_end(ap);
|
|
}
|
|
|
|
static void nf_poweroff(void)
|
|
{
|
|
long id = nf_get_id("NF_SHUTDOWN");
|
|
|
|
if (id)
|
|
nf_call(id);
|
|
}
|
|
|
|
void nf_init(void)
|
|
{
|
|
unsigned long id, version;
|
|
char buf[256];
|
|
|
|
id = nf_get_id("NF_VERSION");
|
|
if (!id)
|
|
return;
|
|
version = nf_call(id);
|
|
|
|
id = nf_get_id("NF_NAME");
|
|
if (!id)
|
|
return;
|
|
nf_call(id, buf, 256);
|
|
buf[255] = 0;
|
|
|
|
pr_info("NatFeats found (%s, %lu.%lu)\n", buf, version >> 16,
|
|
version & 0xffff);
|
|
|
|
mach_power_off = nf_poweroff;
|
|
}
|