mirror of
https://github.com/torvalds/linux.git
synced 2024-12-22 10:56:40 +00:00
e7d2860b69
Makes use of skip_spaces() defined in lib/string.c for removing leading spaces from strings all over the tree. It decreases lib.a code size by 47 bytes and reuses the function tree-wide: text data bss dec hex filename 64688 584 592 65864 10148 (TOTALS-BEFORE) 64641 584 592 65817 10119 (TOTALS-AFTER) Also, while at it, if we see (*str && isspace(*str)), we can be sure to remove the first condition (*str) as the second one (isspace(*str)) also evaluates to 0 whenever *str == 0, making it redundant. In other words, "a char equals zero is never a space". Julia Lawall tried the semantic patch (http://coccinelle.lip6.fr) below, and found occurrences of this pattern on 3 more files: drivers/leds/led-class.c drivers/leds/ledtrig-timer.c drivers/video/output.c @@ expression str; @@ ( // ignore skip_spaces cases while (*str && isspace(*str)) { \(str++;\|++str;\) } | - *str && isspace(*str) ) Signed-off-by: André Goddard Rosa <andre.goddard@gmail.com> Cc: Julia Lawall <julia@diku.dk> Cc: Martin Schwidefsky <schwidefsky@de.ibm.com> Cc: Jeff Dike <jdike@addtoit.com> Cc: Ingo Molnar <mingo@elte.hu> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: "H. Peter Anvin" <hpa@zytor.com> Cc: Richard Purdie <rpurdie@rpsys.net> Cc: Neil Brown <neilb@suse.de> Cc: Kyle McMartin <kyle@mcmartin.ca> Cc: Henrique de Moraes Holschuh <hmh@hmh.eng.br> Cc: David Howells <dhowells@redhat.com> Cc: <linux-ext4@vger.kernel.org> Cc: Samuel Ortiz <samuel@sortiz.org> Cc: Patrick McHardy <kaber@trash.net> Cc: Takashi Iwai <tiwai@suse.de> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> |
||
|---|---|---|
| .. | ||
| vdso32 | ||
| vdso64 | ||
| asm-offsets.c | ||
| audit.c | ||
| audit.h | ||
| base.S | ||
| bitmap.c | ||
| compat_audit.c | ||
| compat_exec_domain.c | ||
| compat_linux.c | ||
| compat_linux.h | ||
| compat_ptrace.h | ||
| compat_signal.c | ||
| compat_wrapper.S | ||
| cpcmd.c | ||
| crash.c | ||
| debug.c | ||
| diag.c | ||
| dis.c | ||
| early.c | ||
| ebcdic.c | ||
| entry64.S | ||
| entry.h | ||
| entry.S | ||
| ftrace.c | ||
| head31.S | ||
| head64.S | ||
| head.S | ||
| init_task.c | ||
| ipl.c | ||
| irq.c | ||
| kprobes.c | ||
| machine_kexec.c | ||
| Makefile | ||
| mcount64.S | ||
| mcount.S | ||
| mem_detect.c | ||
| module.c | ||
| nmi.c | ||
| process.c | ||
| processor.c | ||
| ptrace.c | ||
| reipl64.S | ||
| reipl.S | ||
| relocate_kernel64.S | ||
| relocate_kernel.S | ||
| s390_ext.c | ||
| s390_ksyms.c | ||
| sclp.S | ||
| setup.c | ||
| signal.c | ||
| smp.c | ||
| stacktrace.c | ||
| suspend.c | ||
| swsusp_asm64.S | ||
| sys_s390.c | ||
| syscalls.S | ||
| sysinfo.c | ||
| time.c | ||
| topology.c | ||
| traps.c | ||
| vdso.c | ||
| vmlinux.lds.S | ||
| vtime.c | ||