Pablo Neira Ayuso 70e9942f17 netfilter: nf_conntrack: make event callback registration per-netns ... This patch fixes an oops that can be triggered following this recipe: 0) make sure nf_conntrack_netlink and nf_conntrack_ipv4 are loaded. 1) container is started. 2) connect to it via lxc-console. 3) generate some traffic with the container to create some conntrack entries in its table. 4) stop the container: you hit one oops because the conntrack table cleanup tries to report the destroy event to user-space but the per-netns nfnetlink socket has already gone (as the nfnetlink socket is per-netns but event callback registration is global). To fix this situation, we make the ctnl_notifier per-netns so the callback is registered/unregistered if the container is created/destroyed. Alex Bligh and Alexey Dobriyan originally proposed one small patch to check if the nfnetlink socket is gone in nfnetlink_has_listeners, but this is a very visited path for events, thus, it may reduce performance and it looks a bit hackish to check for the nfnetlink socket only to workaround this situation. As a result, I decided to follow the bigger path choice, which seems to look nicer to me. Cc: Alexey Dobriyan <adobriyan@gmail.com> Reported-by: Alex Bligh <alex@alex.org.uk> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>		2011-11-22 00:34:47 +01:00
..
conntrack.h	netfilter: nf_conntrack: make event callback registration per-netns	2011-11-22 00:34:47 +01:00
core.h
dccp.h
generic.h	netns: let net_generic take pointer-to-const args	2010-11-21 10:05:10 -08:00
hash.h
ipv4.h	net: ipv4: add IPPROTO_ICMP socket kind	2011-05-13 16:08:13 -04:00
ipv6.h	ipv6: ip6mr: support multiple tables	2010-05-11 14:40:55 +02:00
mib.h
packet.h	packet: convert socket list to RCU (v3)	2010-02-22 15:45:56 -08:00
unix.h
x_tables.h
xfrm.h	netns: reorder fields in struct net	2010-10-17 13:49:14 -07:00