linux/drivers/pci/pcie/aer
Rasmus Villemoes a1b7f2f636 PCI/AER: Avoid info leak in __print_tlp_header()
Commit fab4c256a5 ("PCI/AER: Add a TLP header print helper") introduced
the helper function __print_tlp_header(), but contrary to the intention,
the behaviour did change: Since we're taking the address of the parameter
t, the first 4 or 8 bytes printed will be the value of the pointer t
itself, and the remaining 12 or 8 bytes will be who-knows-what (something
from the stack).

We want to show the values of the four members of the struct
aer_header_log_regs; that can be done without ugly and error-prone casts.
On little-endian this should produce the same output as originally
intended, and since no-one has complained about getting garbage output so
far, I think big-endian should be ok too.

Fixes: fab4c256a5 ("PCI/AER: Add a TLP header print helper")
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Borislav Petkov <bp@suse.de>
CC: stable@vger.kernel.org	# v3.14+
2015-03-06 12:30:23 -06:00
..
aer_inject.c PCI: Merge multi-line quoted strings 2014-06-10 20:20:42 -06:00
aerdrv_acpi.c PCI/AER: Support ACPI HEST AER error sources for PCI domains other than 0 2014-01-13 12:18:55 -07:00
aerdrv_core.c PCI: Whitespace cleanup 2014-06-10 20:20:19 -06:00
aerdrv_errprint.c PCI/AER: Avoid info leak in __print_tlp_header() 2015-03-06 12:30:23 -06:00
aerdrv.c PCI: Remove aer_do_secondary_bus_reset() 2013-08-14 15:25:59 -06:00
aerdrv.h PCI: Remove aer_do_secondary_bus_reset() 2013-08-14 15:25:59 -06:00
ecrc.c PCIe AER: use pci_is_pcie() 2009-11-24 15:25:17 -08:00
Kconfig kconfig: use bool instead of boolean for type definition attributes 2015-01-07 13:08:04 +01:00
Kconfig.debug PCI: change PCI nomenclature in drivers/pci/ (non-comment changes) 2009-12-16 13:37:54 -08:00
Makefile PCI AER: software error injection 2009-06-16 14:30:14 -07:00