Matthew Wilcox abc1be13fd mm/filemap.c: fix NULL pointer in page_cache_tree_insert() ... f2fs specifies the __GFP_ZERO flag for allocating some of its pages. Unfortunately, the page cache also uses the mapping's GFP flags for allocating radix tree nodes. It always masked off the __GFP_HIGHMEM flag, and masks off __GFP_ZERO in some paths, but not all. That causes radix tree nodes to be allocated with a NULL list_head, which causes backtraces like: __list_del_entry+0x30/0xd0 list_lru_del+0xac/0x1ac page_cache_tree_insert+0xd8/0x110 The __GFP_DMA and __GFP_DMA32 flags would also be able to sneak through if they are ever used. Fix them all by using GFP_RECLAIM_MASK at the innermost location, and remove it from earlier in the callchain. Link: http://lkml.kernel.org/r/20180411060320.14458-2-willy@infradead.org Fixes: 449dd6984d ("mm: keep page cache radix tree nodes in check") Signed-off-by: Matthew Wilcox <mawilcox@microsoft.com> Reported-by: Chris Fries <cfries@google.com> Debugged-by: Minchan Kim <minchan@kernel.org> Acked-by: Johannes Weiner <hannes@cmpxchg.org> Acked-by: Michal Hocko <mhocko@suse.com> Reviewed-by: Jan Kara <jack@suse.cz> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>		2018-04-20 17:18:36 -07:00
..
kasan	slab, slub: skip unnecessary kasan_cache_shutdown()	2018-04-05 21:36:24 -07:00
backing-dev.c	mm/vmscan: don't mess with pgdat->flags in memcg reclaim	2018-04-11 10:28:30 -07:00
balloon_compaction.c
bootmem.c	mm: docs: fix parameter names mismatch	2018-02-06 18:32:48 -08:00
cleancache.c
cma_debug.c
cma.c	mm/cma: manage the memory of the CMA area by using the ZONE_MOVABLE	2018-04-11 10:28:32 -07:00
cma.h
compaction.c	mm/cma: remove ALLOC_CMA	2018-04-11 10:28:32 -07:00
debug_page_ref.c
debug.c
dmapool.c
early_ioremap.c
fadvise.c	mm: add ksys_fadvise64_64() helper; remove in-kernel call to sys_fadvise64_64()	2018-04-02 20:16:10 +02:00
failslab.c	mm: make should_failslab always available for fault injection	2018-04-05 21:36:26 -07:00
filemap.c	mm/filemap.c: fix NULL pointer in page_cache_tree_insert()	2018-04-20 17:18:36 -07:00
frame_vector.c
frontswap.c
gup_benchmark.c	mm/gup_benchmark: handle gup failures	2018-04-13 17:10:27 -07:00
gup.c	mm/gup.c: document return value	2018-04-13 17:10:27 -07:00
highmem.c
hmm.c	mm/hmm.c: remove superfluous RCU protection around radix tree lookup	2018-04-11 10:28:31 -07:00
huge_memory.c	mm: enable thp migration for shmem thp	2018-04-20 17:18:35 -07:00
hugetlb_cgroup.c
hugetlb.c	mm, hugetlbfs: introduce ->pagesize() to vm_operations_struct	2018-04-05 21:36:26 -07:00
hwpoison-inject.c
init-mm.c
internal.h	mm/cma: remove ALLOC_CMA	2018-04-11 10:28:32 -07:00
interval_tree.c
Kconfig	treewide: simplify Kconfig dependencies for removed archs	2018-03-26 15:55:57 +02:00
Kconfig.debug
khugepaged.c	page cache: use xa_lock	2018-04-11 10:28:39 -07:00
kmemleak-test.c
kmemleak.c	mm: kernel-doc: add missing parameter descriptions	2018-04-05 21:36:27 -07:00
ksm.c	mm/ksm.c: fix inconsistent accounting of zero pages	2018-04-11 10:28:31 -07:00
list_lru.c	mm: make counting of list_lru_one::nr_items lockless	2018-04-05 21:36:27 -07:00
maccess.c	mm: docs: fix parameter names mismatch	2018-02-06 18:32:48 -08:00
madvise.c
Makefile	mm/swap_slots.c: use conditional compilation	2018-04-05 21:36:24 -07:00
memblock.c	powerpc updates for 4.17	2018-04-07 12:08:19 -07:00
memcontrol.c	mm: memcg: add __GFP_NOWARN in __memcg_schedule_kmem_cache_create()	2018-04-20 17:18:36 -07:00
memory_hotplug.c	mm: unclutter THP migration	2018-04-11 10:28:32 -07:00
memory-failure.c	mm, migrate: remove reason argument from new_page_t	2018-04-11 10:28:32 -07:00
memory.c	mm: swap: unify cluster-based and vma-based swap readahead	2018-04-05 21:36:25 -07:00
mempolicy.c	mm: unclutter THP migration	2018-04-11 10:28:32 -07:00
mempool.c	kasan: detect invalid frees for large mempool objects	2018-02-06 18:32:43 -08:00
memtest.c
migrate.c	mm: enable thp migration for shmem thp	2018-04-20 17:18:35 -07:00
mincore.c
mlock.c	mm, mlock, vmscan: no more skipping pagevecs	2018-02-21 15:35:42 -08:00
mm_init.c
mmap.c	mm: introduce MAP_FIXED_NOREPLACE	2018-04-11 10:28:38 -07:00
mmu_context.c
mmu_notifier.c
mmzone.c
mprotect.c	sched/numa: avoid trapping faults and attempting migration of file-backed dirty pages	2018-04-11 10:28:31 -07:00
mremap.c
msync.c
nobootmem.c
nommu.c	mm/nommu: remove description of alloc_vm_area	2018-04-05 21:36:26 -07:00
oom_kill.c	mm,oom_reaper: check for MMF_OOM_SKIP before complaining	2018-04-05 21:36:27 -07:00
page_alloc.c	xen, mm: allow deferred page initialization for xen pv domains	2018-04-11 10:28:38 -07:00
page_counter.c
page_ext.c	mm/page_ext.c: make page_ext_init a noop when CONFIG_PAGE_EXTENSION but nothing uses it	2018-01-31 17:18:39 -08:00
page_idle.c	mm: thp: fix potential clearing to referenced flag in page_idle_clear_pte_refs_one()	2018-04-05 21:36:25 -07:00
page_io.c
page_isolation.c	mm, migrate: remove reason argument from new_page_t	2018-04-11 10:28:32 -07:00
page_owner.c	mm/page_owner.c: make early_page_owner_param() __init	2018-04-05 21:36:26 -07:00
page_poison.c	mm/page_poison.c: make early_page_poison_param() __init	2018-04-05 21:36:26 -07:00
page_vma_mapped.c
page-writeback.c	writeback: safer lock nesting	2018-04-20 17:18:35 -07:00
pagewalk.c	mm: kernel-doc: add missing parameter descriptions	2018-04-05 21:36:27 -07:00
percpu-internal.h
percpu-km.c	percpu: allow select gfp to be passed to underlying allocators	2018-02-18 05:33:01 -08:00
percpu-stats.c	mm: reuse DEFINE_SHOW_ATTRIBUTE() macro	2018-04-05 21:36:25 -07:00
percpu-vm.c	percpu: allow select gfp to be passed to underlying allocators	2018-02-18 05:33:01 -08:00
percpu.c	arch: remove obsolete architecture ports	2018-04-02 20:20:12 -07:00
pgtable-generic.c
process_vm_access.c	mm: docs: add blank lines to silence sphinx "Unexpected indentation" errors	2018-02-06 18:32:48 -08:00
quicklist.c
readahead.c	page cache: use xa_lock	2018-04-11 10:28:39 -07:00
rmap.c	mm: enable thp migration for shmem thp	2018-04-20 17:18:35 -07:00
rodata_test.c
shmem.c	page cache: use xa_lock	2018-04-11 10:28:39 -07:00
slab_common.c	mm: make should_failslab always available for fault injection	2018-04-05 21:36:26 -07:00
slab.c	mm, slab: reschedule cache_reap() on the same CPU	2018-04-13 17:10:27 -07:00
slab.h	slab, slub: skip unnecessary kasan_cache_shutdown()	2018-04-05 21:36:24 -07:00
slob.c
slub.c	kasan, slub: fix handling of kasan_slab_free hook	2018-04-11 10:28:32 -07:00
sparse-vmemmap.c
sparse.c	mm/memory_hotplug: optimize memory hotplug	2018-04-05 21:36:25 -07:00
swap_cgroup.c
swap_slots.c	mm/swap_slots.c: use conditional compilation	2018-04-05 21:36:24 -07:00
swap_state.c	page cache: use xa_lock	2018-04-11 10:28:39 -07:00
swap.c	mm/swap.c: remove @cold parameter description for release_pages()	2018-04-05 21:36:26 -07:00
swapfile.c	mm/swapfile.c: make pointer swap_avail_heads static	2018-04-11 10:28:32 -07:00
truncate.c	page cache: use xa_lock	2018-04-11 10:28:39 -07:00
usercopy.c
userfaultfd.c	mm/userfaultfd.c: remove duplicate include	2018-02-06 18:32:47 -08:00
util.c	mm/gup.c: document return value	2018-04-13 17:10:27 -07:00
vmacache.c
vmalloc.c	vmalloc: fix __GFP_HIGHMEM usage for vmalloc_32 on 32b systems	2018-02-21 15:35:43 -08:00
vmpressure.c
vmscan.c	mm,vmscan: Allow preallocating memory for register_shrinker().	2018-04-16 02:06:47 -04:00
vmstat.c	mm: introduce NR_INDIRECTLY_RECLAIMABLE_BYTES	2018-04-11 10:28:29 -07:00
workingset.c	page cache: use xa_lock	2018-04-11 10:28:39 -07:00
z3fold.c	mm/z3fold.c: use gfpflags_allow_blocking	2018-04-11 10:28:31 -07:00
zbud.c	mm: docs: fix parameter names mismatch	2018-02-06 18:32:48 -08:00
zpool.c	mm/zpool.c: zpool_evictable: fix mismatch in parameter name and kernel-doc	2018-02-21 15:35:43 -08:00
zsmalloc.c	mm: kernel-doc: add missing parameter descriptions	2018-04-05 21:36:27 -07:00
zswap.c	mm, swap, frontswap: fix THP swap if frontswap enabled	2018-02-21 15:35:43 -08:00