mirror of
https://github.com/torvalds/linux.git
synced 2024-12-03 17:41:22 +00:00
df4393424a
There is an issue with threaded interrupts which are marked ONESHOT
and using the fasteoi handler:
if (IS_ONESHOT())
mask_irq();
....
cond_unmask_eoi_irq()
chip->irq_eoi();
if (setaffinity_pending) {
mask_ioapic();
...
move_affinity();
unmask_ioapic();
}
So if setaffinity is pending the interrupt will be moved and then
unconditionally unmasked at the ioapic level, which is wrong in two
aspects:
1) It should be kept masked up to the point where the threaded handler
finished.
2) The physical chip state and the software masked state are inconsistent
Guard both the mask and the unmask with a check for the software masked
state. If the line is marked masked then the ioapic line is also masked, so
both mask_ioapic() and unmask_ioapic() can be skipped safely.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Sebastian Siewior <bigeasy@linutronix.de>
Fixes:
|
||
|---|---|---|
| .. | ||
| apic_common.c | ||
| apic_flat_64.c | ||
| apic_noop.c | ||
| apic_numachip.c | ||
| apic.c | ||
| bigsmp_32.c | ||
| hw_nmi.c | ||
| io_apic.c | ||
| ipi.c | ||
| local.h | ||
| Makefile | ||
| msi.c | ||
| probe_32.c | ||
| probe_64.c | ||
| vector.c | ||
| x2apic_cluster.c | ||
| x2apic_phys.c | ||
| x2apic_uv_x.c | ||