Shung-Hsi Yu deac5871eb bpf: use check_sub_overflow() to check for subtraction overflows ... Similar to previous patch that drops signed_add*_overflows() and uses (compiler) builtin-based check_add_overflow(), do the same for signed_sub*_overflows() and replace them with the generic check_sub_overflow() to make future refactoring easier and have the checks implemented more efficiently. Unsigned overflow check for subtraction does not use helpers and are simple enough already, so they're left untouched. After the change GCC 13.3.0 generates cleaner assembly on x86_64: if (check_sub_overflow(*dst_smin, src_reg->smax_value, dst_smin) || 139bf: mov 0x28(%r12),%rax 139c4: mov %edx,0x54(%r12) 139c9: sub %r11,%rax 139cc: mov %rax,0x28(%r12) 139d1: jo 14627 <adjust_reg_min_max_vals+0x1237> check_sub_overflow(*dst_smax, src_reg->smin_value, dst_smax)) { 139d7: mov 0x30(%r12),%rax 139dc: sub %r9,%rax 139df: mov %rax,0x30(%r12) if (check_sub_overflow(*dst_smin, src_reg->smax_value, dst_smin) || 139e4: jo 14627 <adjust_reg_min_max_vals+0x1237> ... *dst_smin = S64_MIN; 14627: movabs $0x8000000000000000,%rax 14631: mov %rax,0x28(%r12) *dst_smax = S64_MAX; 14636: sub $0x1,%rax 1463a: mov %rax,0x30(%r12) Before the change it gives: if (signed_sub_overflows(dst_reg->smin_value, smax_val) || 13a50: mov 0x28(%r12),%rdi 13a55: mov %edx,0x54(%r12) dst_reg->smax_value = S64_MAX; 13a5a: movabs $0x7fffffffffffffff,%rdx 13a64: mov %eax,0x50(%r12) dst_reg->smin_value = S64_MIN; 13a69: movabs $0x8000000000000000,%rax s64 res = (s64)((u64)a - (u64)b); 13a73: mov %rdi,%rsi 13a76: sub %rcx,%rsi if (b < 0) 13a79: test %rcx,%rcx 13a7c: js 145ea <adjust_reg_min_max_vals+0x119a> if (signed_sub_overflows(dst_reg->smin_value, smax_val) || 13a82: cmp %rsi,%rdi 13a85: jl 13ac7 <adjust_reg_min_max_vals+0x677> signed_sub_overflows(dst_reg->smax_value, smin_val)) { 13a87: mov 0x30(%r12),%r8 s64 res = (s64)((u64)a - (u64)b); 13a8c: mov %r8,%rax 13a8f: sub %r9,%rax return res > a; 13a92: cmp %rax,%r8 13a95: setl %sil if (b < 0) 13a99: test %r9,%r9 13a9c: js 147d1 <adjust_reg_min_max_vals+0x1381> dst_reg->smax_value = S64_MAX; 13aa2: movabs $0x7fffffffffffffff,%rdx dst_reg->smin_value = S64_MIN; 13aac: movabs $0x8000000000000000,%rax if (signed_sub_overflows(dst_reg->smin_value, smax_val) || 13ab6: test %sil,%sil 13ab9: jne 13ac7 <adjust_reg_min_max_vals+0x677> dst_reg->smin_value -= smax_val; 13abb: mov %rdi,%rax dst_reg->smax_value -= smin_val; 13abe: mov %r8,%rdx dst_reg->smin_value -= smax_val; 13ac1: sub %rcx,%rax dst_reg->smax_value -= smin_val; 13ac4: sub %r9,%rdx 13ac7: mov %rax,0x28(%r12) ... 13ad1: mov %rdx,0x30(%r12) ... if (signed_sub_overflows(dst_reg->smin_value, smax_val) || 145ea: cmp %rsi,%rdi 145ed: jg 13ac7 <adjust_reg_min_max_vals+0x677> 145f3: jmp 13a87 <adjust_reg_min_max_vals+0x637> Suggested-by: Jiri Olsa <jolsa@kernel.org> Signed-off-by: Shung-Hsi Yu <shung-hsi.yu@suse.com> Acked-by: Jiri Olsa <jolsa@kernel.org> Link: https://lore.kernel.org/r/20240712080127.136608-4-shung-hsi.yu@suse.com Signed-off-by: Alexei Starovoitov <ast@kernel.org>		2024-07-12 08:54:08 -07:00
..
bpf	bpf: use check_sub_overflow() to check for subtraction overflows	2024-07-12 08:54:08 -07:00
cgroup	Misc fixes:	2024-05-19 11:38:15 -07:00
configs	hardening updates for 6.10-rc1	2024-05-13 14:14:05 -07:00
debug	kdb: Simplify management of tmpbuffer in kdb_read()	2024-04-26 17:13:31 +01:00
dma	dma-mapping: benchmark: handle NUMA_NO_NODE correctly	2024-05-23 15:06:48 +02:00
entry	entry: Respect changes to system call number by trace_sys_enter()	2024-03-12 13:23:32 +01:00
events	perf/core: Fix missing wakeup when waiting for context reference	2024-06-05 15:52:33 +02:00
futex	printk: Change type of CONFIG_BASE_SMALL to bool	2024-05-06 17:39:09 +02:00
gcov	gcov: add support for GCC 14	2024-06-15 10:43:06 -07:00
irq	genirq/irqdesc: Prevent use-after-free in irq_find_at_or_after()	2024-05-24 12:49:35 +02:00
kcsan	kcsan, compiler_types: Introduce __data_racy type qualifier	2024-05-07 11:39:50 -07:00
livepatch	livepatch: Rename KLP_* to KLP_TRANSITION_*	2024-05-09 15:48:01 +02:00
locking	locking/local_lock: Add local nested BH locking infrastructure.	2024-06-24 16:41:22 -07:00
module	bpf-next-for-netdev	2024-07-09 17:01:46 +02:00
power	vfs-6.10-rc2.fixes	2024-05-27 08:09:12 -07:00
printk	Revert "printk: Save console options for add_preferred_console_match()"	2024-06-25 07:58:10 +02:00
rcu	Merge branches 'fixes.2024.04.15a', 'misc.2024.04.12a', 'rcu-sync-normal-improve.2024.04.15a', 'rcu-tasks.2024.04.15a' and 'rcutorture.2024.04.15a' into rcu-merge.2024.04.15a	2024-05-01 13:04:02 +02:00
sched	bitmap patches for 6.10	2024-05-21 15:29:01 -07:00
time	hrtimer: Prevent queuing of hrtimer without a function callback	2024-06-25 16:54:27 +02:00
trace	bpf-next-for-netdev	2024-07-09 17:01:46 +02:00
.gitignore
acct.c	kernel misc: Remove the now superfluous sentinel elements from ctl_table array	2024-04-24 09:43:53 +02:00
async.c	async: Use a dedicated unbound workqueue with raised min_active	2024-02-09 11:13:59 -10:00
audit_fsnotify.c
audit_tree.c	fsnotify: create a wrapper fsnotify_find_inode_mark()	2024-04-04 16:24:16 +02:00
audit_watch.c	fsnotify: create a wrapper fsnotify_find_inode_mark()	2024-04-04 16:24:16 +02:00
audit.c	audit: use KMEM_CACHE() instead of kmem_cache_create()	2024-01-25 10:12:22 -05:00
audit.h	audit: correct audit_filter_inodes() definition	2023-07-21 12:17:25 -04:00
auditfilter.c	ima: Avoid blocking in RCU read-side critical section	2024-06-13 14:26:50 -04:00
auditsc.c	audit,io_uring: io_uring openat triggers audit reference count underflow	2023-10-13 18:34:46 +02:00
backtracetest.c	backtracetest: Convert from tasklet to BH workqueue	2024-02-05 13:22:34 -10:00
bounds.c	bounds: Use the right number of bits for power-of-two CONFIG_NR_CPUS	2024-04-29 08:29:29 -07:00
capability.c	lsm: constify the 'target' parameter in security_capget()	2023-08-08 16:48:47 -04:00
cfi.c
compat.c
configs.c
context_tracking.c	context_tracking: Make context_tracking_key __ro_after_init	2024-03-22 11:18:18 +01:00
cpu_pm.c
cpu.c	cpu: Fix broken cmdline "nosmp" and "maxcpus=0"	2024-06-23 20:04:14 +02:00
crash_core.c	Mainly singleton patches, documented in their respective changelogs.	2024-05-19 14:02:03 -07:00
crash_reserve.c	crash: add prefix for crash dumping messages	2024-05-08 08:41:26 -07:00
cred.c	cred: Use KMEM_CACHE() instead of kmem_cache_create()	2024-02-23 17:33:31 -05:00
delayacct.c	delayacct: Remove the now superfluous sentinel elements from ctl_table array	2024-04-24 09:43:54 +02:00
dma.c
elfcorehdr.c	crash: remove dependency of FA_DUMP on CRASH_DUMP	2024-02-23 17:48:22 -08:00
exec_domain.c
exit.c	mm: optimize the redundant loop of mm_update_owner_next()	2024-07-03 12:29:24 -07:00
exit.h	exit: add internal include file with helpers	2023-09-21 12:03:50 -06:00
extable.c
fail_function.c
fork.c	net: Remove task_struct::bpf_net_context init on fork.	2024-07-02 15:26:57 +02:00
freezer.c	Linux 6.7-rc6	2023-12-23 15:52:13 +01:00
gen_kheaders.sh	kheaders: use command -v to test for existence of cpio	2024-05-30 01:13:20 +09:00
groups.c	groups: Convert group_info.usage to refcount_t	2023-09-29 11:28:39 -07:00
hung_task.c	kernel misc: Remove the now superfluous sentinel elements from ctl_table array	2024-04-24 09:43:53 +02:00
iomem.c	kernel/iomem.c: remove __weak ioremap_cache helper	2023-08-21 13:37:28 -07:00
irq_work.c
jump_label.c	jump_label,module: Don't alloc static_key_mod for __ro_after_init keys	2024-03-22 11:18:16 +01:00
kallsyms_internal.h	kallsyms: Avoid weak references for kallsyms symbols	2024-05-02 19:48:26 +09:00
kallsyms_selftest.c	mm: vmalloc: enable memory allocation profiling	2024-04-25 20:55:57 -07:00
kallsyms_selftest.h
kallsyms.c	kallsyms: rework symbol lookup return codes	2024-06-27 17:43:40 +02:00
kcmp.c	file: convert to SLAB_TYPESAFE_BY_RCU	2023-10-19 11:02:48 +02:00
Kconfig.freezer
Kconfig.hz
Kconfig.kexec	crash: clean up kdump related config items	2024-02-23 17:48:22 -08:00
Kconfig.locks
Kconfig.preempt
kcov.c	kcov: don't lose track of remote references during softirqs	2024-06-15 10:43:08 -07:00
kexec_core.c	kernel misc: Remove the now superfluous sentinel elements from ctl_table array	2024-04-24 09:43:53 +02:00
kexec_elf.c
kexec_file.c	crash: add a new kexec flag for hotplug support	2024-04-23 14:59:01 +10:00
kexec_internal.h	crash: remove dependency of FA_DUMP on CRASH_DUMP	2024-02-23 17:48:22 -08:00
kexec.c	crash: add a new kexec flag for hotplug support	2024-04-23 14:59:01 +10:00
kheaders.c
kprobes.c	kprobe/ftrace: fix build error due to bad function definition	2024-05-17 19:17:55 -07:00
ksyms_common.c	kallsyms: make kallsyms_show_value() as generic function	2023-06-08 12:27:20 -07:00
ksysfs.c	vmlinux: Avoid weak reference to notes section	2024-05-02 19:48:26 +09:00
kthread.c	kunit: Handle test faults	2024-05-06 14:22:02 -06:00
latencytop.c	kernel misc: Remove the now superfluous sentinel elements from ctl_table array	2024-04-24 09:43:53 +02:00
Makefile	crash: split crash dumping code out from kexec_core.c	2024-02-23 17:48:22 -08:00
module_signature.c
notifier.c
nsproxy.c	pidfd: add pidfs	2024-03-01 12:23:37 +01:00
numa.c	kernel/numa.c: Move logging out of numa.h	2023-12-20 19:26:30 -05:00
padata.c	padata: Disable BH when taking works lock on MT path	2024-04-12 15:07:51 +08:00
panic.c	kernel misc: Remove the now superfluous sentinel elements from ctl_table array	2024-04-24 09:43:53 +02:00
params.c	params: Fix multi-line comment style	2023-12-01 09:51:44 -08:00
pid_namespace.c	zap_pid_ns_processes: clear TIF_NOTIFY_SIGNAL along with TIF_SIGPENDING	2024-06-15 10:43:06 -07:00
pid_sysctl.h	kernel misc: Remove the now superfluous sentinel elements from ctl_table array	2024-04-24 09:43:53 +02:00
pid.c	pidfs: remove config option	2024-03-13 12:53:53 -07:00
profile.c	profiling: Remove create_prof_cpu_mask().	2024-04-27 11:17:48 -07:00
ptrace.c	ptrace_attach: shift send(SIGSTOP) into ptrace_set_stopped()	2024-02-22 15:38:52 -08:00
range.c
reboot.c	kernel misc: Remove the now superfluous sentinel elements from ctl_table array	2024-04-24 09:43:53 +02:00
regset.c	regset: use kvzalloc() for regset_get_alloc()	2024-04-25 21:07:03 -07:00
relay.c	kernel: relay: remove relay_file_splice_read dead code, doesn't work	2023-12-29 12:22:27 -08:00
resource_kunit.c
resource.c	Quite a lot of kexec work this time around. Many singleton patches in	2024-01-09 11:46:20 -08:00
rseq.c
scftorture.c	scftorture: Pause testing after memory-allocation failure	2023-07-14 15:02:57 -07:00
scs.c
seccomp.c	sysctl changes for v6.10-rc1	2024-05-17 17:31:24 -07:00
signal.c	virtio: features, fixes, cleanups	2024-05-23 12:04:36 -07:00
smp.c	CSD lock commits for v6.7	2023-10-30 17:56:53 -10:00
smpboot.c	kthread: add kthread_stop_put	2023-10-04 10:41:57 -07:00
smpboot.h
softirq.c	softirq: Fix suspicious RCU usage in __do_softirq()	2024-04-29 05:03:51 +02:00
stackleak.c	sysctl changes for v6.10-rc1	2024-05-17 17:31:24 -07:00
stacktrace.c	stacktrace: fix kernel-doc typo	2023-12-29 12:22:29 -08:00
static_call_inline.c
static_call.c
stop_machine.c
sys_ni.c	syscalls: fix compat_sys_io_pgetevents_time64 usage	2024-06-25 15:57:20 +02:00
sys.c	RISC-V Patches for the 6.10 Merge Window, Part 1	2024-05-22 09:56:00 -07:00
sysctl-test.c
sysctl.c	kernel misc: Remove the now superfluous sentinel elements from ctl_table array	2024-04-24 09:43:53 +02:00
task_work.c	task_work: add kerneldoc annotation for 'data' argument	2023-09-19 13:21:32 -07:00
taskstats.c	taskstats: fill_stats_for_tgid: use for_each_thread()	2023-10-04 10:41:57 -07:00
torture.c	torture: Print out torture module parameters	2023-09-24 17:24:01 +02:00
tracepoint.c
tsacct.c
ucount.c	sysctl changes for v6.10-rc1	2024-05-17 17:31:24 -07:00
uid16.c
uid16.h
umh.c	umh: Remove the now superfluous sentinel elements from ctl_table array	2024-04-24 09:43:53 +02:00
up.c	smp: Change function signatures to use call_single_data_t	2023-09-13 14:59:24 +02:00
user_namespace.c	user_namespace: remove unnecessary NULL values from kbuf	2024-02-22 15:38:52 -08:00
user-return-notifier.c
user.c	printk: Change type of CONFIG_BASE_SMALL to bool	2024-05-06 17:39:09 +02:00
usermode_driver.c
utsname_sysctl.c	kernel misc: Remove the now superfluous sentinel elements from ctl_table array	2024-04-24 09:43:53 +02:00
utsname.c
vhost_task.c	vhost_task: Handle SIGKILL by flushing work and exiting	2024-05-22 08:31:15 -04:00
vmcore_info.c	mm: free up PG_slab	2024-04-25 20:56:00 -07:00
watch_queue.c	watch_queue: fix kcalloc() arguments order	2023-12-21 13:17:54 +01:00
watchdog_buddy.c	watchdog/hardlockup: move SMP barriers from common code to buddy code	2023-06-19 16:25:28 -07:00
watchdog_perf.c	kernel/watchdog_perf.c: tidy up kerneldoc	2024-05-08 08:41:29 -07:00
watchdog.c	Mainly singleton patches, documented in their respective changelogs.	2024-05-19 14:02:03 -07:00
workqueue_internal.h	workqueue: Drop the special locking rule for worker->flags and worker_pool->flags	2023-08-07 15:57:22 -10:00
workqueue.c	workqueue: Refactor worker ID formatting and make wq_worker_comm() use full ID string	2024-05-20 13:28:40 -10:00