David Safford dda5384313 KEYS: trusted: tpm2: Fix migratable logic ... When creating (sealing) a new trusted key, migratable trusted keys have the FIXED_TPM and FIXED_PARENT attributes set, and non-migratable keys don't. This is backwards, and also causes creation to fail when creating a migratable key under a migratable parent. (The TPM thinks you are trying to seal a non-migratable blob under a migratable parent.) The following simple patch fixes the logic, and has been tested for all four combinations of migratable and non-migratable trusted keys and parent storage keys. With this logic, you will get a proper failure if you try to create a non-migratable trusted key under a migratable parent storage key, and all other combinations work correctly. Cc: stable@vger.kernel.org # v5.13+ Fixes: e5fb5d2c5a ("security: keys: trusted: Make sealed key properly interoperable") Signed-off-by: David Safford <david.safford@gmail.com> Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de> Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org> Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>		2022-06-08 14:12:13 +03:00
..
encrypted-keys	KEYS: encrypted: Instantiate key with user-provided decrypted data	2022-02-21 19:47:45 -05:00
trusted-keys	KEYS: trusted: tpm2: Fix migratable logic	2022-06-08 14:12:13 +03:00
big_key.c	big_keys: Use struct for internal payload	2022-05-16 16:02:21 -07:00
compat_dh.c
compat.c	security/keys: remove compat_keyctl_instantiate_key_iov	2020-10-03 00:02:16 -04:00
dh.c	crypto: dh - constify struct dh's pointer members	2022-03-03 10:47:50 +12:00
gc.c	watch_queue: Add a key/keyring notification facility	2020-05-19 15:19:06 +01:00
internal.h	security/keys: remove compat_keyctl_instantiate_key_iov	2020-10-03 00:02:16 -04:00
Kconfig	KEYS: trusted: allow use of TEE as backend without TCG_TPM support	2022-05-23 18:47:50 +03:00
key.c	certs: Fix blacklist flag type confusion	2021-01-21 16:16:10 +00:00
keyctl_pkey.c	KEYS: fix length validation in keyctl_pkey_params_get_2()	2022-03-08 10:33:18 +02:00
keyctl.c	security: keys: delete repeated words in comments	2021-01-21 16:16:09 +00:00
keyring.c	security: keys: delete repeated words in comments	2021-01-21 16:16:09 +00:00
Makefile	KEYS: remove CONFIG_KEYS_COMPAT	2019-12-12 23:41:17 +02:00
permission.c	keys: Make the KEY_NEED_* perms an enum rather than a mask	2020-05-19 15:42:22 +01:00
persistent.c
proc.c	keys: Fix proc_keys_next to increase position index	2020-04-16 10:10:50 -07:00
process_keys.c	ucounts: Move get_ucounts from cred_alloc_blank to key_change_session_keyring	2021-10-20 10:34:20 -05:00
request_key_auth.c	KEYS: Don't write out to userspace while holding key semaphore	2020-03-29 12:40:41 +01:00
request_key.c	treewide: Use fallthrough pseudo-keyword	2020-08-23 17:36:59 -05:00
sysctl.c	proc/sysctl: add shared variables for range check	2019-07-18 17:08:07 -07:00
user_defined.c	mm, treewide: rename kzfree() to kfree_sensitive()	2020-08-07 11:33:22 -07:00