mirror of
https://github.com/torvalds/linux.git
synced 2024-11-07 20:51:47 +00:00
2f84b42b28
When profiling the kernel with the 'srcfile' sort key it's common to "get stuck" in include. For example a lot of code uses current or other inlines, so they get accounted to some random include file. This is not very useful as a high level categorization. For example just profiling the idle loop usually shows mostly inlines, so you never see the actual cpuidle file. This patch changes the 'srcfile' sort key to always unwind the inline stack using BFD/DWARF. So we always account to the base function that called the inline. In a few cases include is still shown (for example for MSR accesses), but that is because they get inlining expanded as part of assigning to a global function pointer. For the majority it works fine though. v2: Use simpler while loop. Add maximum iteration count. Signed-off-by: Andi Kleen <ak@linux.intel.com> Cc: Jiri Olsa <jolsa@kernel.org> Link: http://lkml.kernel.org/r/1441133239-31254-1-git-send-email-andi@firstfloor.org Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
332 lines
5.9 KiB
C
332 lines
5.9 KiB
C
#include <stdio.h>
|
|
#include <stdlib.h>
|
|
#include <string.h>
|
|
|
|
#include <linux/kernel.h>
|
|
|
|
#include "util/dso.h"
|
|
#include "util/util.h"
|
|
#include "util/debug.h"
|
|
|
|
#include "symbol.h"
|
|
|
|
bool srcline_full_filename;
|
|
|
|
#ifdef HAVE_LIBBFD_SUPPORT
|
|
|
|
/*
|
|
* Implement addr2line using libbfd.
|
|
*/
|
|
#define PACKAGE "perf"
|
|
#include <bfd.h>
|
|
|
|
struct a2l_data {
|
|
const char *input;
|
|
u64 addr;
|
|
|
|
bool found;
|
|
const char *filename;
|
|
const char *funcname;
|
|
unsigned line;
|
|
|
|
bfd *abfd;
|
|
asymbol **syms;
|
|
};
|
|
|
|
static int bfd_error(const char *string)
|
|
{
|
|
const char *errmsg;
|
|
|
|
errmsg = bfd_errmsg(bfd_get_error());
|
|
fflush(stdout);
|
|
|
|
if (string)
|
|
pr_debug("%s: %s\n", string, errmsg);
|
|
else
|
|
pr_debug("%s\n", errmsg);
|
|
|
|
return -1;
|
|
}
|
|
|
|
static int slurp_symtab(bfd *abfd, struct a2l_data *a2l)
|
|
{
|
|
long storage;
|
|
long symcount;
|
|
asymbol **syms;
|
|
bfd_boolean dynamic = FALSE;
|
|
|
|
if ((bfd_get_file_flags(abfd) & HAS_SYMS) == 0)
|
|
return bfd_error(bfd_get_filename(abfd));
|
|
|
|
storage = bfd_get_symtab_upper_bound(abfd);
|
|
if (storage == 0L) {
|
|
storage = bfd_get_dynamic_symtab_upper_bound(abfd);
|
|
dynamic = TRUE;
|
|
}
|
|
if (storage < 0L)
|
|
return bfd_error(bfd_get_filename(abfd));
|
|
|
|
syms = malloc(storage);
|
|
if (dynamic)
|
|
symcount = bfd_canonicalize_dynamic_symtab(abfd, syms);
|
|
else
|
|
symcount = bfd_canonicalize_symtab(abfd, syms);
|
|
|
|
if (symcount < 0) {
|
|
free(syms);
|
|
return bfd_error(bfd_get_filename(abfd));
|
|
}
|
|
|
|
a2l->syms = syms;
|
|
return 0;
|
|
}
|
|
|
|
static void find_address_in_section(bfd *abfd, asection *section, void *data)
|
|
{
|
|
bfd_vma pc, vma;
|
|
bfd_size_type size;
|
|
struct a2l_data *a2l = data;
|
|
|
|
if (a2l->found)
|
|
return;
|
|
|
|
if ((bfd_get_section_flags(abfd, section) & SEC_ALLOC) == 0)
|
|
return;
|
|
|
|
pc = a2l->addr;
|
|
vma = bfd_get_section_vma(abfd, section);
|
|
size = bfd_get_section_size(section);
|
|
|
|
if (pc < vma || pc >= vma + size)
|
|
return;
|
|
|
|
a2l->found = bfd_find_nearest_line(abfd, section, a2l->syms, pc - vma,
|
|
&a2l->filename, &a2l->funcname,
|
|
&a2l->line);
|
|
}
|
|
|
|
static struct a2l_data *addr2line_init(const char *path)
|
|
{
|
|
bfd *abfd;
|
|
struct a2l_data *a2l = NULL;
|
|
|
|
abfd = bfd_openr(path, NULL);
|
|
if (abfd == NULL)
|
|
return NULL;
|
|
|
|
if (!bfd_check_format(abfd, bfd_object))
|
|
goto out;
|
|
|
|
a2l = zalloc(sizeof(*a2l));
|
|
if (a2l == NULL)
|
|
goto out;
|
|
|
|
a2l->abfd = abfd;
|
|
a2l->input = strdup(path);
|
|
if (a2l->input == NULL)
|
|
goto out;
|
|
|
|
if (slurp_symtab(abfd, a2l))
|
|
goto out;
|
|
|
|
return a2l;
|
|
|
|
out:
|
|
if (a2l) {
|
|
zfree((char **)&a2l->input);
|
|
free(a2l);
|
|
}
|
|
bfd_close(abfd);
|
|
return NULL;
|
|
}
|
|
|
|
static void addr2line_cleanup(struct a2l_data *a2l)
|
|
{
|
|
if (a2l->abfd)
|
|
bfd_close(a2l->abfd);
|
|
zfree((char **)&a2l->input);
|
|
zfree(&a2l->syms);
|
|
free(a2l);
|
|
}
|
|
|
|
#define MAX_INLINE_NEST 1024
|
|
|
|
static int addr2line(const char *dso_name, u64 addr,
|
|
char **file, unsigned int *line, struct dso *dso,
|
|
bool unwind_inlines)
|
|
{
|
|
int ret = 0;
|
|
struct a2l_data *a2l = dso->a2l;
|
|
|
|
if (!a2l) {
|
|
dso->a2l = addr2line_init(dso_name);
|
|
a2l = dso->a2l;
|
|
}
|
|
|
|
if (a2l == NULL) {
|
|
pr_warning("addr2line_init failed for %s\n", dso_name);
|
|
return 0;
|
|
}
|
|
|
|
a2l->addr = addr;
|
|
a2l->found = false;
|
|
|
|
bfd_map_over_sections(a2l->abfd, find_address_in_section, a2l);
|
|
|
|
if (a2l->found && unwind_inlines) {
|
|
int cnt = 0;
|
|
|
|
while (bfd_find_inliner_info(a2l->abfd, &a2l->filename,
|
|
&a2l->funcname, &a2l->line) &&
|
|
cnt++ < MAX_INLINE_NEST)
|
|
;
|
|
}
|
|
|
|
if (a2l->found && a2l->filename) {
|
|
*file = strdup(a2l->filename);
|
|
*line = a2l->line;
|
|
|
|
if (*file)
|
|
ret = 1;
|
|
}
|
|
|
|
return ret;
|
|
}
|
|
|
|
void dso__free_a2l(struct dso *dso)
|
|
{
|
|
struct a2l_data *a2l = dso->a2l;
|
|
|
|
if (!a2l)
|
|
return;
|
|
|
|
addr2line_cleanup(a2l);
|
|
|
|
dso->a2l = NULL;
|
|
}
|
|
|
|
#else /* HAVE_LIBBFD_SUPPORT */
|
|
|
|
static int addr2line(const char *dso_name, u64 addr,
|
|
char **file, unsigned int *line_nr,
|
|
struct dso *dso __maybe_unused,
|
|
bool unwind_inlines __maybe_unused)
|
|
{
|
|
FILE *fp;
|
|
char cmd[PATH_MAX];
|
|
char *filename = NULL;
|
|
size_t len;
|
|
char *sep;
|
|
int ret = 0;
|
|
|
|
scnprintf(cmd, sizeof(cmd), "addr2line -e %s %016"PRIx64,
|
|
dso_name, addr);
|
|
|
|
fp = popen(cmd, "r");
|
|
if (fp == NULL) {
|
|
pr_warning("popen failed for %s\n", dso_name);
|
|
return 0;
|
|
}
|
|
|
|
if (getline(&filename, &len, fp) < 0 || !len) {
|
|
pr_warning("addr2line has no output for %s\n", dso_name);
|
|
goto out;
|
|
}
|
|
|
|
sep = strchr(filename, '\n');
|
|
if (sep)
|
|
*sep = '\0';
|
|
|
|
if (!strcmp(filename, "??:0")) {
|
|
pr_debug("no debugging info in %s\n", dso_name);
|
|
free(filename);
|
|
goto out;
|
|
}
|
|
|
|
sep = strchr(filename, ':');
|
|
if (sep) {
|
|
*sep++ = '\0';
|
|
*file = filename;
|
|
*line_nr = strtoul(sep, NULL, 0);
|
|
ret = 1;
|
|
}
|
|
out:
|
|
pclose(fp);
|
|
return ret;
|
|
}
|
|
|
|
void dso__free_a2l(struct dso *dso __maybe_unused)
|
|
{
|
|
}
|
|
|
|
#endif /* HAVE_LIBBFD_SUPPORT */
|
|
|
|
/*
|
|
* Number of addr2line failures (without success) before disabling it for that
|
|
* dso.
|
|
*/
|
|
#define A2L_FAIL_LIMIT 123
|
|
|
|
char *__get_srcline(struct dso *dso, u64 addr, struct symbol *sym,
|
|
bool show_sym, bool unwind_inlines)
|
|
{
|
|
char *file = NULL;
|
|
unsigned line = 0;
|
|
char *srcline;
|
|
const char *dso_name;
|
|
|
|
if (!dso->has_srcline)
|
|
goto out;
|
|
|
|
if (dso->symsrc_filename)
|
|
dso_name = dso->symsrc_filename;
|
|
else
|
|
dso_name = dso->long_name;
|
|
|
|
if (dso_name[0] == '[')
|
|
goto out;
|
|
|
|
if (!strncmp(dso_name, "/tmp/perf-", 10))
|
|
goto out;
|
|
|
|
if (!addr2line(dso_name, addr, &file, &line, dso, unwind_inlines))
|
|
goto out;
|
|
|
|
if (asprintf(&srcline, "%s:%u",
|
|
srcline_full_filename ? file : basename(file),
|
|
line) < 0) {
|
|
free(file);
|
|
goto out;
|
|
}
|
|
|
|
dso->a2l_fails = 0;
|
|
|
|
free(file);
|
|
return srcline;
|
|
|
|
out:
|
|
if (dso->a2l_fails && ++dso->a2l_fails > A2L_FAIL_LIMIT) {
|
|
dso->has_srcline = 0;
|
|
dso__free_a2l(dso);
|
|
}
|
|
if (sym) {
|
|
if (asprintf(&srcline, "%s+%" PRIu64, show_sym ? sym->name : "",
|
|
addr - sym->start) < 0)
|
|
return SRCLINE_UNKNOWN;
|
|
} else if (asprintf(&srcline, "%s[%" PRIx64 "]", dso->short_name, addr) < 0)
|
|
return SRCLINE_UNKNOWN;
|
|
return srcline;
|
|
}
|
|
|
|
void free_srcline(char *srcline)
|
|
{
|
|
if (srcline && strcmp(srcline, SRCLINE_UNKNOWN) != 0)
|
|
free(srcline);
|
|
}
|
|
|
|
char *get_srcline(struct dso *dso, u64 addr, struct symbol *sym,
|
|
bool show_sym)
|
|
{
|
|
return __get_srcline(dso, addr, sym, show_sym, false);
|
|
}
|