Guillaume Nault dbdbc73b44 l2tp: fix duplicate session creation ... l2tp_session_create() relies on its caller for checking for duplicate sessions. This is racy since a session can be concurrently inserted after the caller's verification. Fix this by letting l2tp_session_create() verify sessions uniqueness upon insertion. Callers need to be adapted to check for l2tp_session_create()'s return code instead of calling l2tp_session_find(). pppol2tp_connect() is a bit special because it has to work on existing sessions (if they're not connected) or to create a new session if none is found. When acting on a preexisting session, a reference must be held or it could go away on us. So we have to use l2tp_session_get() instead of l2tp_session_find() and drop the reference before exiting. Fixes: d9e31d17ce ("l2tp: Add L2TP ethernet pseudowire support") Fixes: fd558d186d ("l2tp: Split pppol2tp patch into separate l2tp and ppp parts") Signed-off-by: Guillaume Nault <g.nault@alphalink.fr> Signed-off-by: David S. Miller <davem@davemloft.net>		2017-04-01 20:16:41 -07:00
..
Kconfig	l2tp: Call udp_sock_create	2014-07-14 16:12:15 -07:00
l2tp_core.c	l2tp: fix duplicate session creation	2017-04-01 20:16:41 -07:00
l2tp_core.h	l2tp: fix race in l2tp_recv_common()	2017-04-01 20:16:41 -07:00
l2tp_debugfs.c	ipv6: make lookups simpler and faster	2013-10-09 00:01:25 -04:00
l2tp_eth.c	l2tp: fix duplicate session creation	2017-04-01 20:16:41 -07:00
l2tp_ip6.c	l2tp: fix race in l2tp_recv_common()	2017-04-01 20:16:41 -07:00
l2tp_ip.c	l2tp: fix race in l2tp_recv_common()	2017-04-01 20:16:41 -07:00
l2tp_netlink.c	net: l2tp: cleanup: remove redundant condition	2016-11-09 18:55:36 -05:00
l2tp_ppp.c	l2tp: fix duplicate session creation	2017-04-01 20:16:41 -07:00
Makefile	l2tp: introduce L2TPv3 IP encapsulation support for IPv6	2012-05-01 09:30:55 -04:00