mirror of
https://github.com/torvalds/linux.git
synced 2024-11-27 22:51:35 +00:00
d92725256b
I observed that for each of the shared file-backed page faults, we're very likely to retry one more time for the 1st write fault upon no page. It's because we'll need to release the mmap lock for dirty rate limit purpose with balance_dirty_pages_ratelimited() (in fault_dirty_shared_page()). Then after that throttling we return VM_FAULT_RETRY. We did that probably because VM_FAULT_RETRY is the only way we can return to the fault handler at that time telling it we've released the mmap lock. However that's not ideal because it's very likely the fault does not need to be retried at all since the pgtable was well installed before the throttling, so the next continuous fault (including taking mmap read lock, walk the pgtable, etc.) could be in most cases unnecessary. It's not only slowing down page faults for shared file-backed, but also add more mmap lock contention which is in most cases not needed at all. To observe this, one could try to write to some shmem page and look at "pgfault" value in /proc/vmstat, then we should expect 2 counts for each shmem write simply because we retried, and vm event "pgfault" will capture that. To make it more efficient, add a new VM_FAULT_COMPLETED return code just to show that we've completed the whole fault and released the lock. It's also a hint that we should very possibly not need another fault immediately on this page because we've just completed it. This patch provides a ~12% perf boost on my aarch64 test VM with a simple program sequentially dirtying 400MB shmem file being mmap()ed and these are the time it needs: Before: 650.980 ms (+-1.94%) After: 569.396 ms (+-1.38%) I believe it could help more than that. We need some special care on GUP and the s390 pgfault handler (for gmap code before returning from pgfault), the rest changes in the page fault handlers should be relatively straightforward. Another thing to mention is that mm_account_fault() does take this new fault as a generic fault to be accounted, unlike VM_FAULT_RETRY. I explicitly didn't touch hmm_vma_fault() and break_ksm() because they do not handle VM_FAULT_RETRY even with existing code, so I'm literally keeping them as-is. Link: https://lkml.kernel.org/r/20220530183450.42886-1-peterx@redhat.com Signed-off-by: Peter Xu <peterx@redhat.com> Acked-by: Geert Uytterhoeven <geert@linux-m68k.org> Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org> Acked-by: Johannes Weiner <hannes@cmpxchg.org> Acked-by: Vineet Gupta <vgupta@kernel.org> Acked-by: Guo Ren <guoren@kernel.org> Acked-by: Max Filippov <jcmvbkbc@gmail.com> Acked-by: Christian Borntraeger <borntraeger@linux.ibm.com> Acked-by: Michael Ellerman <mpe@ellerman.id.au> (powerpc) Acked-by: Catalin Marinas <catalin.marinas@arm.com> Reviewed-by: Alistair Popple <apopple@nvidia.com> Reviewed-by: Ingo Molnar <mingo@kernel.org> Acked-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> [arm part] Acked-by: Heiko Carstens <hca@linux.ibm.com> Cc: Vasily Gorbik <gor@linux.ibm.com> Cc: Stafford Horne <shorne@gmail.com> Cc: David S. Miller <davem@davemloft.net> Cc: Johannes Berg <johannes@sipsolutions.net> Cc: Brian Cain <bcain@quicinc.com> Cc: Richard Henderson <rth@twiddle.net> Cc: Richard Weinberger <richard@nod.at> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Janosch Frank <frankja@linux.ibm.com> Cc: Albert Ou <aou@eecs.berkeley.edu> Cc: Anton Ivanov <anton.ivanov@cambridgegreys.com> Cc: Dave Hansen <dave.hansen@linux.intel.com> Cc: Borislav Petkov <bp@alien8.de> Cc: Sven Schnelle <svens@linux.ibm.com> Cc: Andrea Arcangeli <aarcange@redhat.com> Cc: James Bottomley <James.Bottomley@HansenPartnership.com> Cc: Al Viro <viro@zeniv.linux.org.uk> Cc: Alexander Gordeev <agordeev@linux.ibm.com> Cc: Jonas Bonn <jonas@southpole.se> Cc: Will Deacon <will@kernel.org> Cc: Vlastimil Babka <vbabka@suse.cz> Cc: Michal Simek <monstr@monstr.eu> Cc: Matt Turner <mattst88@gmail.com> Cc: Paul Mackerras <paulus@samba.org> Cc: David Hildenbrand <david@redhat.com> Cc: Nicholas Piggin <npiggin@gmail.com> Cc: Palmer Dabbelt <palmer@dabbelt.com> Cc: Stefan Kristiansson <stefan.kristiansson@saunalahti.fi> Cc: Paul Walmsley <paul.walmsley@sifive.com> Cc: Ivan Kokshaysky <ink@jurassic.park.msu.ru> Cc: Chris Zankel <chris@zankel.net> Cc: Hugh Dickins <hughd@google.com> Cc: Dinh Nguyen <dinguyen@kernel.org> Cc: Rich Felker <dalias@libc.org> Cc: H. Peter Anvin <hpa@zytor.com> Cc: Andy Lutomirski <luto@kernel.org> Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de> Cc: Helge Deller <deller@gmx.de> Cc: Yoshinori Sato <ysato@users.osdn.me> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
354 lines
8.2 KiB
C
354 lines
8.2 KiB
C
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
/*
|
|
* Copyright (C) 2009 Sunplus Core Technology Co., Ltd.
|
|
* Lennox Wu <lennox.wu@sunplusct.com>
|
|
* Chen Liqin <liqin.chen@sunplusct.com>
|
|
* Copyright (C) 2012 Regents of the University of California
|
|
*/
|
|
|
|
|
|
#include <linux/mm.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/interrupt.h>
|
|
#include <linux/perf_event.h>
|
|
#include <linux/signal.h>
|
|
#include <linux/uaccess.h>
|
|
#include <linux/kprobes.h>
|
|
#include <linux/kfence.h>
|
|
|
|
#include <asm/ptrace.h>
|
|
#include <asm/tlbflush.h>
|
|
|
|
#include "../kernel/head.h"
|
|
|
|
static void die_kernel_fault(const char *msg, unsigned long addr,
|
|
struct pt_regs *regs)
|
|
{
|
|
bust_spinlocks(1);
|
|
|
|
pr_alert("Unable to handle kernel %s at virtual address " REG_FMT "\n", msg,
|
|
addr);
|
|
|
|
bust_spinlocks(0);
|
|
die(regs, "Oops");
|
|
make_task_dead(SIGKILL);
|
|
}
|
|
|
|
static inline void no_context(struct pt_regs *regs, unsigned long addr)
|
|
{
|
|
const char *msg;
|
|
|
|
/* Are we prepared to handle this kernel fault? */
|
|
if (fixup_exception(regs))
|
|
return;
|
|
|
|
/*
|
|
* Oops. The kernel tried to access some bad page. We'll have to
|
|
* terminate things with extreme prejudice.
|
|
*/
|
|
if (addr < PAGE_SIZE)
|
|
msg = "NULL pointer dereference";
|
|
else {
|
|
if (kfence_handle_page_fault(addr, regs->cause == EXC_STORE_PAGE_FAULT, regs))
|
|
return;
|
|
|
|
msg = "paging request";
|
|
}
|
|
|
|
die_kernel_fault(msg, addr, regs);
|
|
}
|
|
|
|
static inline void mm_fault_error(struct pt_regs *regs, unsigned long addr, vm_fault_t fault)
|
|
{
|
|
if (fault & VM_FAULT_OOM) {
|
|
/*
|
|
* We ran out of memory, call the OOM killer, and return the userspace
|
|
* (which will retry the fault, or kill us if we got oom-killed).
|
|
*/
|
|
if (!user_mode(regs)) {
|
|
no_context(regs, addr);
|
|
return;
|
|
}
|
|
pagefault_out_of_memory();
|
|
return;
|
|
} else if (fault & VM_FAULT_SIGBUS) {
|
|
/* Kernel mode? Handle exceptions or die */
|
|
if (!user_mode(regs)) {
|
|
no_context(regs, addr);
|
|
return;
|
|
}
|
|
do_trap(regs, SIGBUS, BUS_ADRERR, addr);
|
|
return;
|
|
}
|
|
BUG();
|
|
}
|
|
|
|
static inline void bad_area(struct pt_regs *regs, struct mm_struct *mm, int code, unsigned long addr)
|
|
{
|
|
/*
|
|
* Something tried to access memory that isn't in our memory map.
|
|
* Fix it, but check if it's kernel or user first.
|
|
*/
|
|
mmap_read_unlock(mm);
|
|
/* User mode accesses just cause a SIGSEGV */
|
|
if (user_mode(regs)) {
|
|
do_trap(regs, SIGSEGV, code, addr);
|
|
return;
|
|
}
|
|
|
|
no_context(regs, addr);
|
|
}
|
|
|
|
static inline void vmalloc_fault(struct pt_regs *regs, int code, unsigned long addr)
|
|
{
|
|
pgd_t *pgd, *pgd_k;
|
|
pud_t *pud_k;
|
|
p4d_t *p4d_k;
|
|
pmd_t *pmd_k;
|
|
pte_t *pte_k;
|
|
int index;
|
|
unsigned long pfn;
|
|
|
|
/* User mode accesses just cause a SIGSEGV */
|
|
if (user_mode(regs))
|
|
return do_trap(regs, SIGSEGV, code, addr);
|
|
|
|
/*
|
|
* Synchronize this task's top level page-table
|
|
* with the 'reference' page table.
|
|
*
|
|
* Do _not_ use "tsk->active_mm->pgd" here.
|
|
* We might be inside an interrupt in the middle
|
|
* of a task switch.
|
|
*/
|
|
index = pgd_index(addr);
|
|
pfn = csr_read(CSR_SATP) & SATP_PPN;
|
|
pgd = (pgd_t *)pfn_to_virt(pfn) + index;
|
|
pgd_k = init_mm.pgd + index;
|
|
|
|
if (!pgd_present(*pgd_k)) {
|
|
no_context(regs, addr);
|
|
return;
|
|
}
|
|
set_pgd(pgd, *pgd_k);
|
|
|
|
p4d_k = p4d_offset(pgd_k, addr);
|
|
if (!p4d_present(*p4d_k)) {
|
|
no_context(regs, addr);
|
|
return;
|
|
}
|
|
|
|
pud_k = pud_offset(p4d_k, addr);
|
|
if (!pud_present(*pud_k)) {
|
|
no_context(regs, addr);
|
|
return;
|
|
}
|
|
|
|
/*
|
|
* Since the vmalloc area is global, it is unnecessary
|
|
* to copy individual PTEs
|
|
*/
|
|
pmd_k = pmd_offset(pud_k, addr);
|
|
if (!pmd_present(*pmd_k)) {
|
|
no_context(regs, addr);
|
|
return;
|
|
}
|
|
|
|
/*
|
|
* Make sure the actual PTE exists as well to
|
|
* catch kernel vmalloc-area accesses to non-mapped
|
|
* addresses. If we don't do this, this will just
|
|
* silently loop forever.
|
|
*/
|
|
pte_k = pte_offset_kernel(pmd_k, addr);
|
|
if (!pte_present(*pte_k)) {
|
|
no_context(regs, addr);
|
|
return;
|
|
}
|
|
|
|
/*
|
|
* The kernel assumes that TLBs don't cache invalid
|
|
* entries, but in RISC-V, SFENCE.VMA specifies an
|
|
* ordering constraint, not a cache flush; it is
|
|
* necessary even after writing invalid entries.
|
|
*/
|
|
local_flush_tlb_page(addr);
|
|
}
|
|
|
|
static inline bool access_error(unsigned long cause, struct vm_area_struct *vma)
|
|
{
|
|
switch (cause) {
|
|
case EXC_INST_PAGE_FAULT:
|
|
if (!(vma->vm_flags & VM_EXEC)) {
|
|
return true;
|
|
}
|
|
break;
|
|
case EXC_LOAD_PAGE_FAULT:
|
|
if (!(vma->vm_flags & VM_READ)) {
|
|
return true;
|
|
}
|
|
break;
|
|
case EXC_STORE_PAGE_FAULT:
|
|
if (!(vma->vm_flags & VM_WRITE)) {
|
|
return true;
|
|
}
|
|
break;
|
|
default:
|
|
panic("%s: unhandled cause %lu", __func__, cause);
|
|
}
|
|
return false;
|
|
}
|
|
|
|
/*
|
|
* This routine handles page faults. It determines the address and the
|
|
* problem, and then passes it off to one of the appropriate routines.
|
|
*/
|
|
asmlinkage void do_page_fault(struct pt_regs *regs)
|
|
{
|
|
struct task_struct *tsk;
|
|
struct vm_area_struct *vma;
|
|
struct mm_struct *mm;
|
|
unsigned long addr, cause;
|
|
unsigned int flags = FAULT_FLAG_DEFAULT;
|
|
int code = SEGV_MAPERR;
|
|
vm_fault_t fault;
|
|
|
|
cause = regs->cause;
|
|
addr = regs->badaddr;
|
|
|
|
tsk = current;
|
|
mm = tsk->mm;
|
|
|
|
if (kprobe_page_fault(regs, cause))
|
|
return;
|
|
|
|
/*
|
|
* Fault-in kernel-space virtual memory on-demand.
|
|
* The 'reference' page table is init_mm.pgd.
|
|
*
|
|
* NOTE! We MUST NOT take any locks for this case. We may
|
|
* be in an interrupt or a critical region, and should
|
|
* only copy the information from the master page table,
|
|
* nothing more.
|
|
*/
|
|
if (unlikely((addr >= VMALLOC_START) && (addr < VMALLOC_END))) {
|
|
vmalloc_fault(regs, code, addr);
|
|
return;
|
|
}
|
|
|
|
#ifdef CONFIG_64BIT
|
|
/*
|
|
* Modules in 64bit kernels lie in their own virtual region which is not
|
|
* in the vmalloc region, but dealing with page faults in this region
|
|
* or the vmalloc region amounts to doing the same thing: checking that
|
|
* the mapping exists in init_mm.pgd and updating user page table, so
|
|
* just use vmalloc_fault.
|
|
*/
|
|
if (unlikely(addr >= MODULES_VADDR && addr < MODULES_END)) {
|
|
vmalloc_fault(regs, code, addr);
|
|
return;
|
|
}
|
|
#endif
|
|
/* Enable interrupts if they were enabled in the parent context. */
|
|
if (likely(regs->status & SR_PIE))
|
|
local_irq_enable();
|
|
|
|
/*
|
|
* If we're in an interrupt, have no user context, or are running
|
|
* in an atomic region, then we must not take the fault.
|
|
*/
|
|
if (unlikely(faulthandler_disabled() || !mm)) {
|
|
tsk->thread.bad_cause = cause;
|
|
no_context(regs, addr);
|
|
return;
|
|
}
|
|
|
|
if (user_mode(regs))
|
|
flags |= FAULT_FLAG_USER;
|
|
|
|
if (!user_mode(regs) && addr < TASK_SIZE &&
|
|
unlikely(!(regs->status & SR_SUM)))
|
|
die_kernel_fault("access to user memory without uaccess routines",
|
|
addr, regs);
|
|
|
|
perf_sw_event(PERF_COUNT_SW_PAGE_FAULTS, 1, regs, addr);
|
|
|
|
if (cause == EXC_STORE_PAGE_FAULT)
|
|
flags |= FAULT_FLAG_WRITE;
|
|
else if (cause == EXC_INST_PAGE_FAULT)
|
|
flags |= FAULT_FLAG_INSTRUCTION;
|
|
retry:
|
|
mmap_read_lock(mm);
|
|
vma = find_vma(mm, addr);
|
|
if (unlikely(!vma)) {
|
|
tsk->thread.bad_cause = cause;
|
|
bad_area(regs, mm, code, addr);
|
|
return;
|
|
}
|
|
if (likely(vma->vm_start <= addr))
|
|
goto good_area;
|
|
if (unlikely(!(vma->vm_flags & VM_GROWSDOWN))) {
|
|
tsk->thread.bad_cause = cause;
|
|
bad_area(regs, mm, code, addr);
|
|
return;
|
|
}
|
|
if (unlikely(expand_stack(vma, addr))) {
|
|
tsk->thread.bad_cause = cause;
|
|
bad_area(regs, mm, code, addr);
|
|
return;
|
|
}
|
|
|
|
/*
|
|
* Ok, we have a good vm_area for this memory access, so
|
|
* we can handle it.
|
|
*/
|
|
good_area:
|
|
code = SEGV_ACCERR;
|
|
|
|
if (unlikely(access_error(cause, vma))) {
|
|
tsk->thread.bad_cause = cause;
|
|
bad_area(regs, mm, code, addr);
|
|
return;
|
|
}
|
|
|
|
/*
|
|
* If for any reason at all we could not handle the fault,
|
|
* make sure we exit gracefully rather than endlessly redo
|
|
* the fault.
|
|
*/
|
|
fault = handle_mm_fault(vma, addr, flags, regs);
|
|
|
|
/*
|
|
* If we need to retry but a fatal signal is pending, handle the
|
|
* signal first. We do not need to release the mmap_lock because it
|
|
* would already be released in __lock_page_or_retry in mm/filemap.c.
|
|
*/
|
|
if (fault_signal_pending(fault, regs))
|
|
return;
|
|
|
|
/* The fault is fully completed (including releasing mmap lock) */
|
|
if (fault & VM_FAULT_COMPLETED)
|
|
return;
|
|
|
|
if (unlikely(fault & VM_FAULT_RETRY)) {
|
|
flags |= FAULT_FLAG_TRIED;
|
|
|
|
/*
|
|
* No need to mmap_read_unlock(mm) as we would
|
|
* have already released it in __lock_page_or_retry
|
|
* in mm/filemap.c.
|
|
*/
|
|
goto retry;
|
|
}
|
|
|
|
mmap_read_unlock(mm);
|
|
|
|
if (unlikely(fault & VM_FAULT_ERROR)) {
|
|
tsk->thread.bad_cause = cause;
|
|
mm_fault_error(regs, addr, fault);
|
|
return;
|
|
}
|
|
return;
|
|
}
|
|
NOKPROBE_SYMBOL(do_page_fault);
|