Gavin Shan d8cedaabe7 net/ncsi: Avoid unused-value build warning from ia64-linux-gcc ... xchg() is used to set NCSI channel's state in order for consistent access to the state. xchg()'s return value should be used. Otherwise, one build warning will be raised (with -Wunused-value) as below message indicates. It is reported by ia64-linux-gcc (GCC) 4.9.0. net/ncsi/ncsi-manage.c: In function 'ncsi_channel_monitor': arch/ia64/include/uapi/asm/cmpxchg.h:56:2: warning: value computed is \ not used [-Wunused-value] ((__typeof__(*(ptr))) __xchg((unsigned long) (x), (ptr), sizeof(*(ptr)))) ^ net/ncsi/ncsi-manage.c:202:3: note: in expansion of macro 'xchg' xchg(&nc->state, NCSI_CHANNEL_INACTIVE); This removes the atomic access to NCSI channel's state avoid the above build warning. We have to hold the channel's lock when its state is readed or updated. No functional changes introduced. Signed-off-by: Gavin Shan <gwshan@linux.vnet.ibm.com> Reviewed-by: Joel Stanley <joel@jms.id.au> Signed-off-by: David S. Miller <davem@davemloft.net>		2016-10-04 02:11:50 -04:00
..
internal.h	net/ncsi: NCSI AEN packet handler	2016-07-19 20:49:17 -07:00
Kconfig
Makefile	net/ncsi: NCSI AEN packet handler	2016-07-19 20:49:17 -07:00
ncsi-aen.c	net/ncsi: Avoid unused-value build warning from ia64-linux-gcc	2016-10-04 02:11:50 -04:00
ncsi-cmd.c	net/ncsi: NCSI command packet handler	2016-07-19 20:49:16 -07:00
ncsi-manage.c	net/ncsi: Avoid unused-value build warning from ia64-linux-gcc	2016-10-04 02:11:50 -04:00
ncsi-pkt.h	net/ncsi: NCSI AEN packet handler	2016-07-19 20:49:17 -07:00
ncsi-rsp.c	net/ncsi: NCSI AEN packet handler	2016-07-19 20:49:17 -07:00