Sebastian Reichel d54fb4b25a clk: composite: Fix handling of high clock rates ... ULONG_MAX is used by a few drivers to figure out the highest available clock rate via clk_round_rate(clk, ULONG_MAX). Since abs() takes a signed value as input, the current logic effectively calculates with ULONG_MAX = -1, which results in the worst parent clock being chosen instead of the best one. For example on Rockchip RK3588 the eMMC driver tries to figure out the highest available clock rate. There are three parent clocks available resulting in the following rate diffs with the existing logic: GPLL: abs(18446744073709551615 - 1188000000) = 1188000001 CPLL: abs(18446744073709551615 - 1500000000) = 1500000001 XIN24M: abs(18446744073709551615 - 24000000) = 24000001 As a result the clock framework will promote a maximum supported clock rate of 24 MHz, even though 1.5GHz are possible. With the updated logic any casting between signed and unsigned is avoided and the numbers look like this instead: GPLL: 18446744073709551615 - 1188000000 = 18446744072521551615 CPLL: 18446744073709551615 - 1500000000 = 18446744072209551615 XIN24M: 18446744073709551615 - 24000000 = 18446744073685551615 As a result the parent with the highest acceptable rate is chosen instead of the parent clock with the lowest one. Cc: stable@vger.kernel.org Fixes: 4950240800 ("mmc: sdhci-of-dwcmshc: properly determine max clock on Rockchip") Tested-by: Christopher Obbard <chris.obbard@collabora.com> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com> Link: https://lore.kernel.org/r/20230526171057.66876-2-sebastian.reichel@collabora.com Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Signed-off-by: Stephen Boyd <sboyd@kernel.org>		2023-06-12 17:42:10 -07:00
..
actions	clk: actions: remove redundant assignment after a mask operation	2022-04-22 19:01:20 -07:00
analogbits
at91	clk: at91: clk-sam9x60-pll: fix return value check	2023-03-06 12:30:01 -08:00
axis
axs10x	clk: axs10x: Use managed of_clk_add_hw_provider()	2023-04-10 12:45:12 -07:00
baikal-t1	clk: baikal-t1: Convert to platform device driver	2022-09-30 14:20:56 -07:00
bcm	Nothing looks out of the ordinary in this batch of clk driver updates. There	2023-04-29 17:29:39 -07:00
berlin	clk: berlin: Add of_node_put() for of_get_parent()	2022-08-19 14:50:24 -07:00
davinci	clk: remove davinci dm3xx drivers	2023-01-12 10:53:12 +01:00
hisilicon	Nothing looks out of the ordinary in this batch of clk driver updates. There	2023-04-29 17:29:39 -07:00
imgtec
imx	A couple more patches that would be good to get into -rc1.	2023-05-07 10:31:45 -07:00
ingenic	clk: ingenic: jz4760: Update M/N/OD calculation algorithm	2023-01-25 16:08:27 -08:00
keystone	clk: keystone: Convert to platform remove callback returning void	2023-03-28 19:23:38 -07:00
mediatek	clk: mediatek: mt8365: Fix index issue	2023-06-12 12:22:03 -07:00
meson	clk: meson: clk-cpu-dyndiv: switch from .round_rate to .determine_rate	2023-01-13 15:14:12 +01:00
microchip	Nothing looks out of the ordinary in this batch of clk driver updates. There	2023-04-29 17:29:39 -07:00
mmp	clk: mmp: Convert to platform remove callback returning void	2023-03-28 19:31:44 -07:00
mstar	clk: mstar: msc313 cpupll clk driver	2022-10-27 11:44:27 -07:00
mvebu	clk: mvebu: Convert to platform remove callback returning void	2023-03-28 19:31:44 -07:00
mxs
nxp	clk: nxp: fix typo in comment	2022-10-03 12:34:32 -07:00
pistachio	clk: pistachio: Fix initconst confusion	2022-09-28 18:35:45 -07:00
pxa	clk: pxa: add a check for the return value of kzalloc()	2022-10-03 12:32:03 -07:00
qcom	clk: qcom: gcc-sc8280xp: Add EMAC GDSCs	2023-04-24 07:22:01 -07:00
ralink	clk: ralink: fix 'mt7621_gate_is_enabled()' function	2023-02-10 16:07:56 -08:00
renesas	Nothing looks out of the ordinary in this batch of clk driver updates. There	2023-04-29 17:29:39 -07:00
rockchip	Merge branches 'clk-of', 'clk-samsung', 'clk-rockchip' and 'clk-qcom' into clk-next	2023-04-25 11:52:25 -07:00
samsung	clk: samsung: exynos850: Make PMU_ALIVE_PCLK critical	2023-03-13 08:24:57 +01:00
sifive	clk: sifive: make SiFive clk drivers depend on ARCH_ symbols	2023-04-10 13:00:59 -07:00
socfpga	clk: socfpga: arria10: use of_clk_add_hw_provider and improve error handling	2023-03-21 16:47:48 -07:00
spear	clk: spear: Fix SSP clock definition on SPEAr600	2022-11-22 18:03:52 -08:00
sprd	Nothing looks out of the ordinary in this batch of clk driver updates. There	2023-04-29 17:29:39 -07:00
st	clk: st: Fix memory leak in st_of_quadfs_setup()	2022-12-07 18:27:11 -08:00
starfive	clk: starfive: Fix RESET_STARFIVE_JH7110 can't be selected in a specified case	2023-05-02 18:34:49 -07:00
stm32	clk: stm32: Convert to platform remove callback returning void	2023-03-28 19:31:44 -07:00
sunxi	clk: sunxi: Do not select the PRCM MFD	2022-07-04 21:59:30 +02:00
sunxi-ng	clk: sunxi-ng: d1: Add CAN bus gates and resets	2023-01-08 22:06:10 +01:00
tegra	Merge branches 'clk-xilinx', 'clk-broadcom' and 'clk-platform' into clk-next	2023-04-25 11:50:36 -07:00
ti	Merge branches 'clk-xilinx', 'clk-broadcom' and 'clk-platform' into clk-next	2023-04-25 11:50:36 -07:00
uniphier	clk: uniphier: Use managed of_clk_add_hw_provider()	2023-04-10 12:56:25 -07:00
ux500	clk: ux500: fix a possible off-by-one in u8500_prcc_reset_base()	2022-05-18 13:34:03 -07:00
versatile
visconti	clk: visconti: remove unused visconti_pll_provider::regmap	2023-03-06 11:43:29 -08:00
x86	clk: x86: Convert to platform remove callback returning void	2023-03-28 19:31:45 -07:00
xilinx	Merge branches 'clk-xilinx', 'clk-broadcom' and 'clk-platform' into clk-next	2023-04-25 11:50:36 -07:00
zynq
zynqmp	clk: zynqmp: pll: Remove the limit	2023-03-27 12:08:28 -07:00
.kunitconfig	clk: explicitly disable CONFIG_UML_PCI_OVER_VIRTIO in .kunitconfig	2022-07-14 10:35:44 -06:00
clk_test.c	clk: tests: Add tests for notifiers	2022-10-10 20:37:50 -07:00
clk-apple-nco.c
clk-asm9260.c	clk: asm9260: use parent index to link the reference clock	2022-09-29 17:55:26 -07:00
clk-aspeed.c
clk-aspeed.h
clk-ast2600.c	clk: ast2600: Add comment about combined clock + reset handling	2023-03-06 14:11:29 -08:00
clk-axi-clkgen.c	clk: axi-clkgen: Use managed of_clk_add_hw_provider()	2023-04-10 12:45:12 -07:00
clk-axm5516.c	clk: axm5516: Use managed of_clk_add_hw_provider()	2023-04-10 12:45:12 -07:00
clk-bd718x7.c
clk-bm1880.c	clk: bm1880: remove MODULE_LICENSE in non-modules	2023-04-13 13:13:50 -07:00
clk-bulk.c	clk: bulk: Use dev_err_probe() helper in __clk_bulk_get()	2022-10-17 16:07:51 -07:00
clk-cdce706.c	clk: cdce706: Use managed of_clk_add_hw_provider()	2023-04-10 12:45:12 -07:00
clk-cdce925.c	clk: cdce925: simplify using devm_regulator_get_enable()	2022-10-17 16:06:49 -07:00
clk-clps711x.c
clk-composite.c	clk: composite: Fix handling of high clock rates	2023-06-12 17:42:10 -07:00
clk-conf.c	clk: add missing of_node_put() in "assigned-clocks" property parsing	2023-03-29 13:53:28 -07:00
clk-cs2000-cp.c	i2c: Make remove callback return void	2022-08-16 12:46:26 +02:00
clk-devres.c	clk: Fix pointer casting to prevent oops in devm_clk_release()	2022-06-22 16:10:23 -07:00
clk-divider.c	clk: Introduce clk_hw_init_rate_request()	2022-09-15 09:31:40 -07:00
clk-en7523.c	clk: en7523: fix wrong pointer check in en7523_clk_probe()	2022-04-26 11:17:47 -07:00
clk-fixed-factor.c	clk: fixed-factor: Convert to platform remove callback returning void	2023-03-28 19:23:36 -07:00
clk-fixed-mmio.c	Nothing looks out of the ordinary in this batch of clk driver updates. There	2023-04-29 17:29:39 -07:00
clk-fixed-rate.c	clk: fixed-rate: Convert to platform remove callback returning void	2023-03-28 19:23:36 -07:00
clk-fractional-divider.c	clk: Compute masks for fractional_divider clk when needed.	2023-04-05 12:09:26 -07:00
clk-fractional-divider.h
clk-fsl-flexspi.c
clk-fsl-sai.c	kbuild, clk: remove MODULE_LICENSE in non-modules	2023-03-06 11:29:18 -08:00
clk-gate_test.c
clk-gate.c
clk-gemini.c
clk-gpio.c
clk-hi655x.c
clk-highbank.c
clk-hsdk-pll.c	clk: hsdk-pll: Use managed of_clk_add_hw_provider()	2023-04-10 12:45:12 -07:00
clk-k210.c	clk: k210: remove an implicit 64-bit division	2023-03-06 14:41:20 -08:00
clk-lan966x.c	clk: allow building lan966x as a module	2022-10-03 14:14:02 -07:00
clk-lmk04832.c	clk: lmk04832: Use managed of_clk_add_hw_provider()	2023-04-10 12:45:13 -07:00
clk-lochnagar.c	dt-bindings: clock: Move lochnagar.h to dt-bindings/clock	2022-08-22 16:04:00 -07:00
clk-loongson1.c	clk: loongson1: Re-implement the clock driver	2023-03-21 16:34:23 -07:00
clk-loongson2.c	clk: clk-loongson2: add clock controller driver support	2023-03-27 12:15:26 -07:00
clk-max9485.c	clk: max9485: use simple i2c probe function	2022-04-22 19:28:08 -07:00
clk-max77686.c
clk-milbeaut.c	clock: milbeaut: use devm_platform_get_and_ioremap_resource()	2023-03-29 14:48:32 -07:00
clk-moxart.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - gpl-2.0_56.RULE (part 2)	2022-06-10 14:51:35 +02:00
clk-multiplier.c
clk-mux.c	clk: mux: remove redundant initialization of variable width	2022-04-25 15:49:20 -07:00
clk-nomadik.c	clk: nomadik: correct struct name kernel-doc warning	2022-12-09 10:26:25 -08:00
clk-npcm7xx.c	clk: clk-npcm7xx: Remove unused struct npcm7xx_clk_gate_data and npcm7xx_clk_div_fixed_data	2022-09-28 17:39:04 -07:00
clk-nspire.c
clk-oxnas.c	clk: oxnas: Hold reference returned by of_get_parent()	2022-08-19 14:35:43 -07:00
clk-palmas.c	clk: palmas: Convert to platform remove callback returning void	2023-03-28 19:23:37 -07:00
clk-plldig.c
clk-pwm.c	clk: pwm: Convert to platform remove callback returning void	2023-03-28 19:23:37 -07:00
clk-qoriq.c	clk: qoriq: Hold reference returned by of_get_parent()	2022-08-19 14:41:47 -07:00
clk-renesas-pcie.c	Nothing looks out of the ordinary in this batch of clk driver updates. There	2023-04-29 17:29:39 -07:00
clk-rk808.c
clk-s2mps11.c	clk: s2mps11: Convert to platform remove callback returning void	2023-03-28 19:23:37 -07:00
clk-scmi.c
clk-scpi.c	clk: scpi: Convert to platform remove callback returning void	2023-03-28 19:23:37 -07:00
clk-si514.c	clk: si514: Use managed of_clk_add_hw_provider()	2023-04-10 12:56:24 -07:00
clk-si521xx.c	clk: si521xx: Clock driver for Skyworks Si521xx I2C PCIe clock generators	2023-03-27 10:47:42 -07:00
clk-si544.c	clk: si544: use i2c_match_id and simple i2c probe	2022-04-22 19:28:08 -07:00
clk-si570.c	clk: si570: Use managed of_clk_add_hw_provider()	2023-04-10 12:56:24 -07:00
clk-si5341.c	i2c: Make remove callback return void	2022-08-16 12:46:26 +02:00
clk-si5351.c	clk: si5351: Use managed of_clk_add_hw_provider()	2023-04-10 12:56:25 -07:00
clk-si5351.h
clk-sp7021.c	clk: sp7021: Adjust width of _m in HWM_FIELD_PREP()	2023-05-02 18:34:26 -07:00
clk-sparx5.c
clk-stm32f4.c
clk-stm32h7.c	clk: stm32h7: Remove an unused field in struct stm32_fractional_divider	2023-04-03 14:10:42 -07:00
clk-stm32mp1.c	clk: stm32mp1: Convert to platform remove callback returning void	2023-03-28 19:23:37 -07:00
clk-tps68470.c	platform/x86: int3472: Support multiple clock consumers	2022-09-24 19:12:32 +02:00
clk-twl6040.c
clk-versaclock5.c	clk: vc5: Add support for 5P49V60	2023-01-18 10:49:52 -08:00
clk-versaclock7.c	Here's the main clk pull request for this merge window. We have some	2022-10-08 10:06:48 -07:00
clk-vt8500.c
clk-wm831x.c
clk-xgene.c	clk: clk-xgene: simplify if-if to if-else	2022-10-03 14:13:29 -07:00
clk.c	Merge branches 'clk-cleanup', 'clk-aspeed', 'clk-dt', 'clk-renesas' and 'clk-skyworks' into clk-next	2023-04-25 11:49:50 -07:00
clk.h
clkdev.c	clkdev: Simplify devm_clk_hw_register_clkdev() function	2022-09-30 14:50:11 -07:00
Kconfig	Nothing looks out of the ordinary in this batch of clk driver updates. There	2023-04-29 17:29:39 -07:00
Makefile	Merge branches 'clk-starfive', 'clk-fractional' and 'clk-devmof' into clk-next	2023-04-25 11:50:49 -07:00