linux/net/dccp/ccids
Gerrit Renker d50ad163e6 [CCID2]: Deadlock and spurious timeouts when Ack Ratio > cwnd
This patch removes a bug in the current code. I agree with Andrea's comment
that there is a problem here but the way it is treated does not fix it.

The problem is that whenever Ack Ratio > cwnd, starvation/deadlock occurs:
 * the receiver will not send an Ack until (Ack Ratio - cwnd) data packets
   have arrived;
 * the sender will not send any data packet before the receipt of an Ack
   advances the send window.
The only way that the connection then progresses was via RTO timeout. In one
extreme case (bulk transfer), it was observed that this happened for every single
packet; i.e. hundreds of packets, each a RTO timeout of 1..3 seconds apart:
a transfer which normally would take a fraction of a second thus grew to
several minutes.

The solution taken by this approach is to observe the relation

                   "Ack Ratio <= cwnd"

by using the constraint (1) from RFC 4341, 6.1.2; i.e. set

                 Ack Ratio = ceil(cwnd / 2)

and update it whenever either Ack Ratio or cwnd change. This ensures that
the deadlock problem can not arise.

Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Acked-by: Ian McDonald <ian.mcdonald@jandi.co.nz>
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2008-01-28 14:54:53 -08:00
..
lib [CCID3]: Inline for moving average 2008-01-28 14:54:43 -08:00
ccid2.c [CCID2]: Deadlock and spurious timeouts when Ack Ratio > cwnd 2008-01-28 14:54:53 -08:00
ccid2.h [CCID2]: Remove redundant BUG_ON 2007-10-10 16:54:34 -07:00
ccid3.c [CCID3]: Inline for moving average 2008-01-28 14:54:43 -08:00
ccid3.h [CCID3]: Accurately determine idle & application-limited periods 2008-01-28 14:54:42 -08:00
Kconfig [DCCP]: Remove redundant dependency on IP_DCCP 2008-01-28 14:54:46 -08:00
Makefile [DCCP] CCID2: Initial CCID2 (TCP-Like) implementation 2006-03-20 17:41:47 -08:00