linux/tools/perf
Arnaldo Carvalho de Melo d3379ab905 perf symbols: Fix comparision of build_ids
When we read the build_id from the DSO name to then index into
/usr/lib/debug/.buildid/DSO_BUILD_ID[0:2]/DSO_BUILD_ID[2:], we
were jumping directly to the comparision with the buildid we
already have in dso->build_id (that came from the perf.data
build_id section, collected at perf record time)
unconditionally, even if we didn't had recorded it, and
furthermore, comparing a formatted buildid with a rawbuildid, yikes.

Fix it by deleting the dso__read_build_id() function, that was
really misdesigned anyway, and do the necessary checks and
correct comparison of raw buildids.

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Frédéric Weisbecker <fweisbec@gmail.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
LKML-Reference: <1258582853-8579-1-git-send-email-acme@infradead.org>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
2009-11-19 08:28:11 +01:00
..
bench perf bench: Improve sched-message.c with more comfortable output 2009-11-10 19:56:46 +01:00
Documentation Merge branch 'perf/core' into perf/probes 2009-11-17 10:17:47 +01:00
util perf symbols: Fix comparision of build_ids 2009-11-19 08:28:11 +01:00
.gitignore perf tools: .gitignore += perf*.html 2009-09-24 14:01:22 +02:00
builtin-annotate.c perf tools: Simplify the symbol priv area mechanism 2009-11-02 16:52:11 +01:00
builtin-bench.c perf bench: Improve builtin-bench.c for more friendly output 2009-11-10 19:56:44 +01:00
builtin-buildid-list.c perf buildid-list: Always show the DSO name 2009-11-17 07:19:54 +01:00
builtin-help.c perf: Clean up trivial style issues in builtin-help.c 2009-11-03 18:37:29 +01:00
builtin-list.c perf list: Fix large list output by using the pager 2009-08-13 09:05:48 +02:00
builtin-probe.c perf/probes: Rename perf probe events group name 2009-11-04 13:02:47 +01:00
builtin-record.c perf tools: Don't die() in perf_header__new() 2009-11-17 07:19:56 +01:00
builtin-report.c perf tools: Simplify the symbol priv area mechanism 2009-11-02 16:52:11 +01:00
builtin-sched.c perf tools: Simplify the symbol priv area mechanism 2009-11-02 16:52:11 +01:00
builtin-stat.c perf stat: Do not print ratio when task-clock event is not counted 2009-11-15 15:25:50 +01:00
builtin-timechart.c perf tools: Simplify the symbol priv area mechanism 2009-11-02 16:52:11 +01:00
builtin-top.c perf top: Don't allocate the source parsing members upfront 2009-11-19 06:03:41 +01:00
builtin-trace.c perf tools: Simplify the symbol priv area mechanism 2009-11-02 16:52:11 +01:00
builtin.h Merge branch 'perf/core' into perf/probes 2009-11-17 10:17:47 +01:00
command-list.txt Merge branch 'perf/core' into perf/probes 2009-11-17 10:17:47 +01:00
CREDITS perf_counter tools: Add CREDITS file for Git contributors 2009-06-24 19:54:29 +02:00
design.txt perf_event: Add alignment-faults and emulation-faults software events 2009-10-28 16:13:03 +11:00
Makefile perf tools: Add ia64 support for tools/perf/ 2009-11-19 06:03:33 +01:00
perf.c Merge branch 'perf/core' into perf/probes 2009-11-17 10:17:47 +01:00
perf.h perf tools: Add ia64 support for tools/perf/ 2009-11-19 06:03:33 +01:00