mirror of
https://github.com/torvalds/linux.git
synced 2024-12-24 20:01:55 +00:00
5f01c98859
Consider a kernel crash in a module, simulated the following way:
static int my_init(void)
{
char *map = (void *)0x5;
*map = 3;
return 0;
}
module_init(my_init);
When we turn off FRAME_POINTERs, the very first instruction in
that function causes a BUG. The problem is that we print IP in
the BUG report using %pB (from printk_address). And %pB
decrements the pointer by one to fix printing addresses of
functions with tail calls.
This was added in commit 71f9e59800 ("x86, dumpstack: Use
%pB format specifier for stack trace") to fix the call stack
printouts.
So instead of correct output:
BUG: unable to handle kernel NULL pointer dereference at 0000000000000005
IP: [<ffffffffa01ac000>] my_init+0x0/0x10 [pb173]
We get:
BUG: unable to handle kernel NULL pointer dereference at 0000000000000005
IP: [<ffffffffa0152000>] 0xffffffffa0151fff
To fix that, we use %pS only for stack addresses printouts (via
newly added printk_stack_address) and %pB for regs->ip (via
printk_address). I.e. we revert to the old behaviour for all
except call stacks. And since from all those reliable is 1, we
remove that parameter from printk_address.
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Namhyung Kim <namhyung@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: joe@perches.com
Cc: jirislaby@gmail.com
Link: http://lkml.kernel.org/r/1382706418-8435-1-git-send-email-jslaby@suse.cz
Signed-off-by: Ingo Molnar <mingo@kernel.org>
40 lines
937 B
C
40 lines
937 B
C
#ifndef _ASM_X86_KDEBUG_H
|
|
#define _ASM_X86_KDEBUG_H
|
|
|
|
#include <linux/notifier.h>
|
|
|
|
struct pt_regs;
|
|
|
|
/* Grossly misnamed. */
|
|
enum die_val {
|
|
DIE_OOPS = 1,
|
|
DIE_INT3,
|
|
DIE_DEBUG,
|
|
DIE_PANIC,
|
|
DIE_NMI,
|
|
DIE_DIE,
|
|
DIE_KERNELDEBUG,
|
|
DIE_TRAP,
|
|
DIE_GPF,
|
|
DIE_CALL,
|
|
DIE_PAGE_FAULT,
|
|
DIE_NMIUNKNOWN,
|
|
};
|
|
|
|
extern void printk_address(unsigned long address);
|
|
extern void die(const char *, struct pt_regs *,long);
|
|
extern int __must_check __die(const char *, struct pt_regs *, long);
|
|
extern void show_trace(struct task_struct *t, struct pt_regs *regs,
|
|
unsigned long *sp, unsigned long bp);
|
|
extern void __show_regs(struct pt_regs *regs, int all);
|
|
extern unsigned long oops_begin(void);
|
|
extern void oops_end(unsigned long, struct pt_regs *, int signr);
|
|
#ifdef CONFIG_KEXEC
|
|
extern int in_crash_kexec;
|
|
#else
|
|
/* no crash dump is ever in progress if no crash kernel can be kexec'd */
|
|
#define in_crash_kexec 0
|
|
#endif
|
|
|
|
#endif /* _ASM_X86_KDEBUG_H */
|