Richard Weinberger cf6f54e3f1 UBIFS: Kill unneeded locking in ubifs_init_security ... Fixes the following lockdep splat: [ 1.244527] ============================================= [ 1.245193] [ INFO: possible recursive locking detected ] [ 1.245193] 4.2.0-rc1+ #37 Not tainted [ 1.245193] --------------------------------------------- [ 1.245193] cp/742 is trying to acquire lock: [ 1.245193] (&sb->s_type->i_mutex_key#9){+.+.+.}, at: [<ffffffff812b3f69>] ubifs_init_security+0x29/0xb0 [ 1.245193] [ 1.245193] but task is already holding lock: [ 1.245193] (&sb->s_type->i_mutex_key#9){+.+.+.}, at: [<ffffffff81198e7f>] path_openat+0x3af/0x1280 [ 1.245193] [ 1.245193] other info that might help us debug this: [ 1.245193] Possible unsafe locking scenario: [ 1.245193] [ 1.245193] CPU0 [ 1.245193] ---- [ 1.245193] lock(&sb->s_type->i_mutex_key#9); [ 1.245193] lock(&sb->s_type->i_mutex_key#9); [ 1.245193] [ 1.245193] *** DEADLOCK *** [ 1.245193] [ 1.245193] May be due to missing lock nesting notation [ 1.245193] [ 1.245193] 2 locks held by cp/742: [ 1.245193] #0: (sb_writers#5){.+.+.+}, at: [<ffffffff811ad37f>] mnt_want_write+0x1f/0x50 [ 1.245193] #1: (&sb->s_type->i_mutex_key#9){+.+.+.}, at: [<ffffffff81198e7f>] path_openat+0x3af/0x1280 [ 1.245193] [ 1.245193] stack backtrace: [ 1.245193] CPU: 2 PID: 742 Comm: cp Not tainted 4.2.0-rc1+ #37 [ 1.245193] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.7.5-0-ge51488c-20140816_022509-build35 04/01/2014 [ 1.245193] ffffffff8252d530 ffff88007b023a38 ffffffff814f6f49 ffffffff810b56c5 [ 1.245193] ffff88007c30cc80 ffff88007b023af8 ffffffff810a150d ffff88007b023a68 [ 1.245193] 000000008101302a ffff880000000000 00000008f447e23f ffffffff8252d500 [ 1.245193] Call Trace: [ 1.245193] [<ffffffff814f6f49>] dump_stack+0x4c/0x65 [ 1.245193] [<ffffffff810b56c5>] ? console_unlock+0x1c5/0x510 [ 1.245193] [<ffffffff810a150d>] __lock_acquire+0x1a6d/0x1ea0 [ 1.245193] [<ffffffff8109fa78>] ? __lock_is_held+0x58/0x80 [ 1.245193] [<ffffffff810a1a93>] lock_acquire+0xd3/0x270 [ 1.245193] [<ffffffff812b3f69>] ? ubifs_init_security+0x29/0xb0 [ 1.245193] [<ffffffff814fc83b>] mutex_lock_nested+0x6b/0x3a0 [ 1.245193] [<ffffffff812b3f69>] ? ubifs_init_security+0x29/0xb0 [ 1.245193] [<ffffffff812b3f69>] ? ubifs_init_security+0x29/0xb0 [ 1.245193] [<ffffffff812b3f69>] ubifs_init_security+0x29/0xb0 [ 1.245193] [<ffffffff8128e286>] ubifs_create+0xa6/0x1f0 [ 1.245193] [<ffffffff81198e7f>] ? path_openat+0x3af/0x1280 [ 1.245193] [<ffffffff81195d15>] vfs_create+0x95/0xc0 [ 1.245193] [<ffffffff8119929c>] path_openat+0x7cc/0x1280 [ 1.245193] [<ffffffff8109ffe3>] ? __lock_acquire+0x543/0x1ea0 [ 1.245193] [<ffffffff81088f20>] ? sched_clock_cpu+0x90/0xc0 [ 1.245193] [<ffffffff81088c00>] ? calc_global_load_tick+0x60/0x90 [ 1.245193] [<ffffffff81088f20>] ? sched_clock_cpu+0x90/0xc0 [ 1.245193] [<ffffffff811a9cef>] ? __alloc_fd+0xaf/0x180 [ 1.245193] [<ffffffff8119ac55>] do_filp_open+0x75/0xd0 [ 1.245193] [<ffffffff814ffd86>] ? _raw_spin_unlock+0x26/0x40 [ 1.245193] [<ffffffff811a9cef>] ? __alloc_fd+0xaf/0x180 [ 1.245193] [<ffffffff81189bd9>] do_sys_open+0x129/0x200 [ 1.245193] [<ffffffff81189cc9>] SyS_open+0x19/0x20 [ 1.245193] [<ffffffff81500717>] entry_SYSCALL_64_fastpath+0x12/0x6f While the lockdep splat is a false positive, becuase path_openat holds i_mutex of the parent directory and ubifs_init_security() tries to acquire i_mutex of a new inode, it reveals that taking i_mutex in ubifs_init_security() is in vain because it is only being called in the inode allocation path and therefore nobody else can see the inode yet. Cc: stable@vger.kernel.org # 3.20- Reported-and-tested-by: Boris Brezillon <boris.brezillon@free-electrons.com> Reviewed-and-tested-by: Dongsheng Yang <yangds.fnst@cn.fujitsu.com> Signed-off-by: Richard Weinberger <richard@nod.at> Signed-off-by: dedekind1@gmail.com		2015-09-29 12:45:42 +02:00
..
9p	9p: fix return code of read() when count is 0	2015-08-23 14:21:36 -05:00
adfs	fs/adfs: remove unneeded cast	2015-06-30 19:44:57 -07:00
affs	fs/affs: make root lookup from blkdev logical size	2015-09-10 13:29:01 -07:00
afs	net: Add a struct net parameter to sock_create_kern	2015-05-11 10:50:17 -04:00
autofs4	make simple_positive() public	2015-06-23 18:02:01 -04:00
befs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-07-04 19:36:06 -07:00
bfs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-04-26 17:22:07 -07:00
btrfs	Merge branch 'for-linus-4.3' of git://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs	2015-09-11 12:38:25 -07:00
cachefiles	Merge branch 'fscache-fixes' into for-next	2015-06-23 18:01:30 -04:00
ceph	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/sage/ceph-client	2015-09-11 12:33:03 -07:00
cifs	[CIFS] mount option sec=none not displayed properly in /proc/mounts	2015-09-11 19:37:06 -05:00
coda	fs/coda: fix readlink buffer overflow	2015-09-10 13:29:01 -07:00
configfs	configfs: fix kernel infoleak through user-controlled format string	2015-07-17 16:39:53 -07:00
cramfs
debugfs	debugfs: Export bool read/write functions	2015-07-20 18:44:50 +01:00
devpts	devpts: if initialization failed, don't crash when opening /dev/ptmx	2015-06-30 19:44:58 -07:00
dlm	dlm for 4.3	2015-09-03 12:57:48 -07:00
ecryptfs	Invalidate stale eCryptfs dcache entries caused by unlinked lower inodes	2015-09-08 11:26:17 -07:00
efivarfs	Merge branch 'x86-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2015-05-06 10:57:37 -07:00
efs	fs/efs: femove unneeded cast	2015-06-25 17:00:42 -07:00
exofs	pagemap.h: move dir_pages() over there	2015-06-23 18:02:00 -04:00
exportfs	VFS: (Scripted) Convert S_ISLNK/DIR/REG(dentry->d_inode) to d_is_*(dentry)	2015-02-22 11:38:41 -05:00
ext2	ext2: huge page fault support	2015-09-08 15:35:28 -07:00
ext4	ext4: start transaction before calling into DAX	2015-09-08 15:35:28 -07:00
f2fs	Merge tag 'for-f2fs-4.3' of git://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs	2015-09-03 13:10:22 -07:00
fat	writeback: separate out include/linux/backing-dev-defs.h	2015-06-02 08:33:34 -06:00
freevxfs	freevxfs: Grammar s/an negative/a negative/	2015-08-07 13:59:24 +02:00
fscache	FS-Cache: Retain the netfs context in the retrieval op earlier	2015-04-02 14:28:53 +01:00
fuse	fs/fuse: fix ioctl type confusion	2015-08-16 12:35:44 -07:00
gfs2	GFS2: merge window	2015-09-11 12:23:51 -07:00
hfs	hfs: fix B-tree corruption after insertion at position 0	2015-09-10 13:29:01 -07:00
hfsplus	hfs,hfsplus: cache pages correctly between bnode_create and bnode_free	2015-09-10 13:29:01 -07:00
hostfs	fs: create and use seq_show_option for escaping	2015-09-04 16:54:41 -07:00
hpfs	hpfs: update ctime and mtime on directory modification	2015-09-03 11:55:30 -07:00
hugetlbfs	hugetlbfs: add hugetlbfs_fallocate()	2015-09-08 15:35:28 -07:00
isofs	VFS: normal filesystems (and lustre): d_inode() annotations	2015-04-15 15:06:57 -04:00
jbd2	jbd2: limit number of reserved credits	2015-08-04 11:21:52 -04:00
jffs2	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-07-04 19:36:06 -07:00
jfs	Merge branch 'for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jack/linux-fs	2015-09-03 12:28:30 -07:00
kernfs	kernfs: implement kernfs_path_len()	2015-08-18 15:49:15 -07:00
lockd	lockd: NLM grace period shouldn't block NFSv4 opens	2015-08-13 10:22:06 -04:00
logfs	block: remove bio_get_nr_vecs()	2015-08-13 12:32:04 -06:00
minix	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-07-04 19:36:06 -07:00
ncpfs	ncpfs: successful rename() should invalidate caches for parents	2015-06-14 11:31:39 -04:00
nfs	NFS client updates for Linux 4.3	2015-09-07 14:02:24 -07:00
nfs_common	lockd: NLM grace period shouldn't block NFSv4 opens	2015-08-13 10:22:06 -04:00
nfsd	NFS client updates for Linux 4.3	2015-09-07 14:02:24 -07:00
nilfs2	block: remove bio_get_nr_vecs()	2015-08-13 12:32:04 -06:00
nls
notify	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-09-05 20:34:28 -07:00
ntfs	ntfs: delete unnecessary checks before calling iput()	2015-09-04 16:54:41 -07:00
ocfs2	revert "ocfs2/dlm: use list_for_each_entry instead of list_for_each"	2015-09-11 15:21:34 -07:00
omfs	omfs: fix potential integer overflow in allocator	2015-05-28 18:25:19 -07:00
openpromfs
overlayfs	fs: create and use seq_show_option for escaping	2015-09-04 16:54:41 -07:00
proc	proc: convert to kstrto*()/kstrto*_from_user()	2015-09-10 13:29:01 -07:00
pstore	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace	2015-07-03 15:20:57 -07:00
qnx4
qnx6	pagemap.h: move dir_pages() over there	2015-06-23 18:02:00 -04:00
quota	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-09-05 20:34:28 -07:00
ramfs	VFS: normal filesystems (and lustre): d_inode() annotations	2015-04-15 15:06:57 -04:00
reiserfs	fs: create and use seq_show_option for escaping	2015-09-04 16:54:41 -07:00
romfs	make new_sync_{read,write}() static	2015-04-11 22:29:40 -04:00
squashfs	fs: cleanup slight list_entry abuse	2015-06-23 18:01:59 -04:00
sysfs	vfs: Commit to never having exectuables on proc and sysfs.	2015-07-10 10:39:25 -05:00
sysv	pagemap.h: move dir_pages() over there	2015-06-23 18:02:00 -04:00
tracefs	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-07-04 19:36:06 -07:00
ubifs	UBIFS: Kill unneeded locking in ubifs_init_security	2015-09-29 12:45:42 +02:00
udf	udf: Don't modify filesystem for read-only mounts	2015-08-20 14:58:35 +02:00
ufs	fix ufs write vs readpage race when writing into a hole	2015-09-09 10:43:12 -07:00
xfs	xfs: huge page fault support	2015-09-08 15:35:28 -07:00
aio.c	mm: move ->mremap() from file_operations to vm_operations_struct	2015-09-04 16:54:41 -07:00
anon_inodes.c
attr.c
bad_inode.c	don't bother with most of the bad_file_ops methods	2015-02-20 04:03:58 -05:00
binfmt_aout.c
binfmt_elf_fdpic.c
binfmt_elf.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-07-04 19:36:06 -07:00
binfmt_em86.c
binfmt_flat.c
binfmt_misc.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs	2015-04-26 17:22:07 -07:00
binfmt_script.c
block_dev.c	blockdev: don't set S_DAX for misaligned partitions	2015-09-15 20:08:05 -04:00
buffer.c	fs: use helper bio_add_page() instead of open coding on bi_io_vec	2015-08-13 12:32:00 -06:00
char_dev.c	fs/char_dev.c: fix incorrect documentation for unregister_chrdev_region	2015-08-05 13:49:35 -07:00
compat_binfmt_elf.c
compat_ioctl.c	ioctl_compat: handle FITRIM	2015-07-09 11:42:21 -07:00
compat.c
coredump.c	fs: Don't dump core if the corefile would become world-readable.	2015-09-10 13:29:01 -07:00
dax.c	dax: fix O_DIRECT I/O to the last block of a blockdev	2015-09-15 20:07:35 -04:00
dcache.c	dcache: Reduce the scope of i_lock in d_splice_alias	2015-08-21 02:34:37 -04:00
dcookies.c
direct-io.c	block: remove bio_get_nr_vecs()	2015-08-13 12:32:04 -06:00
drop_caches.c	inode: convert inode_sb_list_lock to per-sb	2015-08-17 18:39:46 -04:00
eventfd.c	eventfd: don't take the spinlock in eventfd_poll	2015-02-17 14:34:52 -08:00
eventpoll.c	epoll: optimize setting task running after blocking	2015-02-13 21:21:40 -08:00
exec.c	vfs: Commit to never having exectuables on proc and sysfs.	2015-07-10 10:39:25 -05:00
fcntl.c
fhandle.c	vfs: read file_handle only once in handle_to_path	2015-06-02 10:29:07 -07:00
file_table.c	fs, file table: reinit files_stat.max_files after deferred memory initialisation	2015-08-07 04:39:40 +03:00
file.c	fs/file.c: __fget() and dup2() atomicity rules	2015-07-01 02:31:08 -04:00
filesystems.c
fs_pin.c	fs_pin: Allow for the possibility that m_list or s_list go unused.	2015-04-09 11:39:55 -05:00
fs_struct.c
fs-writeback.c	fs-writeback: unplug before cond_resched in writeback_sb_inodes	2015-09-19 18:50:19 -07:00
inode.c	inode: don't softlockup when evicting inodes	2015-08-18 10:20:09 -07:00
internal.h	inode: rename i_wb_list to i_io_list	2015-08-17 23:38:10 -04:00
ioctl.c
Kconfig	fs: Remove ext3 filesystem driver	2015-07-23 20:59:40 +02:00
Kconfig.binfmt	mm: split ET_DYN ASLR from mmap ASLR	2015-04-14 16:49:05 -07:00
libfs.c	fs: Set the size of empty dirs to 0.	2015-08-12 15:28:45 -05:00
locks.c	fs: fix fs/locks.c kernel-doc warning	2015-08-31 16:27:25 -04:00
Makefile	userfaultfd: buildsystem activation	2015-09-04 16:54:41 -07:00
mbcache.c
mount.h	fs: use seq_open_private() for proc_mounts	2015-06-30 19:44:56 -07:00
mpage.c	block: remove bio_get_nr_vecs()	2015-08-13 12:32:04 -06:00
namei.c	namei: fix warning while make xmldocs caused by namei.c	2015-09-10 13:29:01 -07:00
namespace.c	Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace	2015-09-01 16:13:25 -07:00
no-block.c
nsfs.c	fs/seq_file: convert int seq_vprint/seq_printf/etc... returns to void	2015-09-11 15:21:34 -07:00
open.c	vfs: Commit to never having exectuables on proc and sysfs.	2015-07-10 10:39:25 -05:00
pipe.c	VFS: assorted weird filesystems: d_inode() annotations	2015-04-15 15:06:58 -04:00
pnode.c	mnt: Don't propagate unmounts to locked mounts	2015-04-02 20:34:20 -05:00
pnode.h	mnt: Clarify and correct the disconnect logic in umount_tree	2015-07-22 20:33:27 -05:00
posix_acl.c	fs/posix_acl.c: make posix_acl_create() safer and cleaner	2015-06-23 18:01:07 -04:00
proc_namespace.c	fs: use seq_open_private() for proc_mounts	2015-06-30 19:44:56 -07:00
read_write.c	new_sync_write(): discard ->ki_pos unless the return value is positive	2015-04-11 22:29:46 -04:00
readdir.c
select.c	locking/arch: Rename set_mb() to smp_store_mb()	2015-05-19 08:32:00 +02:00
seq_file.c	fs/seq_file: convert int seq_vprint/seq_printf/etc... returns to void	2015-09-11 15:21:34 -07:00
signalfd.c	signalfd: fix information leak in signalfd_copyinfo	2015-08-07 04:39:40 +03:00
splice.c	Merge branch 'akpm' (patches from Andrew)	2015-06-24 20:47:21 -07:00
stack.c
stat.c	VFS: assorted d_backing_inode() annotations	2015-04-15 15:06:59 -04:00
statfs.c
super.c	Merge branch 'superblock-scaling' of git://git.kernel.org/pub/scm/linux/kernel/git/josef/btrfs-next into for-next	2015-08-21 02:31:20 -04:00
sync.c
timerfd.c
userfaultfd.c	userfaultfd: add missing mmput() in error path	2015-09-17 21:16:07 -07:00
utimes.c
xattr.c	evm: fix potential race when removing xattrs	2015-05-21 13:28:47 -04:00