linux/drivers/isdn/mISDN
Steven Rostedt (Google) 292a089d78 treewide: Convert del_timer*() to timer_shutdown*()
Due to several bugs caused by timers being re-armed after they are
shutdown and just before they are freed, a new state of timers was added
called "shutdown".  After a timer is set to this state, then it can no
longer be re-armed.

The following script was run to find all the trivial locations where
del_timer() or del_timer_sync() is called in the same function that the
object holding the timer is freed.  It also ignores any locations where
the timer->function is modified between the del_timer*() and the free(),
as that is not considered a "trivial" case.

This was created by using a coccinelle script and the following
commands:

    $ cat timer.cocci
    @@
    expression ptr, slab;
    identifier timer, rfield;
    @@
    (
    -       del_timer(&ptr->timer);
    +       timer_shutdown(&ptr->timer);
    |
    -       del_timer_sync(&ptr->timer);
    +       timer_shutdown_sync(&ptr->timer);
    )
      ... when strict
          when != ptr->timer
    (
            kfree_rcu(ptr, rfield);
    |
            kmem_cache_free(slab, ptr);
    |
            kfree(ptr);
    )

    $ spatch timer.cocci . > /tmp/t.patch
    $ patch -p1 < /tmp/t.patch

Link: https://lore.kernel.org/lkml/20221123201306.823305113@linutronix.de/
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
Acked-by: Pavel Machek <pavel@ucw.cz> [ LED ]
Acked-by: Kalle Valo <kvalo@kernel.org> [ wireless ]
Acked-by: Paolo Abeni <pabeni@redhat.com> [ networking ]
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2022-12-25 13:38:09 -08:00
..
clock.c
core.c driver core: make struct class.dev_uevent() take a const * 2022-11-24 17:12:15 +01:00
core.h mISDN: change function names to avoid conflicts 2021-12-28 12:12:04 +00:00
dsp_audio.c
dsp_biquad.h
dsp_blowfish.c
dsp_cmx.c
dsp_core.c mISDN: Use LIST_HEAD() for list_head 2021-03-30 13:34:42 -07:00
dsp_dtmf.c
dsp_ecdis.h
dsp_hwec.c
dsp_hwec.h
dsp_pipeline.c mISDN: fix possible memory leak in mISDN_dsp_element_register() 2022-11-11 19:53:05 -08:00
dsp_tones.c
dsp.h
fsm.c
fsm.h
hwchannel.c idsn: Use pr_warn instead of pr_warning 2019-10-18 15:00:21 +02:00
Kconfig misdn: dsp: select CONFIG_BITREVERSE 2021-01-05 15:50:36 -08:00
l1oip_codec.c
l1oip_core.c treewide: Convert del_timer*() to timer_shutdown*() 2022-12-25 13:38:09 -08:00
l1oip.h mISDN: fix use-after-free bugs in l1oip timer handlers 2022-09-30 12:32:42 +01:00
layer1.c mISDN: change function names to avoid conflicts 2021-12-28 12:12:04 +00:00
layer1.h
layer2.c mISDN: Delete unnecessary checks before the macro call “dev_kfree_skb” 2019-08-22 16:22:03 -07:00
layer2.h
Makefile
socket.c net: remove noblock parameter from skb_recv_datagram() 2022-04-06 13:45:26 +01:00
stack.c treewide: Use fallthrough pseudo-keyword 2020-08-23 17:36:59 -05:00
tei.c mISDN: Delete unnecessary checks before the macro call “dev_kfree_skb” 2019-08-22 16:22:03 -07:00
timerdev.c treewide: Convert del_timer*() to timer_shutdown*() 2022-12-25 13:38:09 -08:00