mirror of
https://github.com/torvalds/linux.git
synced 2024-11-22 20:22:09 +00:00
655fc6cd45
Patch series "kexec: fix the incorrect ifdeffery and dependency of CONFIG_KEXEC". The select of KEXEC for CRASH_DUMP in kernel/Kconfig.kexec will be dropped, then compiling errors will be triggered if below config items are set: === CONFIG_CRASH_CORE=y CONFIG_KEXEC_CORE=y CONFIG_CRASH_DUMP=y === E.g on mips, below link error are seen: -------------------------------------------------------------------- mipsel-linux-ld: kernel/kexec_core.o: in function `kimage_free': kernel/kexec_core.c:(.text+0x2200): undefined reference to `machine_kexec_cleanup' mipsel-linux-ld: kernel/kexec_core.o: in function `__crash_kexec': kernel/kexec_core.c:(.text+0x2480): undefined reference to `machine_crash_shutdown' mipsel-linux-ld: kernel/kexec_core.c:(.text+0x2488): undefined reference to `machine_kexec' mipsel-linux-ld: kernel/kexec_core.o: in function `kernel_kexec': kernel/kexec_core.c:(.text+0x29b8): undefined reference to `machine_shutdown' mipsel-linux-ld: kernel/kexec_core.c:(.text+0x29c0): undefined reference to `machine_kexec' -------------------------------------------------------------------- Here, change the incorrect dependency of building kexec_core related object files, and the ifdeffery on architectures from CONFIG_KEXEC to CONFIG_KEXEC_CORE. Testing: ======== Passed on mips and loognarch with the LKP reproducer. This patch (of 5): Currently, in arch/loongarch/kernel/Makefile, building machine_kexec.o relocate_kernel.o depends on CONFIG_KEXEC. Whereas, since we will drop the select of KEXEC for CRASH_DUMP in kernel/Kconfig.kexec, compiling error will be triggered if below config items are set: === CONFIG_CRASH_CORE=y CONFIG_KEXEC_CORE=y CONFIG_CRASH_DUMP=y === --------------------------------------------------------------- loongarch64-linux-ld: kernel/kexec_core.o: in function `.L209': >> kexec_core.c:(.text+0x1660): undefined reference to `machine_kexec_cleanup' loongarch64-linux-ld: kernel/kexec_core.o: in function `.L287': >> kexec_core.c:(.text+0x1c5c): undefined reference to `machine_crash_shutdown' >> loongarch64-linux-ld: kexec_core.c:(.text+0x1c64): undefined reference to `machine_kexec' loongarch64-linux-ld: kernel/kexec_core.o: in function `.L2^B5': >> kexec_core.c:(.text+0x2090): undefined reference to `machine_shutdown' loongarch64-linux-ld: kexec_core.c:(.text+0x20a0): undefined reference to `machine_kexec' --------------------------------------------------------------- Here, change the dependency of machine_kexec.o relocate_kernel.o to CONFIG_KEXEC_CORE can fix above building error. Link: https://lkml.kernel.org/r/20231208073036.7884-1-bhe@redhat.com Link: https://lkml.kernel.org/r/20231208073036.7884-2-bhe@redhat.com Signed-off-by: Baoquan He <bhe@redhat.com> Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202311300946.kHE9Iu71-lkp@intel.com/ Cc: Eric DeVolder <eric_devolder@yahoo.com> Cc: Ignat Korchagin <ignat@cloudflare.com> Cc: Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
77 lines
2.1 KiB
Makefile
77 lines
2.1 KiB
Makefile
# SPDX-License-Identifier: GPL-2.0
|
|
#
|
|
# Makefile for the Linux/LoongArch kernel.
|
|
#
|
|
|
|
extra-y := vmlinux.lds
|
|
|
|
obj-y += head.o cpu-probe.o cacheinfo.o env.o setup.o entry.o genex.o \
|
|
traps.o irq.o idle.o process.o dma.o mem.o io.o reset.o switch.o \
|
|
elf.o syscall.o signal.o time.o topology.o inst.o ptrace.o vdso.o \
|
|
alternative.o unwind.o
|
|
|
|
obj-$(CONFIG_ACPI) += acpi.o
|
|
obj-$(CONFIG_EFI) += efi.o
|
|
|
|
obj-$(CONFIG_CPU_HAS_FPU) += fpu.o kfpu.o
|
|
|
|
obj-$(CONFIG_CPU_HAS_LBT) += lbt.o
|
|
|
|
obj-$(CONFIG_ARCH_STRICT_ALIGN) += unaligned.o
|
|
|
|
CFLAGS_module.o += $(call cc-option,-Wno-override-init,)
|
|
CFLAGS_syscall.o += $(call cc-option,-Wno-override-init,)
|
|
CFLAGS_perf_event.o += $(call cc-option,-Wno-override-init,)
|
|
|
|
ifdef CONFIG_FUNCTION_TRACER
|
|
ifndef CONFIG_DYNAMIC_FTRACE
|
|
obj-y += mcount.o ftrace.o
|
|
CFLAGS_REMOVE_ftrace.o = $(CC_FLAGS_FTRACE)
|
|
else
|
|
obj-y += mcount_dyn.o ftrace_dyn.o
|
|
CFLAGS_REMOVE_ftrace_dyn.o = $(CC_FLAGS_FTRACE)
|
|
endif
|
|
CFLAGS_REMOVE_inst.o = $(CC_FLAGS_FTRACE)
|
|
CFLAGS_REMOVE_time.o = $(CC_FLAGS_FTRACE)
|
|
CFLAGS_REMOVE_perf_event.o = $(CC_FLAGS_FTRACE)
|
|
CFLAGS_REMOVE_rethook.o = $(CC_FLAGS_FTRACE)
|
|
CFLAGS_REMOVE_rethook_trampoline.o = $(CC_FLAGS_FTRACE)
|
|
endif
|
|
|
|
KASAN_SANITIZE_efi.o := n
|
|
KASAN_SANITIZE_cpu-probe.o := n
|
|
KASAN_SANITIZE_traps.o := n
|
|
KASAN_SANITIZE_smp.o := n
|
|
KASAN_SANITIZE_vdso.o := n
|
|
|
|
obj-$(CONFIG_MODULES) += module.o module-sections.o
|
|
obj-$(CONFIG_STACKTRACE) += stacktrace.o
|
|
|
|
obj-$(CONFIG_PROC_FS) += proc.o
|
|
|
|
obj-$(CONFIG_SMP) += smp.o
|
|
|
|
obj-$(CONFIG_NUMA) += numa.o
|
|
|
|
obj-$(CONFIG_MAGIC_SYSRQ) += sysrq.o
|
|
|
|
obj-$(CONFIG_RELOCATABLE) += relocate.o
|
|
|
|
obj-$(CONFIG_KEXEC_CORE) += machine_kexec.o relocate_kernel.o
|
|
obj-$(CONFIG_CRASH_DUMP) += crash_dump.o
|
|
|
|
obj-$(CONFIG_UNWINDER_GUESS) += unwind_guess.o
|
|
obj-$(CONFIG_UNWINDER_PROLOGUE) += unwind_prologue.o
|
|
|
|
obj-$(CONFIG_PERF_EVENTS) += perf_event.o perf_regs.o
|
|
obj-$(CONFIG_HAVE_HW_BREAKPOINT) += hw_breakpoint.o
|
|
|
|
obj-$(CONFIG_KGDB) += kgdb.o
|
|
obj-$(CONFIG_KPROBES) += kprobes.o
|
|
obj-$(CONFIG_RETHOOK) += rethook.o rethook_trampoline.o
|
|
obj-$(CONFIG_UPROBES) += uprobes.o
|
|
|
|
obj-$(CONFIG_JUMP_LABEL) += jump_label.o
|
|
|
|
CPPFLAGS_vmlinux.lds := $(KBUILD_CFLAGS)
|