Eric Dumazet ca2fe2956a tcp: add sanity tests in tcp_add_backlog() ... Richard and Bruno both reported that my commit added a bug, and Bruno was able to determine the problem came when a segment wih a FIN packet was coalesced to a prior one in tcp backlog queue. It turns out the header prediction in tcp_rcv_established() looks back to TCP headers in the packet, not in the metadata (aka TCP_SKB_CB(skb)->tcp_flags) The fast path in tcp_rcv_established() is not supposed to handle a FIN flag (it does not call tcp_fin()) Therefore we need to make sure to propagate the FIN flag, so that the coalesced packet does not go through the fast path, the same than a GRO packet carrying a FIN flag. While we are at it, make sure we do not coalesce packets with RST or SYN, or if they do not have ACK set. Many thanks to Richard and Bruno for pinpointing the bad commit, and to Richard for providing a first version of the fix. Fixes: 4f693b55c3 ("tcp: implement coalescing on backlog queue") Signed-off-by: Eric Dumazet <edumazet@google.com> Reported-by: Richard Purdie <richard.purdie@linuxfoundation.org> Reported-by: Bruno Prémont <bonbons@sysophe.eu> Signed-off-by: David S. Miller <davem@davemloft.net>		2019-04-29 23:20:37 -04:00
..
6lowpan
9p	9p/net: fix memory leak in p9_client_create	2019-03-13 11:50:04 +01:00
802
8021q	vlan: conditional inclusion of FCoE hooks to match netdevice.h and bnx2x	2019-04-04 17:18:34 -07:00
appletalk	appletalk: Fix potential NULL pointer dereference in unregister_snap_client	2019-03-15 11:25:48 -07:00
atm	net: atm: Fix potential Spectre v1 vulnerabilities	2019-04-16 21:01:45 -07:00
ax25
batman-adv	batman-adv: Fix genl notification for throughput_override	2019-03-25 09:31:19 +01:00
bluetooth	Bluetooth: Check address length before reading address field	2019-04-12 10:25:03 -07:00
bpf	bpf: fix warning about using plain integer as NULL	2019-03-08 21:17:07 +01:00
bpfilter	bpfilter: re-add header search paths to tools include to fix build error	2019-02-23 13:34:40 -08:00
bridge	Merge git://git.kernel.org/pub/scm/linux/kernel/git/pablo/nf	2019-04-22 21:23:55 -07:00
caif	net: caif: use skb helpers instead of open-coding them	2019-02-17 11:01:17 -08:00
can
ceph	libceph: fix breakage caused by multipage bvecs	2019-03-25 22:28:07 +01:00
core	socket: fix compat SO_RCVTIMEO_NEW/SO_SNDTIMEO_NEW	2019-04-16 21:52:22 -07:00
dcb
dccp	dccp: Fix memleak in __feat_register_sp	2019-04-01 18:15:10 -07:00
decnet
dns_resolver
dsa	net: dsa: Implement flow_dissect callback for tag_qca	2019-03-28 16:57:19 -07:00
ethernet	net/ethernet: Add parse_protocol header_ops support	2019-02-22 12:55:31 -08:00
hsr	net/hsr: fix possible crash in add_timer()	2019-03-07 11:02:08 -08:00
ieee802154	net: remove unused struct inet_frag_queue.fragments field	2019-02-26 08:27:05 -08:00
ife
ipv4	tcp: add sanity tests in tcp_add_backlog()	2019-04-29 23:20:37 -04:00
ipv6	ipv6: invert flowlabel sharing check in process and user mode	2019-04-29 18:22:56 -04:00
iucv
kcm	kcm: switch order of device registration to fix a crash	2019-04-01 14:59:20 -07:00
key	af_key: unconditionally clone on broadcast	2019-02-12 10:36:42 +01:00
l2tp	l2tp: use rcu_dereference_sk_user_data() in l2tp_udp_encap_recv()	2019-04-26 11:18:23 -04:00
l3mdev
lapb
llc	llc: Check address length before reading address field	2019-04-12 10:25:03 -07:00
mac80211	mac80211: don't attempt to rename ERR_PTR() debugfs dirs	2019-04-23 13:47:05 +02:00
mac802154
mpls	mpls: Fix 6PE forwarding	2019-03-19 16:00:22 -07:00
ncsi	net/ncsi: handle overflow when incrementing mac address	2019-04-23 21:15:15 -07:00
netfilter	netfilter: fix nf_l4proto_log_invalid to log invalid packets	2019-04-22 10:38:50 +02:00
netlabel	netlabel: fix out-of-bounds memory accesses	2019-02-27 21:45:24 -08:00
netlink	genetlink: use idr_alloc_cyclic for family->id assignment	2019-04-26 11:59:58 -04:00
netrom	net: netrom: Fix error cleanup path of nr_proto_init	2019-04-11 13:59:49 -07:00
nfc	NFC: nci: Add some bounds checking in nci_hci_cmd_received()	2019-04-06 15:05:07 -07:00
nsh
openvswitch	openvswitch: fix flow actions reallocation	2019-03-28 17:15:44 -07:00
packet	net/packet: Set __GFP_NOWARN upon allocation in alloc_pg_vec	2019-03-20 10:46:50 -07:00
phonet	phonet: fix building with clang	2019-02-21 16:23:56 -08:00
psample
qrtr	mm: replace all open encodings for NUMA_NO_NODE	2019-03-05 21:07:14 -08:00
rds	net: rds: exchange of 8K and 1M pool	2019-04-24 12:07:08 -07:00
rfkill
rose	net/rose: fix unbound loop in rose_loopback_timer()	2019-04-24 14:39:26 -07:00
rxrpc	rxrpc: fix race condition in rxrpc_input_packet()	2019-04-24 14:05:09 -07:00
sched	sch_cake: Make sure we can write the IP header before changing DSCP bits	2019-04-04 10:55:59 -07:00
sctp	sctp: Check address length before reading address family	2019-04-12 10:25:03 -07:00
smc	net/smc: move unhash before release of clcsock	2019-04-11 11:04:08 -07:00
strparser	net: strparser: partially revert "strparser: Call skb_unclone conditionally"	2019-04-10 13:07:02 -07:00
sunrpc	Fix miscellaneous nfsd bugs, in NFSv4.1 callbacks, NFSv4.1	2019-04-23 13:40:55 -07:00
switchdev	switchdev: Remove unused transaction item queue	2019-03-01 21:35:19 -08:00
tipc	tipc: set sysctl_tipc_rmem and named_timeout right range	2019-04-16 21:32:02 -07:00
tls	net/tls: fix copy to fragments in reencrypt	2019-04-27 20:17:19 -04:00
unix	io_uring-2019-03-06	2019-03-08 14:48:40 -08:00
vmw_vsock	vsock/virtio: fix kernel panic from virtio_transport_reset_no_sock	2019-03-08 15:15:44 -08:00
wimax
wireless	cfg80211: Notify previous user request during self managed wiphy registration	2019-04-23 13:45:30 +02:00
x25	net/x25: reset state in x25_connect()	2019-03-11 15:40:14 -07:00
xdp	xsk: fix umem memory leak on cleanup	2019-03-16 01:27:51 +01:00
xfrm	xfrm: Fix inbound traffic via XFRM interfaces across network namespaces	2019-02-18 10:58:54 +01:00
compat.c	Merge branch 'timers-2038-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip	2019-03-05 14:08:26 -08:00
Kconfig	net: devlink: turn devlink into a built-in	2019-02-26 08:49:05 -08:00
Makefile	net: split out functions related to registering inflight socket files	2019-02-28 08:24:23 -07:00
socket.c	net: add documentation to socket.c	2019-03-15 15:29:47 -07:00
sysctl_net.c