Omar Sandoval c9eb55db84 btrfs: get rid of pointless wtag variable in async-thread.c ... Commit ac0c7cf8be ("btrfs: fix crash when tracepoint arguments are freed by wq callbacks") added a void pointer, wtag, which is passed into trace_btrfs_all_work_done() instead of the freed work item. This is silly for a few reasons: 1. The freed work item still has the same address. 2. work is still in scope after it's freed, so assigning wtag doesn't stop anyone from using it. 3. The tracepoint has always taken a void * argument, so assigning wtag doesn't actually make things any more type-safe. (Note that the original bug in commit bc074524e1 ("btrfs: prefix fsid to all trace events") was that the void * was implicitly casted when it was passed to btrfs_work_owner() in the trace point itself). Instead, let's add some clearer warnings as comments. Reviewed-by: Nikolay Borisov <nborisov@suse.com> Reviewed-by: Filipe Manana <fdmanana@suse.com> Signed-off-by: Omar Sandoval <osandov@fb.com> Reviewed-by: David Sterba <dsterba@suse.com> Signed-off-by: David Sterba <dsterba@suse.com>		2019-11-18 12:46:49 +01:00
..
events	btrfs: get rid of pointless wtag variable in async-thread.c	2019-11-18 12:46:49 +01:00
bpf_probe.h	bpf: add writable context for raw tracepoints	2019-04-26 19:04:19 -07:00
define_trace.h	tracing: introduce TRACE_EVENT_NOP()	2019-04-08 09:22:51 -04:00
perf.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net	2017-11-04 09:26:51 +09:00
syscall.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
trace_events.h	tracing: Prevent further users of zero size static arrays in trace events	2018-05-29 08:29:13 -04:00