mirror of
https://github.com/torvalds/linux.git
synced 2024-11-25 13:41:51 +00:00
18fdb6348c
The distributor and PMR/RPR can present different views of the interrupt priority space dependent upon the values of GICD_CTLR.DS and SCR_EL3.FIQ. Currently we treat the distributor's view of the priority space as canonical, and when the two differ we change the way we handle values in the PMR/RPR, using the `gic_nonsecure_priorities` static key to decide what to do. This approach works, but it's sub-optimal. When using pseudo-NMI we manipulate the distributor rarely, and we manipulate the PMR/RPR registers very frequently in code spread out throughout the kernel (e.g. local_irq_{save,restore}()). It would be nicer if we could use fixed values for the PMR/RPR, and dynamically choose the values programmed into the distributor. This patch changes the GICv3 driver and arm64 code accordingly. PMR values are chosen at compile time, and the GICv3 driver determines the appropriate values to program into the distributor at boot time. This removes the need for the `gic_nonsecure_priorities` static key and results in smaller and better generated code for saving/restoring the irqflags. Before this patch, local_irq_disable() compiles to: | 0000000000000000 <outlined_local_irq_disable>: | 0: d503201f nop | 4: d50343df msr daifset, #0x3 | 8: d65f03c0 ret | c: d503201f nop | 10: d2800c00 mov x0, #0x60 // #96 | 14: d5184600 msr icc_pmr_el1, x0 | 18: d65f03c0 ret | 1c: d2801400 mov x0, #0xa0 // #160 | 20: 17fffffd b 14 <outlined_local_irq_disable+0x14> After this patch, local_irq_disable() compiles to: | 0000000000000000 <outlined_local_irq_disable>: | 0: d503201f nop | 4: d50343df msr daifset, #0x3 | 8: d65f03c0 ret | c: d2801800 mov x0, #0xc0 // #192 | 10: d5184600 msr icc_pmr_el1, x0 | 14: d65f03c0 ret ... with 3 fewer instructions per call. For defconfig + CONFIG_PSEUDO_NMI=y, this results in a minor saving of ~4K of text, and will make it easier to make further improvements to the way we manipulate irqflags and DAIF bits. Signed-off-by: Mark Rutland <mark.rutland@arm.com> Cc: Alexandru Elisei <alexandru.elisei@arm.com> Cc: Marc Zyngier <maz@kernel.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Will Deacon <will@kernel.org> Reviewed-by: Marc Zyngier <maz@kernel.org> Tested-by: Marc Zyngier <maz@kernel.org> Link: https://lore.kernel.org/r/20240617111841.2529370-6-mark.rutland@arm.com Signed-off-by: Catalin Marinas <catalin.marinas@arm.com> Acked-by: Thomas Gleixner <tglx@linutronix.de>
193 lines
4.4 KiB
C
193 lines
4.4 KiB
C
/* SPDX-License-Identifier: GPL-2.0-only */
|
|
/*
|
|
* arch/arm64/include/asm/arch_gicv3.h
|
|
*
|
|
* Copyright (C) 2015 ARM Ltd.
|
|
*/
|
|
#ifndef __ASM_ARCH_GICV3_H
|
|
#define __ASM_ARCH_GICV3_H
|
|
|
|
#include <asm/sysreg.h>
|
|
|
|
#ifndef __ASSEMBLY__
|
|
|
|
#include <linux/irqchip/arm-gic-common.h>
|
|
#include <linux/stringify.h>
|
|
#include <asm/barrier.h>
|
|
#include <asm/cacheflush.h>
|
|
|
|
#define read_gicreg(r) read_sysreg_s(SYS_ ## r)
|
|
#define write_gicreg(v, r) write_sysreg_s(v, SYS_ ## r)
|
|
|
|
/*
|
|
* Low-level accessors
|
|
*
|
|
* These system registers are 32 bits, but we make sure that the compiler
|
|
* sets the GP register's most significant bits to 0 with an explicit cast.
|
|
*/
|
|
|
|
static __always_inline void gic_write_dir(u32 irq)
|
|
{
|
|
write_sysreg_s(irq, SYS_ICC_DIR_EL1);
|
|
isb();
|
|
}
|
|
|
|
static inline u64 gic_read_iar_common(void)
|
|
{
|
|
u64 irqstat;
|
|
|
|
irqstat = read_sysreg_s(SYS_ICC_IAR1_EL1);
|
|
dsb(sy);
|
|
return irqstat;
|
|
}
|
|
|
|
/*
|
|
* Cavium ThunderX erratum 23154
|
|
*
|
|
* The gicv3 of ThunderX requires a modified version for reading the
|
|
* IAR status to ensure data synchronization (access to icc_iar1_el1
|
|
* is not sync'ed before and after).
|
|
*
|
|
* Erratum 38545
|
|
*
|
|
* When a IAR register read races with a GIC interrupt RELEASE event,
|
|
* GIC-CPU interface could wrongly return a valid INTID to the CPU
|
|
* for an interrupt that is already released(non activated) instead of 0x3ff.
|
|
*
|
|
* To workaround this, return a valid interrupt ID only if there is a change
|
|
* in the active priority list after the IAR read.
|
|
*
|
|
* Common function used for both the workarounds since,
|
|
* 1. On Thunderx 88xx 1.x both erratas are applicable.
|
|
* 2. Having extra nops doesn't add any side effects for Silicons where
|
|
* erratum 23154 is not applicable.
|
|
*/
|
|
static inline u64 gic_read_iar_cavium_thunderx(void)
|
|
{
|
|
u64 irqstat, apr;
|
|
|
|
apr = read_sysreg_s(SYS_ICC_AP1R0_EL1);
|
|
nops(8);
|
|
irqstat = read_sysreg_s(SYS_ICC_IAR1_EL1);
|
|
nops(4);
|
|
mb();
|
|
|
|
/* Max priority groups implemented is only 32 */
|
|
if (likely(apr != read_sysreg_s(SYS_ICC_AP1R0_EL1)))
|
|
return irqstat;
|
|
|
|
return 0x3ff;
|
|
}
|
|
|
|
static u64 __maybe_unused gic_read_iar(void)
|
|
{
|
|
if (alternative_has_cap_unlikely(ARM64_WORKAROUND_CAVIUM_23154))
|
|
return gic_read_iar_cavium_thunderx();
|
|
else
|
|
return gic_read_iar_common();
|
|
}
|
|
|
|
static inline void gic_write_ctlr(u32 val)
|
|
{
|
|
write_sysreg_s(val, SYS_ICC_CTLR_EL1);
|
|
isb();
|
|
}
|
|
|
|
static inline u32 gic_read_ctlr(void)
|
|
{
|
|
return read_sysreg_s(SYS_ICC_CTLR_EL1);
|
|
}
|
|
|
|
static inline void gic_write_grpen1(u32 val)
|
|
{
|
|
write_sysreg_s(val, SYS_ICC_IGRPEN1_EL1);
|
|
isb();
|
|
}
|
|
|
|
static inline void gic_write_sgi1r(u64 val)
|
|
{
|
|
write_sysreg_s(val, SYS_ICC_SGI1R_EL1);
|
|
}
|
|
|
|
static inline u32 gic_read_sre(void)
|
|
{
|
|
return read_sysreg_s(SYS_ICC_SRE_EL1);
|
|
}
|
|
|
|
static inline void gic_write_sre(u32 val)
|
|
{
|
|
write_sysreg_s(val, SYS_ICC_SRE_EL1);
|
|
isb();
|
|
}
|
|
|
|
static inline void gic_write_bpr1(u32 val)
|
|
{
|
|
write_sysreg_s(val, SYS_ICC_BPR1_EL1);
|
|
}
|
|
|
|
static inline u32 gic_read_pmr(void)
|
|
{
|
|
return read_sysreg_s(SYS_ICC_PMR_EL1);
|
|
}
|
|
|
|
static __always_inline void gic_write_pmr(u32 val)
|
|
{
|
|
write_sysreg_s(val, SYS_ICC_PMR_EL1);
|
|
}
|
|
|
|
static inline u32 gic_read_rpr(void)
|
|
{
|
|
return read_sysreg_s(SYS_ICC_RPR_EL1);
|
|
}
|
|
|
|
#define gic_read_typer(c) readq_relaxed(c)
|
|
#define gic_write_irouter(v, c) writeq_relaxed(v, c)
|
|
#define gic_read_lpir(c) readq_relaxed(c)
|
|
#define gic_write_lpir(v, c) writeq_relaxed(v, c)
|
|
|
|
#define gic_flush_dcache_to_poc(a,l) \
|
|
dcache_clean_inval_poc((unsigned long)(a), (unsigned long)(a)+(l))
|
|
|
|
#define gits_read_baser(c) readq_relaxed(c)
|
|
#define gits_write_baser(v, c) writeq_relaxed(v, c)
|
|
|
|
#define gits_read_cbaser(c) readq_relaxed(c)
|
|
#define gits_write_cbaser(v, c) writeq_relaxed(v, c)
|
|
|
|
#define gits_write_cwriter(v, c) writeq_relaxed(v, c)
|
|
|
|
#define gicr_read_propbaser(c) readq_relaxed(c)
|
|
#define gicr_write_propbaser(v, c) writeq_relaxed(v, c)
|
|
|
|
#define gicr_write_pendbaser(v, c) writeq_relaxed(v, c)
|
|
#define gicr_read_pendbaser(c) readq_relaxed(c)
|
|
|
|
#define gicr_write_vpropbaser(v, c) writeq_relaxed(v, c)
|
|
#define gicr_read_vpropbaser(c) readq_relaxed(c)
|
|
|
|
#define gicr_write_vpendbaser(v, c) writeq_relaxed(v, c)
|
|
#define gicr_read_vpendbaser(c) readq_relaxed(c)
|
|
|
|
static inline bool gic_prio_masking_enabled(void)
|
|
{
|
|
return system_uses_irq_prio_masking();
|
|
}
|
|
|
|
static inline void gic_pmr_mask_irqs(void)
|
|
{
|
|
gic_write_pmr(GIC_PRIO_IRQOFF);
|
|
}
|
|
|
|
static inline void gic_arch_enable_irqs(void)
|
|
{
|
|
asm volatile ("msr daifclr, #3" : : : "memory");
|
|
}
|
|
|
|
static inline bool gic_has_relaxed_pmr_sync(void)
|
|
{
|
|
return cpus_have_cap(ARM64_HAS_GIC_PRIO_RELAXED_SYNC);
|
|
}
|
|
|
|
#endif /* __ASSEMBLY__ */
|
|
#endif /* __ASM_ARCH_GICV3_H */
|