mirror of
https://github.com/torvalds/linux.git
synced 2024-12-02 09:01:34 +00:00
91a29af413
The gpiolib is unique in the way it uses intermediate fwspecs when feeding an interrupt specifier to the parent domain, as it relies on the populate_parent_alloc_arg() callback to perform a dynamic allocation. This is pretty inefficient (we free the structure almost immediately), and the only reason this isn't a stack allocation is that our ThunderX friend uses MSIs rather than a FW-constructed structure. Let's solve it by providing a new type composed of the union of a struct irq_fwspec and a msi_info_t, which satisfies both requirements. This allows us to use a stack allocation, and we can move the handful of users to this new scheme. Also perform some additional cleanup, such as getting rid of the stub versions of the irq_domain_translate_*cell helpers, which are never used when CONFIG_IRQ_DOMAIN_HIERARCHY isn't selected. Tested on a Tegra186. Reviewed-by: Linus Walleij <linus.walleij@linaro.org> Signed-off-by: Marc Zyngier <maz@kernel.org> Cc: Daniel Palmer <daniel@thingy.jp> Cc: Romain Perier <romain.perier@gmail.com> Cc: Bartosz Golaszewski <brgl@bgdev.pl> Cc: Thierry Reding <thierry.reding@gmail.com> Cc: Jonathan Hunter <jonathanh@nvidia.com> Cc: Robert Richter <rric@kernel.org> Cc: Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp> Cc: Andy Gross <agross@kernel.org> Cc: Bjorn Andersson <bjorn.andersson@linaro.org> Acked-by: Bartosz Golaszewski <brgl@bgdev.pl> Link: https://lore.kernel.org/r/20220707182314.66610-2-prabhakar.mahadev-lad.rj@bp.renesas.com
205 lines
5.0 KiB
C
205 lines
5.0 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* Toshiba Visconti GPIO Support
|
|
*
|
|
* (C) Copyright 2020 Toshiba Electronic Devices & Storage Corporation
|
|
* (C) Copyright 2020 TOSHIBA CORPORATION
|
|
*
|
|
* Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>
|
|
*/
|
|
|
|
#include <linux/gpio/driver.h>
|
|
#include <linux/init.h>
|
|
#include <linux/interrupt.h>
|
|
#include <linux/module.h>
|
|
#include <linux/io.h>
|
|
#include <linux/of_irq.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/bitops.h>
|
|
|
|
/* register offset */
|
|
#define GPIO_DIR 0x00
|
|
#define GPIO_IDATA 0x08
|
|
#define GPIO_ODATA 0x10
|
|
#define GPIO_OSET 0x18
|
|
#define GPIO_OCLR 0x20
|
|
#define GPIO_INTMODE 0x30
|
|
|
|
#define BASE_HW_IRQ 24
|
|
|
|
struct visconti_gpio {
|
|
void __iomem *base;
|
|
spinlock_t lock; /* protect gpio register */
|
|
struct gpio_chip gpio_chip;
|
|
struct irq_chip irq_chip;
|
|
};
|
|
|
|
static int visconti_gpio_irq_set_type(struct irq_data *d, unsigned int type)
|
|
{
|
|
struct gpio_chip *gc = irq_data_get_irq_chip_data(d);
|
|
struct visconti_gpio *priv = gpiochip_get_data(gc);
|
|
u32 offset = irqd_to_hwirq(d);
|
|
u32 bit = BIT(offset);
|
|
u32 intc_type = IRQ_TYPE_EDGE_RISING;
|
|
u32 intmode, odata;
|
|
int ret = 0;
|
|
unsigned long flags;
|
|
|
|
spin_lock_irqsave(&priv->lock, flags);
|
|
|
|
odata = readl(priv->base + GPIO_ODATA);
|
|
intmode = readl(priv->base + GPIO_INTMODE);
|
|
|
|
switch (type) {
|
|
case IRQ_TYPE_EDGE_RISING:
|
|
odata &= ~bit;
|
|
intmode &= ~bit;
|
|
break;
|
|
case IRQ_TYPE_EDGE_FALLING:
|
|
odata |= bit;
|
|
intmode &= ~bit;
|
|
break;
|
|
case IRQ_TYPE_EDGE_BOTH:
|
|
intmode |= bit;
|
|
break;
|
|
case IRQ_TYPE_LEVEL_HIGH:
|
|
intc_type = IRQ_TYPE_LEVEL_HIGH;
|
|
odata &= ~bit;
|
|
intmode &= ~bit;
|
|
break;
|
|
case IRQ_TYPE_LEVEL_LOW:
|
|
intc_type = IRQ_TYPE_LEVEL_HIGH;
|
|
odata |= bit;
|
|
intmode &= ~bit;
|
|
break;
|
|
default:
|
|
ret = -EINVAL;
|
|
goto err;
|
|
}
|
|
|
|
writel(odata, priv->base + GPIO_ODATA);
|
|
writel(intmode, priv->base + GPIO_INTMODE);
|
|
irq_set_irq_type(offset, intc_type);
|
|
|
|
ret = irq_chip_set_type_parent(d, type);
|
|
err:
|
|
spin_unlock_irqrestore(&priv->lock, flags);
|
|
return ret;
|
|
}
|
|
|
|
static int visconti_gpio_child_to_parent_hwirq(struct gpio_chip *gc,
|
|
unsigned int child,
|
|
unsigned int child_type,
|
|
unsigned int *parent,
|
|
unsigned int *parent_type)
|
|
{
|
|
/* Interrupts 0..15 mapped to interrupts 24..39 on the GIC */
|
|
if (child < 16) {
|
|
/* All these interrupts are level high in the CPU */
|
|
*parent_type = IRQ_TYPE_LEVEL_HIGH;
|
|
*parent = child + BASE_HW_IRQ;
|
|
return 0;
|
|
}
|
|
return -EINVAL;
|
|
}
|
|
|
|
static int visconti_gpio_populate_parent_fwspec(struct gpio_chip *chip,
|
|
union gpio_irq_fwspec *gfwspec,
|
|
unsigned int parent_hwirq,
|
|
unsigned int parent_type)
|
|
{
|
|
struct irq_fwspec *fwspec = &gfwspec->fwspec;
|
|
|
|
fwspec->fwnode = chip->irq.parent_domain->fwnode;
|
|
fwspec->param_count = 3;
|
|
fwspec->param[0] = 0;
|
|
fwspec->param[1] = parent_hwirq;
|
|
fwspec->param[2] = parent_type;
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int visconti_gpio_probe(struct platform_device *pdev)
|
|
{
|
|
struct device *dev = &pdev->dev;
|
|
struct visconti_gpio *priv;
|
|
struct irq_chip *irq_chip;
|
|
struct gpio_irq_chip *girq;
|
|
struct irq_domain *parent;
|
|
struct device_node *irq_parent;
|
|
int ret;
|
|
|
|
priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
|
|
if (!priv)
|
|
return -ENOMEM;
|
|
|
|
spin_lock_init(&priv->lock);
|
|
|
|
priv->base = devm_platform_ioremap_resource(pdev, 0);
|
|
if (IS_ERR(priv->base))
|
|
return PTR_ERR(priv->base);
|
|
|
|
irq_parent = of_irq_find_parent(dev->of_node);
|
|
if (!irq_parent) {
|
|
dev_err(dev, "No IRQ parent node\n");
|
|
return -ENODEV;
|
|
}
|
|
|
|
parent = irq_find_host(irq_parent);
|
|
of_node_put(irq_parent);
|
|
if (!parent) {
|
|
dev_err(dev, "No IRQ parent domain\n");
|
|
return -ENODEV;
|
|
}
|
|
|
|
ret = bgpio_init(&priv->gpio_chip, dev, 4,
|
|
priv->base + GPIO_IDATA,
|
|
priv->base + GPIO_OSET,
|
|
priv->base + GPIO_OCLR,
|
|
priv->base + GPIO_DIR,
|
|
NULL,
|
|
0);
|
|
if (ret) {
|
|
dev_err(dev, "unable to init generic GPIO\n");
|
|
return ret;
|
|
}
|
|
|
|
irq_chip = &priv->irq_chip;
|
|
irq_chip->name = dev_name(dev);
|
|
irq_chip->irq_mask = irq_chip_mask_parent;
|
|
irq_chip->irq_unmask = irq_chip_unmask_parent;
|
|
irq_chip->irq_eoi = irq_chip_eoi_parent;
|
|
irq_chip->irq_set_type = visconti_gpio_irq_set_type;
|
|
irq_chip->flags = IRQCHIP_SET_TYPE_MASKED | IRQCHIP_MASK_ON_SUSPEND;
|
|
|
|
girq = &priv->gpio_chip.irq;
|
|
girq->chip = irq_chip;
|
|
girq->fwnode = of_node_to_fwnode(dev->of_node);
|
|
girq->parent_domain = parent;
|
|
girq->child_to_parent_hwirq = visconti_gpio_child_to_parent_hwirq;
|
|
girq->populate_parent_alloc_arg = visconti_gpio_populate_parent_fwspec;
|
|
girq->default_type = IRQ_TYPE_NONE;
|
|
girq->handler = handle_level_irq;
|
|
|
|
return devm_gpiochip_add_data(dev, &priv->gpio_chip, priv);
|
|
}
|
|
|
|
static const struct of_device_id visconti_gpio_of_match[] = {
|
|
{ .compatible = "toshiba,gpio-tmpv7708", },
|
|
{ /* end of table */ }
|
|
};
|
|
MODULE_DEVICE_TABLE(of, visconti_gpio_of_match);
|
|
|
|
static struct platform_driver visconti_gpio_driver = {
|
|
.probe = visconti_gpio_probe,
|
|
.driver = {
|
|
.name = "visconti_gpio",
|
|
.of_match_table = of_match_ptr(visconti_gpio_of_match),
|
|
}
|
|
};
|
|
module_platform_driver(visconti_gpio_driver);
|
|
|
|
MODULE_AUTHOR("Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@toshiba.co.jp>");
|
|
MODULE_DESCRIPTION("Toshiba Visconti GPIO Driver");
|
|
MODULE_LICENSE("GPL v2");
|