mirror of
https://github.com/torvalds/linux.git
synced 2024-12-30 14:52:05 +00:00
d7dba6be0f
The commita9ddb575d6("dmaengine: dw_dmac: Enhance device tree support") introduces is_private property in uncertain understanding what does it mean. First of all, documentation defines DMA_PRIVATE capability as Documentation/crypto/async-tx-api.txt: The DMA_PRIVATE capability flag is used to tag dma devices that should not be used by the general-purpose allocator. It can be set at initialization time if it is known that a channel will always be private. Alternatively, it is set when dma_request_channel() finds an unused "public" channel. A couple caveats to note when implementing a driver and consumer: 1/ Once a channel has been privately allocated it will no longer be considered by the general-purpose allocator even after a call to dma_release_channel(). 2/ Since capabilities are specified at the device level a dma_device with multiple channels will either have all channels public, or all channels private. Documentation/driver-api/dmaengine/provider.rst: - DMA_PRIVATE The devices only supports slave transfers, and as such isn't available for async transfers. The capability had been introduced by the commit59b5ec2144("dmaengine: introduce dma_request_channel and private channels") and some code didn't changed from that times ever. Taking into consideration above and the fact that on all known platforms Synopsys DesignWare DMA engine is attached to serve slave transfers, the DMA_PRIVATE capability must be enabled for this device unconditionally. Otherwise, as rightfully noticed in drivers/dma/at_xdmac.c: /* * Without DMA_PRIVATE the driver is not able to allocate more than * one channel, second allocation fails in private_candidate. */ because of of a caveats mentioned in above documentation excerpts. So, remove conditional around DMA_PRIVATE followed by removal leftovers. If someone wonders, DMA_PRIVATE can be not used if and only if the all channels of the DMA controller are supposed to serve memory-to-memory like operations. For example, EP93xx has two controllers, one of which can only perform memory-to-memory transfers Note, this change doesn't affect dmatest to be able to test such controllers. Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> (maintainer:SERIAL DRIVERS) Cc: Dan Williams <dan.j.williams@intel.com> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Vinod Koul <vkoul@kernel.org>
70 lines
2.2 KiB
Plaintext
70 lines
2.2 KiB
Plaintext
* Synopsys Designware DMA Controller
|
|
|
|
Required properties:
|
|
- compatible: "snps,dma-spear1340"
|
|
- reg: Address range of the DMAC registers
|
|
- interrupt: Should contain the DMAC interrupt number
|
|
- dma-channels: Number of channels supported by hardware
|
|
- dma-requests: Number of DMA request lines supported, up to 16
|
|
- dma-masters: Number of AHB masters supported by the controller
|
|
- #dma-cells: must be <3>
|
|
- chan_allocation_order: order of allocation of channel, 0 (default): ascending,
|
|
1: descending
|
|
- chan_priority: priority of channels. 0 (default): increase from chan 0->n, 1:
|
|
increase from chan n->0
|
|
- block_size: Maximum block size supported by the controller
|
|
- data-width: Maximum data width supported by hardware per AHB master
|
|
(in bytes, power of 2)
|
|
|
|
|
|
Deprecated properties:
|
|
- data_width: Maximum data width supported by hardware per AHB master
|
|
(0 - 8bits, 1 - 16bits, ..., 5 - 256bits)
|
|
|
|
|
|
Optional properties:
|
|
- multi-block: Multi block transfers supported by hardware. Array property with
|
|
one cell per channel. 0: not supported, 1 (default): supported.
|
|
- snps,dma-protection-control: AHB HPROT[3:1] protection setting.
|
|
The default value is 0 (for non-cacheable, non-buffered,
|
|
unprivileged data access).
|
|
Refer to include/dt-bindings/dma/dw-dmac.h for possible values.
|
|
|
|
Example:
|
|
|
|
dmahost: dma@fc000000 {
|
|
compatible = "snps,dma-spear1340";
|
|
reg = <0xfc000000 0x1000>;
|
|
interrupt-parent = <&vic1>;
|
|
interrupts = <12>;
|
|
|
|
dma-channels = <8>;
|
|
dma-requests = <16>;
|
|
dma-masters = <2>;
|
|
#dma-cells = <3>;
|
|
chan_allocation_order = <1>;
|
|
chan_priority = <1>;
|
|
block_size = <0xfff>;
|
|
data-width = <8 8>;
|
|
};
|
|
|
|
DMA clients connected to the Designware DMA controller must use the format
|
|
described in the dma.txt file, using a four-cell specifier for each channel.
|
|
The four cells in order are:
|
|
|
|
1. A phandle pointing to the DMA controller
|
|
2. The DMA request line number
|
|
3. Memory master for transfers on allocated channel
|
|
4. Peripheral master for transfers on allocated channel
|
|
|
|
Example:
|
|
|
|
serial@e0000000 {
|
|
compatible = "arm,pl011", "arm,primecell";
|
|
reg = <0xe0000000 0x1000>;
|
|
interrupts = <0 35 0x4>;
|
|
dmas = <&dmahost 12 0 1>,
|
|
<&dmahost 13 1 0>;
|
|
dma-names = "rx", "rx";
|
|
};
|