linux/drivers/char/ip2
Arnd Bergmann 613655fa39 drivers: autoconvert trivial BKL users to private mutex
All these files use the big kernel lock in a trivial
way to serialize their private file operations,
typically resulting from an earlier semi-automatic
pushdown from VFS.

None of these drivers appears to want to lock against
other code, and they all use the BKL as the top-level
lock in their file operations, meaning that there
is no lock-order inversion problem.

Consequently, we can remove the BKL completely,
replacing it with a per-file mutex in every case.
Using a scripted approach means we can avoid
typos.

These drivers do not seem to be under active
maintainance from my brief investigation. Apologies
to those maintainers that I have missed.

file=$1
name=$2
if grep -q lock_kernel ${file} ; then
    if grep -q 'include.*linux.mutex.h' ${file} ; then
            sed -i '/include.*<linux\/smp_lock.h>/d' ${file}
    else
            sed -i 's/include.*<linux\/smp_lock.h>.*$/include <linux\/mutex.h>/g' ${file}
    fi
    sed -i ${file} \
        -e "/^#include.*linux.mutex.h/,$ {
                1,/^\(static\|int\|long\)/ {
                     /^\(static\|int\|long\)/istatic DEFINE_MUTEX(${name}_mutex);

} }"  \
    -e "s/\(un\)*lock_kernel\>[ ]*()/mutex_\1lock(\&${name}_mutex)/g" \
    -e '/[      ]*cycle_kernel_lock();/d'
else
    sed -i -e '/include.*\<smp_lock.h\>/d' ${file}  \
                -e '/cycle_kernel_lock()/d'
fi

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
2010-10-05 15:01:04 +02:00
..
i2cmd.c
i2cmd.h [PATCH] char: ip2 remove broken macro 2006-12-07 08:39:43 -08:00
i2ellis.c ip2: init/deinit cleanup 2008-10-13 09:51:39 -07:00
i2ellis.h ip2: init/deinit cleanup 2008-10-13 09:51:39 -07:00
i2hw.h tree-wide: Assorted spelling fixes 2010-02-09 11:13:56 +01:00
i2lib.c tty: rewrite the ldisc locking 2009-06-11 08:51:01 -07:00
i2lib.h [PATCH] i2Output always takes kernel data now 2006-10-11 11:17:07 -07:00
i2pack.h
ip2.h
ip2ioctl.h
ip2main.c drivers: autoconvert trivial BKL users to private mutex 2010-10-05 15:01:04 +02:00
ip2trace.h
ip2types.h
Makefile Char: merge ip2main and ip2base 2008-10-13 09:51:39 -07:00