mirror of
https://github.com/torvalds/linux.git
synced 2024-11-25 05:32:00 +00:00
bea1bfd5b7
There are dimm and csrow devices linked to the mci device esp. to show up in sysfs. It must be granted that children devices are removed before its mci parent. Thus, the release functions must be called in the correct order and may not miss any child before releasing its parent. In the current implementation this is only granted by the correct order of release functions. A much better approach is to use put_device() that releases the device only after all users are gone. It is the recommended way to release a device and free its memory. The function uses the device's refcount and only frees it if there are no users of it anymore such as children. So implement a mci_release() function to remove mci devices, use put_device() to free them and early initialize the mci device right after its struct has been allocated. Change the release function so that it can be universally used no matter if the device is registered or not. Since subsequent dimm and csrow sysfs links are implemented as children devices, their refcounts will keep the parent mci device from being removed as long as sysfs entries exist and until all users have been unregistered in edac_remove_sysfs_mci_device(). Remove edac_unregister_sysfs() and merge mci sysfs removal into edac_remove_sysfs_mci_device(). There is only a single instance now that removes the sysfs entries. The function can now be used in the error paths for cleanup. Also, create device release functions for all involved devices (dev->release), remove device_type release functions (dev_type-> release) and also use dev->init_name instead of dev_set_name(). [ bp: Massage commit message and comments. ] Signed-off-by: Robert Richter <rrichter@marvell.com> Signed-off-by: Borislav Petkov <bp@suse.de> Acked-by: Aristeu Rozanski <aris@redhat.com> Link: https://lkml.kernel.org/r/20200212120340.4764-5-rrichter@marvell.com
131 lines
4.7 KiB
C
131 lines
4.7 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
|
|
/*
|
|
* edac_module.h
|
|
*
|
|
* For defining functions/data for within the EDAC_CORE module only
|
|
*
|
|
* written by doug thompson <norsk5@xmission.h>
|
|
*/
|
|
|
|
#ifndef __EDAC_MODULE_H__
|
|
#define __EDAC_MODULE_H__
|
|
|
|
#include "edac_mc.h"
|
|
#include "edac_pci.h"
|
|
#include "edac_device.h"
|
|
|
|
/*
|
|
* INTERNAL EDAC MODULE:
|
|
* EDAC memory controller sysfs create/remove functions
|
|
* and setup/teardown functions
|
|
*
|
|
* edac_mc objects
|
|
*/
|
|
/* on edac_mc_sysfs.c */
|
|
int edac_mc_sysfs_init(void);
|
|
void edac_mc_sysfs_exit(void);
|
|
extern int edac_create_sysfs_mci_device(struct mem_ctl_info *mci,
|
|
const struct attribute_group **groups);
|
|
extern void edac_remove_sysfs_mci_device(struct mem_ctl_info *mci);
|
|
extern int edac_get_log_ue(void);
|
|
extern int edac_get_log_ce(void);
|
|
extern int edac_get_panic_on_ue(void);
|
|
extern int edac_mc_get_log_ue(void);
|
|
extern int edac_mc_get_log_ce(void);
|
|
extern int edac_mc_get_panic_on_ue(void);
|
|
extern int edac_get_poll_msec(void);
|
|
extern unsigned int edac_mc_get_poll_msec(void);
|
|
|
|
unsigned edac_dimm_info_location(struct dimm_info *dimm, char *buf,
|
|
unsigned len);
|
|
|
|
/* on edac_device.c */
|
|
extern int edac_device_register_sysfs_main_kobj(
|
|
struct edac_device_ctl_info *edac_dev);
|
|
extern void edac_device_unregister_sysfs_main_kobj(
|
|
struct edac_device_ctl_info *edac_dev);
|
|
extern int edac_device_create_sysfs(struct edac_device_ctl_info *edac_dev);
|
|
extern void edac_device_remove_sysfs(struct edac_device_ctl_info *edac_dev);
|
|
|
|
/* edac core workqueue: single CPU mode */
|
|
int edac_workqueue_setup(void);
|
|
void edac_workqueue_teardown(void);
|
|
bool edac_queue_work(struct delayed_work *work, unsigned long delay);
|
|
bool edac_stop_work(struct delayed_work *work);
|
|
bool edac_mod_work(struct delayed_work *work, unsigned long delay);
|
|
|
|
extern void edac_device_reset_delay_period(struct edac_device_ctl_info
|
|
*edac_dev, unsigned long value);
|
|
extern void edac_mc_reset_delay_period(unsigned long value);
|
|
|
|
extern void *edac_align_ptr(void **p, unsigned size, int n_elems);
|
|
|
|
/*
|
|
* EDAC debugfs functions
|
|
*/
|
|
|
|
#define edac_debugfs_remove_recursive debugfs_remove_recursive
|
|
#define edac_debugfs_remove debugfs_remove
|
|
#ifdef CONFIG_EDAC_DEBUG
|
|
void edac_debugfs_init(void);
|
|
void edac_debugfs_exit(void);
|
|
void edac_create_debugfs_nodes(struct mem_ctl_info *mci);
|
|
struct dentry *edac_debugfs_create_dir(const char *dirname);
|
|
struct dentry *
|
|
edac_debugfs_create_dir_at(const char *dirname, struct dentry *parent);
|
|
struct dentry *
|
|
edac_debugfs_create_file(const char *name, umode_t mode, struct dentry *parent,
|
|
void *data, const struct file_operations *fops);
|
|
void edac_debugfs_create_x8(const char *name, umode_t mode,
|
|
struct dentry *parent, u8 *value);
|
|
void edac_debugfs_create_x16(const char *name, umode_t mode,
|
|
struct dentry *parent, u16 *value);
|
|
void edac_debugfs_create_x32(const char *name, umode_t mode,
|
|
struct dentry *parent, u32 *value);
|
|
#else
|
|
static inline void edac_debugfs_init(void) { }
|
|
static inline void edac_debugfs_exit(void) { }
|
|
static inline void edac_create_debugfs_nodes(struct mem_ctl_info *mci) { }
|
|
static inline struct dentry *edac_debugfs_create_dir(const char *dirname) { return NULL; }
|
|
static inline struct dentry *
|
|
edac_debugfs_create_dir_at(const char *dirname, struct dentry *parent) { return NULL; }
|
|
static inline struct dentry *
|
|
edac_debugfs_create_file(const char *name, umode_t mode, struct dentry *parent,
|
|
void *data, const struct file_operations *fops) { return NULL; }
|
|
static inline void edac_debugfs_create_x8(const char *name, umode_t mode,
|
|
struct dentry *parent, u8 *value) { }
|
|
static inline void edac_debugfs_create_x16(const char *name, umode_t mode,
|
|
struct dentry *parent, u16 *value) { }
|
|
static inline void edac_debugfs_create_x32(const char *name, umode_t mode,
|
|
struct dentry *parent, u32 *value) { }
|
|
#endif
|
|
|
|
/*
|
|
* EDAC PCI functions
|
|
*/
|
|
#ifdef CONFIG_PCI
|
|
extern void edac_pci_do_parity_check(void);
|
|
extern void edac_pci_clear_parity_errors(void);
|
|
extern int edac_sysfs_pci_setup(void);
|
|
extern void edac_sysfs_pci_teardown(void);
|
|
extern int edac_pci_get_check_errors(void);
|
|
extern int edac_pci_get_poll_msec(void);
|
|
extern void edac_pci_remove_sysfs(struct edac_pci_ctl_info *pci);
|
|
extern void edac_pci_handle_pe(struct edac_pci_ctl_info *pci, const char *msg);
|
|
extern void edac_pci_handle_npe(struct edac_pci_ctl_info *pci,
|
|
const char *msg);
|
|
#else /* CONFIG_PCI */
|
|
/* pre-process these away */
|
|
#define edac_pci_do_parity_check()
|
|
#define edac_pci_clear_parity_errors()
|
|
#define edac_sysfs_pci_setup() (0)
|
|
#define edac_sysfs_pci_teardown()
|
|
#define edac_pci_get_check_errors()
|
|
#define edac_pci_get_poll_msec()
|
|
#define edac_pci_handle_pe()
|
|
#define edac_pci_handle_npe()
|
|
#endif /* CONFIG_PCI */
|
|
|
|
#endif /* __EDAC_MODULE_H__ */
|