linux/net/sunrpc/xprtrdma
NeilBrown 948f072ada SUNRPC: always free ctxt when freeing deferred request
Since the ->xprt_ctxt pointer was added to svc_deferred_req, it has not
been sufficient to use kfree() to free a deferred request.  We may need
to free the ctxt as well.

As freeing the ctxt is all that ->xpo_release_rqst() does, we repurpose
it to explicit do that even when the ctxt is not stored in an rqst.
So we now have ->xpo_release_ctxt() which is given an xprt and a ctxt,
which may have been taken either from an rqst or from a dreq.  The
caller is now responsible for clearing that pointer after the call to
->xpo_release_ctxt.

We also clear dr->xprt_ctxt when the ctxt is moved into a new rqst when
revisiting a deferred request.  This ensures there is only one pointer
to the ctxt, so the risk of double freeing in future is reduced.  The
new code in svc_xprt_release which releases both the ctxt and any
rq_deferred depends on this.

Fixes: 773f91b2cf ("SUNRPC: Fix NFSD's request deferral on RDMA transports")
Signed-off-by: NeilBrown <neilb@suse.de>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
2023-05-14 15:55:02 -04:00
..
backchannel.c xprtrdma: Clean up synopsis of rpcrdma_req_create() 2022-10-05 15:47:16 -04:00
frwr_ops.c xprtrdma: Fix uninitialized variable 2022-10-05 15:47:17 -04:00
Makefile svcrdma: Add a "parsed chunk list" data structure 2020-11-30 13:00:22 -05:00
module.c SUNRPC: xprt_load_transport() needs to support the netid "rdma6" 2020-12-02 14:05:52 -05:00
rpc_rdma.c xprtrdma: treat all calls not a bcall when bc_serv is NULL 2022-05-31 17:09:30 -04:00
svc_rdma_backchannel.c svcrdma: Clean up RPCRDMA_DEF_GFP 2022-10-05 15:47:16 -04:00
svc_rdma_pcl.c svcrdma: Add a "parsed chunk list" data structure 2020-11-30 13:00:22 -05:00
svc_rdma_recvfrom.c SUNRPC: always free ctxt when freeing deferred request 2023-05-14 15:55:02 -04:00
svc_rdma_rw.c SUNRPC: Trap RDMA segment overflows 2022-06-02 13:05:58 -04:00
svc_rdma_sendto.c svcrdma: Split the svcrdma_wc_send() tracepoint 2021-10-04 15:40:15 -04:00
svc_rdma_transport.c SUNRPC: always free ctxt when freeing deferred request 2023-05-14 15:55:02 -04:00
svc_rdma.c sunrpc: simplify two-level sysctl registration for svcrdma_parm_table 2023-04-26 09:05:01 -04:00
transport.c SUNRPC: Replace the use of the xprtiod WQ in rpcrdma 2022-10-05 15:47:16 -04:00
verbs.c xprtrdma: Fix regbuf data not freed in rpcrdma_req_create() 2022-12-06 12:19:48 -05:00
xprt_rdma.h xprtrdma: MR-related memory allocation should be allowed to fail 2022-10-05 15:47:16 -04:00