mirror of
https://github.com/torvalds/linux.git
synced 2024-11-23 12:42:02 +00:00
14caefcf98
If you call listen() and accept() on an already connect()ed rose socket, accept() can successfully connect. This is because when the peer socket sends data to sendmsg, the skb with its own sk stored in the connected socket's sk->sk_receive_queue is connected, and rose_accept() dequeues the skb waiting in the sk->sk_receive_queue. This creates a child socket with the sk of the parent rose socket, which can cause confusion. Fix rose_listen() to return -EINVAL if the socket has already been successfully connected, and add lock_sock to prevent this issue. Signed-off-by: Hyunwoo Kim <v4bel@theori.io> Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com> Link: https://lore.kernel.org/r/20230125105944.GA133314@ubuntu Signed-off-by: Jakub Kicinski <kuba@kernel.org> |
||
|---|---|---|
| .. | ||
| af_rose.c | ||
| Makefile | ||
| rose_dev.c | ||
| rose_in.c | ||
| rose_link.c | ||
| rose_loopback.c | ||
| rose_out.c | ||
| rose_route.c | ||
| rose_subr.c | ||
| rose_timer.c | ||
| sysctl_net_rose.c | ||