mirror of
https://github.com/torvalds/linux.git
synced 2024-12-30 14:52:05 +00:00
970122fdf4
Accidentally a side effect is involved by commit 6e967adf7(tipc: relocate common functions from media to bearer). Now tipc stack handler of receiving packets from netdevices as well as netdevice notification handler are registered when bearer is enabled rather than tipc module initialization stage, but the two handlers are both unregistered in tipc module exit phase. If tipc module is inserted and then immediately removed, the following warning message will appear: "dev_remove_pack: ffffffffa0380940 not found" This is because in module insertion stage tipc stack packet handler is not registered at all, but in module exit phase dev_remove_pack() needs to remove it. Of course, dev_remove_pack() cannot find tipc protocol handler from the kernel protocol handler list so that the warning message is printed out. But if registering the two handlers is adjusted from enabling bearer phase into inserting module stage, the warning message will be eliminated. Due to this change, tipc_core_start_net() and tipc_core_stop_net() can be deleted as well. Reported-by: Wang Weidong <wangweidong1@huawei.com> Cc: Jon Maloy <jon.maloy@ericsson.com> Cc: Erik Hugne <erik.hugne@ericsson.com> Signed-off-by: Ying Xue <ying.xue@windriver.com> Reviewed-by: Paul Gortmaker <paul.gortmaker@windriver.com> Signed-off-by: David S. Miller <davem@davemloft.net>
198 lines
5.0 KiB
C
198 lines
5.0 KiB
C
/*
|
|
* net/tipc/core.c: TIPC module code
|
|
*
|
|
* Copyright (c) 2003-2006, Ericsson AB
|
|
* Copyright (c) 2005-2006, 2010-2013, Wind River Systems
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions are met:
|
|
*
|
|
* 1. Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* 2. Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
* documentation and/or other materials provided with the distribution.
|
|
* 3. Neither the names of the copyright holders nor the names of its
|
|
* contributors may be used to endorse or promote products derived from
|
|
* this software without specific prior written permission.
|
|
*
|
|
* Alternatively, this software may be distributed under the terms of the
|
|
* GNU General Public License ("GPL") version 2 as published by the Free
|
|
* Software Foundation.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
|
|
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
|
|
* ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE
|
|
* LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
|
|
* CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
|
|
* SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
|
|
* INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
|
|
* CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
|
|
* ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
|
|
* POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#include "core.h"
|
|
#include "ref.h"
|
|
#include "name_table.h"
|
|
#include "subscr.h"
|
|
#include "config.h"
|
|
#include "port.h"
|
|
|
|
#include <linux/module.h>
|
|
|
|
/* global variables used by multiple sub-systems within TIPC */
|
|
int tipc_random __read_mostly;
|
|
|
|
/* configurable TIPC parameters */
|
|
u32 tipc_own_addr __read_mostly;
|
|
int tipc_max_ports __read_mostly;
|
|
int tipc_net_id __read_mostly;
|
|
int tipc_remote_management __read_mostly;
|
|
int sysctl_tipc_rmem[3] __read_mostly; /* min/default/max */
|
|
|
|
/**
|
|
* tipc_buf_acquire - creates a TIPC message buffer
|
|
* @size: message size (including TIPC header)
|
|
*
|
|
* Returns a new buffer with data pointers set to the specified size.
|
|
*
|
|
* NOTE: Headroom is reserved to allow prepending of a data link header.
|
|
* There may also be unrequested tailroom present at the buffer's end.
|
|
*/
|
|
struct sk_buff *tipc_buf_acquire(u32 size)
|
|
{
|
|
struct sk_buff *skb;
|
|
unsigned int buf_size = (BUF_HEADROOM + size + 3) & ~3u;
|
|
|
|
skb = alloc_skb_fclone(buf_size, GFP_ATOMIC);
|
|
if (skb) {
|
|
skb_reserve(skb, BUF_HEADROOM);
|
|
skb_put(skb, size);
|
|
skb->next = NULL;
|
|
}
|
|
return skb;
|
|
}
|
|
|
|
/**
|
|
* tipc_core_stop - switch TIPC from SINGLE NODE to NOT RUNNING mode
|
|
*/
|
|
static void tipc_core_stop(void)
|
|
{
|
|
tipc_handler_stop();
|
|
tipc_net_stop();
|
|
tipc_bearer_cleanup();
|
|
tipc_netlink_stop();
|
|
tipc_cfg_stop();
|
|
tipc_subscr_stop();
|
|
tipc_nametbl_stop();
|
|
tipc_ref_table_stop();
|
|
tipc_socket_stop();
|
|
tipc_unregister_sysctl();
|
|
}
|
|
|
|
/**
|
|
* tipc_core_start - switch TIPC from NOT RUNNING to SINGLE NODE mode
|
|
*/
|
|
static int tipc_core_start(void)
|
|
{
|
|
int err;
|
|
|
|
get_random_bytes(&tipc_random, sizeof(tipc_random));
|
|
|
|
err = tipc_handler_start();
|
|
if (err)
|
|
goto out_handler;
|
|
|
|
err = tipc_ref_table_init(tipc_max_ports, tipc_random);
|
|
if (err)
|
|
goto out_reftbl;
|
|
|
|
err = tipc_nametbl_init();
|
|
if (err)
|
|
goto out_nametbl;
|
|
|
|
err = tipc_netlink_start();
|
|
if (err)
|
|
goto out_netlink;
|
|
|
|
err = tipc_socket_init();
|
|
if (err)
|
|
goto out_socket;
|
|
|
|
err = tipc_register_sysctl();
|
|
if (err)
|
|
goto out_sysctl;
|
|
|
|
err = tipc_subscr_start();
|
|
if (err)
|
|
goto out_subscr;
|
|
|
|
err = tipc_cfg_init();
|
|
if (err)
|
|
goto out_cfg;
|
|
|
|
err = tipc_bearer_setup();
|
|
if (err)
|
|
goto out_bearer;
|
|
|
|
return 0;
|
|
out_bearer:
|
|
tipc_cfg_stop();
|
|
out_cfg:
|
|
tipc_subscr_stop();
|
|
out_subscr:
|
|
tipc_unregister_sysctl();
|
|
out_sysctl:
|
|
tipc_socket_stop();
|
|
out_socket:
|
|
tipc_netlink_stop();
|
|
out_netlink:
|
|
tipc_nametbl_stop();
|
|
out_nametbl:
|
|
tipc_ref_table_stop();
|
|
out_reftbl:
|
|
tipc_handler_stop();
|
|
out_handler:
|
|
return err;
|
|
}
|
|
|
|
static int __init tipc_init(void)
|
|
{
|
|
int res;
|
|
|
|
pr_info("Activated (version " TIPC_MOD_VER ")\n");
|
|
|
|
tipc_own_addr = 0;
|
|
tipc_remote_management = 1;
|
|
tipc_max_ports = CONFIG_TIPC_PORTS;
|
|
tipc_net_id = 4711;
|
|
|
|
sysctl_tipc_rmem[0] = CONN_OVERLOAD_LIMIT >> 4 << TIPC_LOW_IMPORTANCE;
|
|
sysctl_tipc_rmem[1] = CONN_OVERLOAD_LIMIT >> 4 <<
|
|
TIPC_CRITICAL_IMPORTANCE;
|
|
sysctl_tipc_rmem[2] = CONN_OVERLOAD_LIMIT;
|
|
|
|
res = tipc_core_start();
|
|
if (res)
|
|
pr_err("Unable to start in single node mode\n");
|
|
else
|
|
pr_info("Started in single node mode\n");
|
|
return res;
|
|
}
|
|
|
|
static void __exit tipc_exit(void)
|
|
{
|
|
tipc_core_stop();
|
|
pr_info("Deactivated\n");
|
|
}
|
|
|
|
module_init(tipc_init);
|
|
module_exit(tipc_exit);
|
|
|
|
MODULE_DESCRIPTION("TIPC: Transparent Inter Process Communication");
|
|
MODULE_LICENSE("Dual BSD/GPL");
|
|
MODULE_VERSION(TIPC_MOD_VER);
|