mirror of
https://github.com/torvalds/linux.git
synced 2024-11-07 12:41:55 +00:00
6edd94db25
Initialization of irqenable, irqstatus registers is the common operation done in this function for all OMAP platforms, viz. OMAP1, OMAP2+. The latter _gpio_rmw()'s which supposedly got introduced wrongly to take care of OMAP2+ platforms were overwriting initially programmed OMAP1 value breaking functionality on OMAP1. Somehow incorrect assumption was made that each _gpio_rmw()'s were mutually exclusive. On close observation it is found that the first _gpio_rmw() which is supposedly done to take care of OMAP1 platform is generic enough and takes care of OMAP2+ platform as well. Therefore remove the latter _gpio_rmw() to irqenable as they are redundant now. Writing to ctrl and debounce_en registers for OMAP2+ platforms are modified to match the original(pre-cleanup) code where the registers are initialized with 0. In the cleanup series since we are using _gpio_rmw(reg, 0, 1), instead of __raw_writel(), we are just reading and writing the same values to ctrl and debounce_en. This is not an issue for debounce_en register because it has 0x0 as the default value. But in the case of ctrl register the default value is 0x2 (GATINGRATIO = 0x1) so that we end up writing 0x2 instead of intended 0 value. Therefore changing back to __raw_writel() as this is sufficient for this case besides simpler to understand. Also, change irqstatus initalization logic that avoids comparison with bool, besides making it fit in a single line. Cc: stable@vger.kernel.org Cc: Tony Lindgren <tony@atomide.com> Cc: Kevin Hilman <khilman@ti.com> Cc: Santosh Shilimkar <santosh.shilimkar@ti.com> Cc: Grant Likely <grant.likely@secretlab.ca> Reported-by: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl> Tested-by: Janusz Krzysztofik <jkrzyszt@tis.icnet.pl> Signed-off-by: Tarun Kanti DebBarma <tarun.kanti@ti.com> Signed-off-by: Kevin Hilman <khilman@ti.com> |
||
|---|---|---|
| .. | ||
| devres.c | ||
| gpio-74x164.c | ||
| gpio-ab8500.c | ||
| gpio-adp5520.c | ||
| gpio-adp5588.c | ||
| gpio-bt8xx.c | ||
| gpio-cs5535.c | ||
| gpio-da9052.c | ||
| gpio-davinci.c | ||
| gpio-ep93xx.c | ||
| gpio-ge.c | ||
| gpio-generic.c | ||
| gpio-it8761e.c | ||
| gpio-janz-ttl.c | ||
| gpio-ks8695.c | ||
| gpio-langwell.c | ||
| gpio-lpc32xx.c | ||
| gpio-max730x.c | ||
| gpio-max732x.c | ||
| gpio-max7300.c | ||
| gpio-max7301.c | ||
| gpio-mc9s08dz60.c | ||
| gpio-mc33880.c | ||
| gpio-mcp23s08.c | ||
| gpio-ml-ioh.c | ||
| gpio-mpc8xxx.c | ||
| gpio-mpc5200.c | ||
| gpio-msm-v1.c | ||
| gpio-msm-v2.c | ||
| gpio-mxc.c | ||
| gpio-mxs.c | ||
| gpio-nomadik.c | ||
| gpio-omap.c | ||
| gpio-pca953x.c | ||
| gpio-pcf857x.c | ||
| gpio-pch.c | ||
| gpio-pl061.c | ||
| gpio-pxa.c | ||
| gpio-rdc321x.c | ||
| gpio-sa1100.c | ||
| gpio-samsung.c | ||
| gpio-sch.c | ||
| gpio-sodaville.c | ||
| gpio-stmpe.c | ||
| gpio-sx150x.c | ||
| gpio-tc3589x.c | ||
| gpio-tegra.c | ||
| gpio-timberdale.c | ||
| gpio-tnetv107x.c | ||
| gpio-tps65910.c | ||
| gpio-tps65912.c | ||
| gpio-twl4030.c | ||
| gpio-ucb1400.c | ||
| gpio-vr41xx.c | ||
| gpio-vx855.c | ||
| gpio-wm831x.c | ||
| gpio-wm8350.c | ||
| gpio-wm8994.c | ||
| gpio-xilinx.c | ||
| gpiolib.c | ||
| Kconfig | ||
| Makefile | ||