mirror of
https://github.com/torvalds/linux.git
synced 2024-11-27 06:31:52 +00:00
21780f89d6
The strlen() may go too far when estimating the length of
the given string. In some cases it may go over the boundary
and crash the system which is the case according to the commit
13a55372b6 ("ARM: orion5x: Revert commit 4904dbda41c8.").
Rectify this by switching to strnlen() for the expected
maximum length of the string.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20221108141108.62974-1-andriy.shevchenko@linux.intel.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
29 lines
674 B
C
29 lines
674 B
C
// SPDX-License-Identifier: GPL-2.0
|
|
#include <linux/string.h>
|
|
#include <linux/if_ether.h>
|
|
#include <linux/ctype.h>
|
|
#include <linux/kernel.h>
|
|
|
|
bool mac_pton(const char *s, u8 *mac)
|
|
{
|
|
size_t maxlen = 3 * ETH_ALEN - 1;
|
|
int i;
|
|
|
|
/* XX:XX:XX:XX:XX:XX */
|
|
if (strnlen(s, maxlen) < maxlen)
|
|
return false;
|
|
|
|
/* Don't dirty result unless string is valid MAC. */
|
|
for (i = 0; i < ETH_ALEN; i++) {
|
|
if (!isxdigit(s[i * 3]) || !isxdigit(s[i * 3 + 1]))
|
|
return false;
|
|
if (i != ETH_ALEN - 1 && s[i * 3 + 2] != ':')
|
|
return false;
|
|
}
|
|
for (i = 0; i < ETH_ALEN; i++) {
|
|
mac[i] = (hex_to_bin(s[i * 3]) << 4) | hex_to_bin(s[i * 3 + 1]);
|
|
}
|
|
return true;
|
|
}
|
|
EXPORT_SYMBOL(mac_pton);
|