linux/drivers/scsi/lpfc
Arnd Bergmann f8d2943245 scsi: lpfc: fix remoteport access
The addition of a spinlock in lpfc_debugfs_nodelist_data() introduced
a bug that lets us not skip NULL pointers correctly, as noticed by
gcc-8:

drivers/scsi/lpfc/lpfc_debugfs.c: In function 'lpfc_debugfs_nodelist_data.constprop':
drivers/scsi/lpfc/lpfc_debugfs.c:728:13: error: 'nrport' may be used uninitialized in this function [-Werror=maybe-uninitialized]
   if (nrport->port_role & FC_PORT_ROLE_NVME_INITIATOR)

This changes the logic back to what it was, while keeping the added
spinlock.

Fixes: 9e21017826 ("scsi: lpfc: Synchronize access to remoteport via rport")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
2018-11-05 22:35:01 -05:00
..
lpfc_attr.c SCSI misc on 20181024 2018-10-25 07:40:30 -07:00
lpfc_attr.h scsi: lpfc: Revise copyright for new company language 2018-07-10 22:15:09 -04:00
lpfc_bsg.c scsi: lpfc: remove a bogus pci_dma_sync_single_for_device call 2018-10-15 22:41:00 -04:00
lpfc_bsg.h scsi: lpfc: add support to retrieve firmware logs 2018-09-11 20:37:33 -04:00
lpfc_compat.h scsi: lpfc: Revise copyright for new company language 2018-07-10 22:15:09 -04:00
lpfc_crtn.h scsi: lpfc: add support to retrieve firmware logs 2018-09-11 20:37:33 -04:00
lpfc_ct.c scsi: lpfc: Correct irq handling via locks when taking adapter offline 2018-09-11 20:37:33 -04:00
lpfc_debugfs.c scsi: lpfc: fix remoteport access 2018-11-05 22:35:01 -05:00
lpfc_debugfs.h scsi: lpfc: Revise copyright for new company language 2018-07-10 22:15:09 -04:00
lpfc_disc.h scsi: lpfc: Limit tracking of tgt queue depth in fast path 2018-08-02 15:45:19 -04:00
lpfc_els.c scsi: lpfc: Correct irq handling via locks when taking adapter offline 2018-09-11 20:37:33 -04:00
lpfc_hbadisc.c scsi: lpfc: Remove set but not used variable 'psli' 2018-10-16 21:46:46 -04:00
lpfc_hw4.h scsi: lpfc: add support to retrieve firmware logs 2018-09-11 20:37:33 -04:00
lpfc_hw.h scsi: lpfc: Revise copyright for new company language 2018-07-10 22:15:09 -04:00
lpfc_ids.h scsi: lpfc: Revise copyright for new company language 2018-07-10 22:15:09 -04:00
lpfc_init.c SCSI misc on 20181024 2018-10-25 07:40:30 -07:00
lpfc_logmsg.h scsi: lpfc: Revise copyright for new company language 2018-07-10 22:15:09 -04:00
lpfc_mbox.c scsi: lpfc: Revise copyright for new company language 2018-07-10 22:15:09 -04:00
lpfc_mem.c scsi: lpfc: Revise copyright for new company language 2018-07-10 22:15:09 -04:00
lpfc_nl.h scsi: lpfc: Revise copyright for new company language 2018-07-10 22:15:09 -04:00
lpfc_nportdisc.c scsi: lpfc: Fix GFT_ID and PRLI logic for RSCN 2018-09-11 20:37:32 -04:00
lpfc_nvme.c SCSI misc on 20181024 2018-10-25 07:40:30 -07:00
lpfc_nvme.h scsi: lpfc: Limit tracking of tgt queue depth in fast path 2018-08-02 15:45:19 -04:00
lpfc_nvmet.c scsi: lpfc: Fix errors in log messages. 2018-09-11 20:37:33 -04:00
lpfc_nvmet.h scsi: lpfc: Revise copyright for new company language 2018-07-10 22:15:09 -04:00
lpfc_scsi.c scsi: lpfc: reduce locking when updating statistics 2018-09-11 20:37:33 -04:00
lpfc_scsi.h scsi: lpfc: Limit tracking of tgt queue depth in fast path 2018-08-02 15:45:19 -04:00
lpfc_sli4.h scsi: lpfc: add support to retrieve firmware logs 2018-09-11 20:37:33 -04:00
lpfc_sli.c scsi: lpfc: Remove set but not used variables 'fc_hdr' and 'hw_page_size' 2018-10-16 21:23:55 -04:00
lpfc_sli.h scsi: lpfc: Revise copyright for new company language 2018-07-10 22:15:09 -04:00
lpfc_version.h scsi: lpfc: update driver version to 12.0.0.7 2018-09-11 20:37:34 -04:00
lpfc_vport.c scsi: lpfc: Correct irq handling via locks when taking adapter offline 2018-09-11 20:37:33 -04:00
lpfc_vport.h scsi: lpfc: Revise copyright for new company language 2018-07-10 22:15:09 -04:00
lpfc.h SCSI misc on 20181024 2018-10-25 07:40:30 -07:00
Makefile scsi: lpfc: Revise copyright for new company language 2018-07-10 22:15:09 -04:00