Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-22 20:22:09 +00:00
Code Issues Packages Projects Releases Wiki Activity
b2cc5c465c
linux/drivers/dma
History
Viacheslav Mitrofanov b2cc5c465c dmaengine: sf-pdma: Add multithread support for a DMA channel 
When we get a DMA channel and try to use it in multiple threads it
will cause oops and hanging the system.

% echo 64 > /sys/module/dmatest/parameters/threads_per_chan
% echo 10000 > /sys/module/dmatest/parameters/iterations
% echo 1 > /sys/module/dmatest/parameters/run
[   89.480664] Unable to handle kernel NULL pointer dereference at virtual
               address 00000000000000a0
[   89.488725] Oops [#1]
[   89.494708] CPU: 2 PID: 1008 Comm: dma0chan0-copy0 Not tainted
               5.17.0-rc5
[   89.509385] epc : vchan_find_desc+0x32/0x46
[   89.513553]  ra : sf_pdma_tx_status+0xca/0xd6

This happens because of data race. Each thread rewrite channels's
descriptor as soon as device_prep_dma_memcpy() is called. It leads to the
situation when the driver thinks that it uses right descriptor that
actually is freed or substituted for other one.

With current fixes a descriptor changes its value only when it has
been used. A new descriptor is acquired from vc->desc_issued queue that
is already filled with descriptors that are ready to be sent. Threads
have no direct access to DMA channel descriptor. Now it is just possible
to queue a descriptor for further processing.

Fixes: 6973886ad5 ("dmaengine: sf-pdma: add platform DMA support for HiFive Unleashed A00")
Signed-off-by: Viacheslav Mitrofanov <v.v.mitrofanov@yadro.com>
Link: https://lore.kernel.org/r/20220701082942.12835-1-v.v.mitrofanov@yadro.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
2022-07-06 18:10:34 +05:30
..
bestcomm dmaengine: bestcomm: Prepare cleanup of powerpc's asm/prom.h 2022-04-11 17:43:19 +05:30
dw dmaengine: dw: dmamux: Fix build without CONFIG_OF 2022-06-10 17:51:21 +05:30
dw-axi-dmac dmaengine: dw-axi-dmac: cleanup comments 2022-03-11 16:05:01 +05:30
dw-edma dmaengine: dw-edma: remove a macro conditional with similar branches 2022-06-10 19:19:24 +05:30
fsl-dpaa2-qdma dmaengine: fsl-dpaa2-qdma: Drop comma after SoC match table sentinel 2022-03-11 15:47:39 +05:30
hsu dmaengine: hsu: switch from 'pci_' to 'dma_' API 2021-10-26 10:54:47 +05:30
idxd dmaengine updates for v5.19-rc1 2022-05-29 11:38:27 -07:00
ioat dmaengine: iot: Remove useless DMA-32 fallback configuration 2022-02-15 11:04:06 +05:30
ipu dmaengine: ipu: Fix fall-through warning for Clang 2021-07-13 14:38:47 -05:00
lgm dmaengine: INTEL_LDMA should depend on X86 2021-02-01 11:27:14 +05:30
mediatek dmaengine: mediatek-cqdma: fix typo in comment 2022-07-06 10:50:43 +05:30
ppc4xx dmaengine: ppc4xx: Make use of the helper macro LIST_HEAD() 2022-03-11 15:39:09 +05:30
ptdma dmaengine: ptdma: statify pt_tx_status 2022-04-22 11:29:13 +05:30
qcom dmaengine: qcom: gpi: Add support for sc7280 2022-05-19 23:43:40 +05:30
sf-pdma dmaengine: sf-pdma: Add multithread support for a DMA channel 2022-07-06 18:10:34 +05:30
sh dmaengine: sh: Kconfig: Make RZ_DMAC depend on ARCH_RZG2L 2022-04-08 23:22:00 +05:30
ti dmaengine: ti: k3-psil-j721s2: Add psil threads for sa2ul 2022-07-01 17:17:30 +05:30
xilinx dmaengine: xilinx_dpdma: Omit superfluous error message in xilinx_dpdma_probe() 2022-07-06 10:48:14 +05:30
acpi-dma.c dmaengine: acpi: Check for errors from acpi_register_gsi() separately 2021-08-06 21:48:11 +05:30
altera-msgdma.c dmaengine: altera-msgdma: Remove useless DMA-32 fallback configuration 2022-02-15 16:53:11 +05:30
amba-pl08x.c dmaengine: fix typos in comments 2022-07-06 10:50:43 +05:30
apple-admac.c dmaengine: apple-admac: Use {low,upp}er_32_bits() to split 64-bit address 2022-06-16 08:41:43 -07:00
at_hdmac_regs.h dmaengine: at_hdmac: remove platform data header 2021-01-08 13:57:19 +05:30
at_hdmac.c dmaengine: at_hdmac: In atc_prep_dma_memset, treat value as a single byte 2022-04-20 17:28:12 +05:30
at_xdmac.c dmaengine: at_xdmac: Fix typo in comment 2022-07-01 22:06:07 +05:30
bcm2835-dma.c
bcm-sba-raid.c
dma-axi-dmac.c
dma-jz4780.c dmaengine: jz4780: fix typo in comment 2022-07-06 10:51:43 +05:30
dmaengine.c dmaengine: remove DMA_MEMCPY_SG once again 2022-06-27 12:01:40 +05:30
dmaengine.h dmaengine: dmaengine_desc_callback_valid(): Check for callback_result 2021-10-25 09:42:56 +05:30
dmatest.c dmaengine: dmatest: use strscpy to replace strlcpy 2022-07-06 11:04:43 +05:30
ep93xx_dma.c dmaengine: ep93xx: Fix typo in comments 2022-07-01 21:50:23 +05:30
fsl_raid.c dmaengine: fsl: remove bad channel update 2020-10-05 09:59:17 +05:30
fsl_raid.h
fsl-edma-common.c dmaengine: fsl-edma: remove redundant assignment to pointer last_sg 2022-07-01 22:09:16 +05:30
fsl-edma-common.h dmaengine: fsl-edma: support edma memcpy 2021-10-28 22:56:24 +05:30
fsl-edma.c dmaengine: fsl-edma: support edma memcpy 2021-10-28 22:56:24 +05:30
fsl-qdma.c dmaengine: fsl-qdma: check dma_set_mask return value 2021-05-10 19:51:03 +05:30
fsldma.c dmaengine: fsldma: Fix a resource leak in an error handling path of the probe function 2021-01-12 18:00:39 +05:30
fsldma.h
hisi_dma.c dmaengine: hisi_dma: fix MSI allocate fail when reload hisi_dma 2022-03-11 16:05:39 +05:30
idma64.c dmaengine: idma64: Switch to use __maybe_unused instead of ifdeffery 2020-11-09 17:21:05 +05:30
idma64.h
img-mdc-dma.c
imx-dma.c dmaengine: imx: Move header to include/dma/ 2022-04-19 12:06:18 +01:00
imx-sdma.c dmaengine: imx-sdma: Improve the SDMA irq name 2022-07-01 21:49:17 +05:30
iop-adma.c Merge branch 'topic/tasklet' into next 2020-10-01 10:18:59 +05:30
iop-adma.h
k3dma.c dmaengine: k3dma: use the correct HiSilicon copyright 2021-04-12 17:14:53 +05:30
Kconfig dmaengine: apple-admac: Add Apple ADMAC driver 2022-06-09 12:20:20 +05:30
lpc18xx-dmamux.c
Makefile dmaengine: apple-admac: Add Apple ADMAC driver 2022-06-09 12:20:20 +05:30
mcf-edma.c
milbeaut-hdmac.c dmaengine: milbeaut-hdmac: Prefer kcalloc over open coded arithmetic 2021-10-25 12:12:13 +05:30
milbeaut-xdmac.c dmaengine: milbeaut-xdmac: Fix a resource leak in the error handling path of the probe function 2020-12-29 10:08:00 +05:30
mmp_pdma.c dmaengine: mmp: deprecate '#dma-channels' 2022-05-19 22:53:46 +05:30
mmp_tdma.c
moxart-dma.c dmaengine: moxart-dma: remove redundant irqsave and irqrestore in hardIRQ 2020-11-09 17:25:54 +05:30
mpc512x_dma.c dmaengine: mpc512x: Fix fall-through warning for Clang 2021-07-14 11:05:55 -05:00
mv_xor_v2.c dmaengine: fix typos in comments 2022-07-06 10:50:43 +05:30
mv_xor.c dmaengine: mv_xor: drop of_match_ptr from of_device_id table 2020-11-24 23:02:20 +05:30
mv_xor.h
mxs-dma.c dmaengine: mxs-dma: Remove the unused .id_table 2020-11-24 22:55:15 +05:30
nbpfaxi.c dmaengine: nbpfaxi: Use platform_get_irq_optional() to get the interrupt 2022-04-11 16:26:53 +05:30
of-dma.c dmaengine: of-dma: router_xlate to return -EPROBE_DEFER if controller is not yet available 2021-07-28 12:54:50 +05:30
owl-dma.c dmaengine: owl: fix typo in comment 2022-07-06 10:50:43 +05:30
pch_dma.c dmaengine: pch_dma: Remove usage of the deprecated "pci-dma-compat.h" API 2022-01-08 22:16:44 +05:30
pl330.c ARM: 9172/1: amba: Cleanup amba pclk operation 2022-02-28 13:59:15 +00:00
plx_dma.c dmaengine: plx_dma: Move spin_lock_bh() to spin_lock() 2022-04-20 15:59:33 +05:30
pxa_dma.c dmaengine: pxa: deprecate '#dma-channels' and '#dma-requests' 2022-05-19 22:53:46 +05:30
s3c24xx-dma.c dmaengine: s3c24xx: fix typo in comment 2022-07-06 10:51:12 +05:30
sa11x0-dma.c dmaengine: sa11x0: Mark PM functions as __maybe_unused 2021-10-26 10:55:07 +05:30
sprd-dma.c dmaengine: sprd: deprecate '#dma-channels' 2022-05-16 18:34:35 +05:30
st_fdma.c dmaengine: st_fdma: fix MODULE_ALIAS 2021-12-13 13:18:48 +05:30
st_fdma.h
ste_dma40_ll.c
ste_dma40_ll.h
ste_dma40.c dmaengine: ste_dma40: fix typo in comment 2022-07-06 10:54:08 +05:30
stm32-dma.c dmaengine: stm32-dma: add device_pause/device_resume support 2022-05-19 23:43:41 +05:30
stm32-dmamux.c dmaengine: stm32-dmamux: avoid reset of dmamux if used by coprocessor 2022-05-19 23:43:40 +05:30
stm32-mdma.c dmaengine: stm32-mdma: Remove dead code in stm32_mdma_irq_handler() 2022-06-16 09:04:09 -07:00
sun4i-dma.c dmaengine: sun4i: Set the maximum segment size 2022-07-05 18:34:26 +05:30
sun6i-dma.c dmaengine: sun6i: Add support for the D1 variant 2022-05-19 23:43:41 +05:30
tegra20-apb-dma.c dmaengine: tegra20-apb: stop checking config->slave_id 2021-12-17 11:23:38 +05:30
tegra186-gpc-dma.c dmaengine: tegra: Remove unused switch case 2022-05-19 23:43:41 +05:30
tegra210-adma.c dmaengine: tegra210-adma: fix pm runtime unbalance in tegra_adma_remove 2021-10-25 10:06:10 +05:30
timb_dma.c dmaengine: timb_dma: convert tasklets to use new tasklet_setup() API 2020-09-18 12:19:07 +05:30
TODO
txx9dmac.c dmaengine: txx9dmac: convert tasklets to use new tasklet_setup() API 2020-09-18 12:19:07 +05:30
txx9dmac.h
uniphier-mdmac.c
uniphier-xdmac.c dmaengine: uniphier-xdmac: Fix type of address variables 2022-01-03 17:49:37 +05:30
virt-dma.c dmaengine: virt-dma: convert tasklets to use new tasklet_setup() API 2020-09-18 12:19:07 +05:30
virt-dma.h
xgene-dma.c dmaengine: xgene: convert tasklets to use new tasklet_setup() API 2020-09-18 12:19:07 +05:30