mirror of
https://github.com/torvalds/linux.git
synced 2024-11-25 05:32:00 +00:00
9d262f35b1
make allmodconfig && make W=1 C=1 reports: WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-a4tech.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-apple.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-aureal.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-belkin.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-betopff.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-bigbenff.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-cherry.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-chicony.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-cypress.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-dr.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-emsff.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-elecom.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-elo.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-evision.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-ezkey.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-vivaldi-common.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-google-hammer.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-google-stadiaff.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-gyration.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-holtek-kbd.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-holtek-mouse.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-ite.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-kensington.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-keytouch.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-kye.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-lcpower.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-lenovo.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-logitech.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-magicmouse.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-maltron.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-mf.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-megaworld.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-microsoft.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-monterey.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-ntrig.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-ortek.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-prodikeys.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-pl.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-petalynx.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-primax.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-razer.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-redragon.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-retrode.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-saitek.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-samsung.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-semitek.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-sjoy.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-sony.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-speedlink.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-steam.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-steelseries.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-sunplus.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-gaff.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-tmff.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-tivo.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-topseed.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-twinhan.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-uclogic.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-xinmo.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-zpff.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-zydacron.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-viewsonic.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-waltop.o WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/hid/hid-winwing.o Add the missing invocations of the MODULE_DESCRIPTION() macro. Note: All HID drivers that had explicit entries in the MAINTAINERS file were fixed individually. This patch fixes all remaining HID drivers that fall under the generic "HID CORE LAYER" entry in the MAINTAINERS file. Almost all descriptions were taken from the header comment in each file. Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> Link: https://lore.kernel.org/r/20240604-md-hid-misc-v1-1-4f9560796f3c@quicinc.com Signed-off-by: Benjamin Tissoires <bentiss@kernel.org>
143 lines
3.7 KiB
C
143 lines
3.7 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* Helpers for ChromeOS HID Vivaldi keyboards
|
|
*
|
|
* Copyright (C) 2022 Google, Inc
|
|
*/
|
|
|
|
#include <linux/export.h>
|
|
#include <linux/hid.h>
|
|
#include <linux/input/vivaldi-fmap.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/types.h>
|
|
|
|
#include "hid-vivaldi-common.h"
|
|
|
|
#define MIN_FN_ROW_KEY 1
|
|
#define MAX_FN_ROW_KEY VIVALDI_MAX_FUNCTION_ROW_KEYS
|
|
#define HID_VD_FN_ROW_PHYSMAP 0x00000001
|
|
#define HID_USAGE_FN_ROW_PHYSMAP (HID_UP_GOOGLEVENDOR | HID_VD_FN_ROW_PHYSMAP)
|
|
|
|
/**
|
|
* vivaldi_feature_mapping - Fill out vivaldi keymap data exposed via HID
|
|
* @hdev: HID device to parse
|
|
* @field: HID field to parse
|
|
* @usage: HID usage to parse
|
|
*
|
|
* Note: this function assumes that driver data attached to @hdev contains an
|
|
* instance of &struct vivaldi_data at the very beginning.
|
|
*/
|
|
void vivaldi_feature_mapping(struct hid_device *hdev,
|
|
struct hid_field *field, struct hid_usage *usage)
|
|
{
|
|
struct vivaldi_data *data = hid_get_drvdata(hdev);
|
|
struct hid_report *report = field->report;
|
|
u8 *report_data, *buf;
|
|
u32 report_len;
|
|
unsigned int fn_key;
|
|
int ret;
|
|
|
|
if (field->logical != HID_USAGE_FN_ROW_PHYSMAP ||
|
|
(usage->hid & HID_USAGE_PAGE) != HID_UP_ORDINAL)
|
|
return;
|
|
|
|
fn_key = usage->hid & HID_USAGE;
|
|
if (fn_key < MIN_FN_ROW_KEY || fn_key > MAX_FN_ROW_KEY)
|
|
return;
|
|
|
|
if (fn_key > data->num_function_row_keys)
|
|
data->num_function_row_keys = fn_key;
|
|
|
|
report_data = buf = hid_alloc_report_buf(report, GFP_KERNEL);
|
|
if (!report_data)
|
|
return;
|
|
|
|
report_len = hid_report_len(report);
|
|
if (!report->id) {
|
|
/*
|
|
* hid_hw_raw_request() will stuff report ID (which will be 0)
|
|
* into the first byte of the buffer even for unnumbered
|
|
* reports, so we need to account for this to avoid getting
|
|
* -EOVERFLOW in return.
|
|
* Note that hid_alloc_report_buf() adds 7 bytes to the size
|
|
* so we can safely say that we have space for an extra byte.
|
|
*/
|
|
report_len++;
|
|
}
|
|
|
|
ret = hid_hw_raw_request(hdev, report->id, report_data,
|
|
report_len, HID_FEATURE_REPORT,
|
|
HID_REQ_GET_REPORT);
|
|
if (ret < 0) {
|
|
dev_warn(&hdev->dev, "failed to fetch feature %d\n",
|
|
field->report->id);
|
|
goto out;
|
|
}
|
|
|
|
if (!report->id) {
|
|
/*
|
|
* Undo the damage from hid_hw_raw_request() for unnumbered
|
|
* reports.
|
|
*/
|
|
report_data++;
|
|
report_len--;
|
|
}
|
|
|
|
ret = hid_report_raw_event(hdev, HID_FEATURE_REPORT, report_data,
|
|
report_len, 0);
|
|
if (ret) {
|
|
dev_warn(&hdev->dev, "failed to report feature %d\n",
|
|
field->report->id);
|
|
goto out;
|
|
}
|
|
|
|
data->function_row_physmap[fn_key - MIN_FN_ROW_KEY] =
|
|
field->value[usage->usage_index];
|
|
|
|
out:
|
|
kfree(buf);
|
|
}
|
|
EXPORT_SYMBOL_GPL(vivaldi_feature_mapping);
|
|
|
|
static ssize_t function_row_physmap_show(struct device *dev,
|
|
struct device_attribute *attr,
|
|
char *buf)
|
|
{
|
|
struct hid_device *hdev = to_hid_device(dev);
|
|
struct vivaldi_data *data = hid_get_drvdata(hdev);
|
|
|
|
return vivaldi_function_row_physmap_show(data, buf);
|
|
}
|
|
|
|
static DEVICE_ATTR_RO(function_row_physmap);
|
|
static struct attribute *vivaldi_sysfs_attrs[] = {
|
|
&dev_attr_function_row_physmap.attr,
|
|
NULL
|
|
};
|
|
|
|
static umode_t vivaldi_is_visible(struct kobject *kobj, struct attribute *attr,
|
|
int n)
|
|
{
|
|
struct hid_device *hdev = to_hid_device(kobj_to_dev(kobj));
|
|
struct vivaldi_data *data = hid_get_drvdata(hdev);
|
|
|
|
if (!data->num_function_row_keys)
|
|
return 0;
|
|
return attr->mode;
|
|
}
|
|
|
|
static const struct attribute_group vivaldi_attribute_group = {
|
|
.attrs = vivaldi_sysfs_attrs,
|
|
.is_visible = vivaldi_is_visible,
|
|
};
|
|
|
|
const struct attribute_group *vivaldi_attribute_groups[] = {
|
|
&vivaldi_attribute_group,
|
|
NULL,
|
|
};
|
|
EXPORT_SYMBOL_GPL(vivaldi_attribute_groups);
|
|
|
|
MODULE_DESCRIPTION("Helpers for ChromeOS HID Vivaldi keyboards");
|
|
MODULE_LICENSE("GPL");
|