Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-12-12 14:12:51 +00:00
Code Issues Packages Projects Releases Wiki Activity
ab58a5a1c0
linux/drivers/phy
History
Liu Ying 9a8406ba1a phy: dphy: Correct clk_pre parameter 
The D-PHY specification (v1.2) explicitly mentions that the T-CLK-PRE
parameter's unit is Unit Interval(UI) and the minimum value is 8.  Also,
kernel doc of the 'clk_pre' member of struct phy_configure_opts_mipi_dphy
mentions that it should be in UI.  However, the dphy core driver wrongly
sets 'clk_pre' to 8000, which seems to hint that it's in picoseconds.

So, let's fix the dphy core driver to correctly reflect the T-CLK-PRE
parameter's minimum value according to the D-PHY specification.

I'm assuming that all impacted custom drivers shall program values in
TxByteClkHS cycles into hardware for the T-CLK-PRE parameter.  The D-PHY
specification mentions that the frequency of TxByteClkHS is exactly 1/8
the High-Speed(HS) bit rate(each HS bit consumes one UI).  So, relevant
custom driver code is changed to program those values as
DIV_ROUND_UP(cfg->clk_pre, BITS_PER_BYTE), then.

Note that I've only tested the patch with RM67191 DSI panel on i.MX8mq EVK.
Help is needed to test with other i.MX8mq, Meson and Rockchip platforms,
as I don't have the hardwares.

Fixes: 2ed869990e ("phy: Add MIPI D-PHY configuration options")
Tested-by: Liu Ying <victor.liu@nxp.com> # RM67191 DSI panel on i.MX8mq EVK
Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com> # for phy-meson-axg-mipi-dphy.c
Tested-by: Neil Armstrong <narmstrong@baylibre.com> # for phy-meson-axg-mipi-dphy.c
Tested-by: Guido Günther <agx@sigxcpu.org> # Librem 5 (imx8mq) with it's rather picky panel
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Liu Ying <victor.liu@nxp.com>
Link: https://lore.kernel.org/r/20220124024007.1465018-1-victor.liu@nxp.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
2022-02-02 10:33:04 +05:30
..
allwinner phy: sun4i-usb: remove enable_pmu_unk1 from sun50i_h6_cfg 2020-11-19 11:49:18 +05:30
amlogic phy: dphy: Correct clk_pre parameter 2022-02-02 10:33:04 +05:30
broadcom phy: broadcom: Kconfig: Fix PHY_BRCM_USB config option 2022-01-23 19:33:28 +05:30
cadence phy: cadence: Sierra: fix error handling bugs in probe() 2022-01-24 09:35:31 +05:30
freescale phy: freescale: pcie: explicitly add bitfield.h 2021-12-15 20:50:43 +05:30
hisilicon phy: HiSilicon: Fix copy and paste bug in error handling 2021-11-23 10:42:13 +05:30
ingenic phy: ingenic: Fix a typo in ingenic_usb_phy_probe() 2021-03-30 23:35:17 +05:30
intel phy: intel: Remove redundant dev_err call in thunderbay_emmc_phy_probe() 2021-12-02 09:46:33 +05:30
lantiq phy: lantiq: rcu-usb2: wait after clock enable 2021-01-13 19:29:03 +05:30
marvell Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net 2021-12-16 16:13:19 -08:00
mediatek phy: phy-mtk-tphy: Fix duplicated argument in phy-mtk-tphy 2022-01-27 12:14:34 +05:30
microchip phy: lan966x: Remove set_speed function 2021-12-14 14:24:48 +05:30
motorola phy-for-5.12 2021-02-09 09:32:35 +01:00
mscc
qualcomm phy-for-5.17 2021-12-30 14:02:16 +01:00
ralink phy-for-5.14 version 2 2021-06-23 10:33:34 +02:00
renesas phy: renesas: phy-rcar-gen3-usb2: Add USB2.0 PHY support for RZ/G2L 2021-08-06 18:12:30 +05:30
rockchip phy: dphy: Correct clk_pre parameter 2022-02-02 10:33:04 +05:30
samsung phy: samsung: unify naming and describe driver in KConfig 2021-10-01 11:46:20 +05:30
socionext phy: uniphier-usb3ss: fix unintended writing zeros to PHY register 2021-12-24 10:06:38 +05:30
st phy: stm32: fix a refcount leak in stm32_usbphyc_pll_enable() 2022-01-27 11:04:40 +05:30
tegra phy: tegra: xusb: Fix return value of tegra_xusb_find_port_node function 2021-12-14 13:07:21 +05:30
ti phy: ti: Fix missing sentinel for clk_div_table 2022-01-24 09:33:33 +05:30
xilinx phy: xilinx: zynqmp: Fix bus width setting for SGMII 2022-01-27 10:55:26 +05:30
Kconfig phy: pistachio-usb: Depend on MIPS || COMPILE_TEST 2021-08-12 16:01:49 +02:00
Makefile phy: phy-can-transceiver: Add support for generic CAN transceiver driver 2021-06-14 11:20:17 +05:30
phy-can-transceiver.c phy: phy-can-transceiver: Make devm_gpiod_get optional 2021-11-23 12:15:08 +05:30
phy-core-mipi-dphy.c phy: dphy: Correct clk_pre parameter 2022-02-02 10:33:04 +05:30
phy-core.c phy: Allow a NULL phy name for devm_phy_get() 2021-05-14 17:48:41 +05:30
phy-lgm-usb.c
phy-lpc18xx-usb-otg.c
phy-pistachio-usb.c
phy-xgene.c phy: phy-xgene.c: Fix alignment of comment 2021-05-31 14:08:55 +05:30