mirror of
https://github.com/torvalds/linux.git
synced 2024-12-21 10:31:54 +00:00
67d2f8781b
Commit dec2c92880 ("Bluetooth: hci_ldisc:
Use rwlocking to avoid closing proto races") introduced locks in
hci_ldisc that are held while calling the proto functions. These locks
are rwlock's, and hence do not allow sleeping while they are held.
However, the proto functions that hci_bcm registers use mutexes and
hence need to be able to sleep.
In more detail: hci_uart_tty_receive() and hci_uart_dequeue() both
acquire the rwlock, after which they call proto->recv() and
proto->dequeue(), respectively. In the case of hci_bcm these point to
bcm_recv() and bcm_dequeue(). The latter both acquire the
bcm_device_lock, which is a mutex, so doing so results in a call to
might_sleep(). But since we're holding a rwlock in hci_ldisc, that
results in the following BUG (this for the dequeue case - a similar
one for the receive case is omitted for brevity):
BUG: sleeping function called from invalid context at kernel/locking/mutex.c
in_atomic(): 1, irqs_disabled(): 0, pid: 7303, name: kworker/7:3
INFO: lockdep is turned off.
CPU: 7 PID: 7303 Comm: kworker/7:3 Tainted: G W OE 4.13.2+ #17
Hardware name: Apple Inc. MacBookPro13,3/Mac-A5C67F76ED83108C, BIOS MBP133.8
Workqueue: events hci_uart_write_work [hci_uart]
Call Trace:
dump_stack+0x8e/0xd6
___might_sleep+0x164/0x250
__might_sleep+0x4a/0x80
__mutex_lock+0x59/0xa00
? lock_acquire+0xa3/0x1f0
? lock_acquire+0xa3/0x1f0
? hci_uart_write_work+0xd3/0x160 [hci_uart]
mutex_lock_nested+0x1b/0x20
? mutex_lock_nested+0x1b/0x20
bcm_dequeue+0x21/0xc0 [hci_uart]
hci_uart_write_work+0xe6/0x160 [hci_uart]
process_one_work+0x253/0x6a0
worker_thread+0x4d/0x3b0
kthread+0x133/0x150
We can't replace the mutex in hci_bcm, because there are other calls
there that might sleep. Therefore this replaces the rwlock's in
hci_ldisc with rw_semaphore's (which allow sleeping). This is a safer
approach anyway as it reduces the restrictions on the proto callbacks.
Also, because acquiring write-lock is very rare compared to acquiring
the read-lock, the percpu variant of rw_semaphore is used.
Lastly, because hci_uart_tx_wakeup() may be called from an IRQ context,
we can't block (sleep) while trying acquire the read lock there, so we
use the trylock variant.
Signed-off-by: Ronald Tschalär <ronald@innovation.ch>
Reviewed-by: Lukas Wunner <lukas@wunner.de>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
207 lines
5.1 KiB
C
207 lines
5.1 KiB
C
/*
|
|
*
|
|
* Bluetooth HCI UART driver
|
|
*
|
|
* Copyright (C) 2000-2001 Qualcomm Incorporated
|
|
* Copyright (C) 2002-2003 Maxim Krasnyansky <maxk@qualcomm.com>
|
|
* Copyright (C) 2004-2005 Marcel Holtmann <marcel@holtmann.org>
|
|
*
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
|
|
*
|
|
*/
|
|
|
|
#ifndef N_HCI
|
|
#define N_HCI 15
|
|
#endif
|
|
|
|
/* Ioctls */
|
|
#define HCIUARTSETPROTO _IOW('U', 200, int)
|
|
#define HCIUARTGETPROTO _IOR('U', 201, int)
|
|
#define HCIUARTGETDEVICE _IOR('U', 202, int)
|
|
#define HCIUARTSETFLAGS _IOW('U', 203, int)
|
|
#define HCIUARTGETFLAGS _IOR('U', 204, int)
|
|
|
|
/* UART protocols */
|
|
#define HCI_UART_MAX_PROTO 12
|
|
|
|
#define HCI_UART_H4 0
|
|
#define HCI_UART_BCSP 1
|
|
#define HCI_UART_3WIRE 2
|
|
#define HCI_UART_H4DS 3
|
|
#define HCI_UART_LL 4
|
|
#define HCI_UART_ATH3K 5
|
|
#define HCI_UART_INTEL 6
|
|
#define HCI_UART_BCM 7
|
|
#define HCI_UART_QCA 8
|
|
#define HCI_UART_AG6XX 9
|
|
#define HCI_UART_NOKIA 10
|
|
#define HCI_UART_MRVL 11
|
|
|
|
#define HCI_UART_RAW_DEVICE 0
|
|
#define HCI_UART_RESET_ON_INIT 1
|
|
#define HCI_UART_CREATE_AMP 2
|
|
#define HCI_UART_INIT_PENDING 3
|
|
#define HCI_UART_EXT_CONFIG 4
|
|
#define HCI_UART_VND_DETECT 5
|
|
|
|
struct hci_uart;
|
|
struct serdev_device;
|
|
|
|
struct hci_uart_proto {
|
|
unsigned int id;
|
|
const char *name;
|
|
unsigned int manufacturer;
|
|
unsigned int init_speed;
|
|
unsigned int oper_speed;
|
|
int (*open)(struct hci_uart *hu);
|
|
int (*close)(struct hci_uart *hu);
|
|
int (*flush)(struct hci_uart *hu);
|
|
int (*setup)(struct hci_uart *hu);
|
|
int (*set_baudrate)(struct hci_uart *hu, unsigned int speed);
|
|
int (*recv)(struct hci_uart *hu, const void *data, int len);
|
|
int (*enqueue)(struct hci_uart *hu, struct sk_buff *skb);
|
|
struct sk_buff *(*dequeue)(struct hci_uart *hu);
|
|
};
|
|
|
|
struct hci_uart {
|
|
struct tty_struct *tty;
|
|
struct serdev_device *serdev;
|
|
struct hci_dev *hdev;
|
|
unsigned long flags;
|
|
unsigned long hdev_flags;
|
|
|
|
struct work_struct init_ready;
|
|
struct work_struct write_work;
|
|
|
|
const struct hci_uart_proto *proto;
|
|
struct percpu_rw_semaphore proto_lock; /* Stop work for proto close */
|
|
void *priv;
|
|
|
|
struct sk_buff *tx_skb;
|
|
unsigned long tx_state;
|
|
|
|
unsigned int init_speed;
|
|
unsigned int oper_speed;
|
|
|
|
u8 alignment;
|
|
u8 padding;
|
|
};
|
|
|
|
/* HCI_UART proto flag bits */
|
|
#define HCI_UART_PROTO_SET 0
|
|
#define HCI_UART_REGISTERED 1
|
|
#define HCI_UART_PROTO_READY 2
|
|
|
|
/* TX states */
|
|
#define HCI_UART_SENDING 1
|
|
#define HCI_UART_TX_WAKEUP 2
|
|
|
|
int hci_uart_register_proto(const struct hci_uart_proto *p);
|
|
int hci_uart_unregister_proto(const struct hci_uart_proto *p);
|
|
int hci_uart_register_device(struct hci_uart *hu, const struct hci_uart_proto *p);
|
|
void hci_uart_unregister_device(struct hci_uart *hu);
|
|
|
|
int hci_uart_tx_wakeup(struct hci_uart *hu);
|
|
int hci_uart_init_ready(struct hci_uart *hu);
|
|
void hci_uart_set_baudrate(struct hci_uart *hu, unsigned int speed);
|
|
void hci_uart_set_flow_control(struct hci_uart *hu, bool enable);
|
|
void hci_uart_set_speeds(struct hci_uart *hu, unsigned int init_speed,
|
|
unsigned int oper_speed);
|
|
|
|
#ifdef CONFIG_BT_HCIUART_H4
|
|
int h4_init(void);
|
|
int h4_deinit(void);
|
|
|
|
struct h4_recv_pkt {
|
|
u8 type; /* Packet type */
|
|
u8 hlen; /* Header length */
|
|
u8 loff; /* Data length offset in header */
|
|
u8 lsize; /* Data length field size */
|
|
u16 maxlen; /* Max overall packet length */
|
|
int (*recv)(struct hci_dev *hdev, struct sk_buff *skb);
|
|
};
|
|
|
|
#define H4_RECV_ACL \
|
|
.type = HCI_ACLDATA_PKT, \
|
|
.hlen = HCI_ACL_HDR_SIZE, \
|
|
.loff = 2, \
|
|
.lsize = 2, \
|
|
.maxlen = HCI_MAX_FRAME_SIZE \
|
|
|
|
#define H4_RECV_SCO \
|
|
.type = HCI_SCODATA_PKT, \
|
|
.hlen = HCI_SCO_HDR_SIZE, \
|
|
.loff = 2, \
|
|
.lsize = 1, \
|
|
.maxlen = HCI_MAX_SCO_SIZE
|
|
|
|
#define H4_RECV_EVENT \
|
|
.type = HCI_EVENT_PKT, \
|
|
.hlen = HCI_EVENT_HDR_SIZE, \
|
|
.loff = 1, \
|
|
.lsize = 1, \
|
|
.maxlen = HCI_MAX_EVENT_SIZE
|
|
|
|
struct sk_buff *h4_recv_buf(struct hci_dev *hdev, struct sk_buff *skb,
|
|
const unsigned char *buffer, int count,
|
|
const struct h4_recv_pkt *pkts, int pkts_count);
|
|
#endif
|
|
|
|
#ifdef CONFIG_BT_HCIUART_BCSP
|
|
int bcsp_init(void);
|
|
int bcsp_deinit(void);
|
|
#endif
|
|
|
|
#ifdef CONFIG_BT_HCIUART_LL
|
|
int ll_init(void);
|
|
int ll_deinit(void);
|
|
#endif
|
|
|
|
#ifdef CONFIG_BT_HCIUART_ATH3K
|
|
int ath_init(void);
|
|
int ath_deinit(void);
|
|
#endif
|
|
|
|
#ifdef CONFIG_BT_HCIUART_3WIRE
|
|
int h5_init(void);
|
|
int h5_deinit(void);
|
|
#endif
|
|
|
|
#ifdef CONFIG_BT_HCIUART_INTEL
|
|
int intel_init(void);
|
|
int intel_deinit(void);
|
|
#endif
|
|
|
|
#ifdef CONFIG_BT_HCIUART_BCM
|
|
int bcm_init(void);
|
|
int bcm_deinit(void);
|
|
#endif
|
|
|
|
#ifdef CONFIG_BT_HCIUART_QCA
|
|
int qca_init(void);
|
|
int qca_deinit(void);
|
|
#endif
|
|
|
|
#ifdef CONFIG_BT_HCIUART_AG6XX
|
|
int ag6xx_init(void);
|
|
int ag6xx_deinit(void);
|
|
#endif
|
|
|
|
#ifdef CONFIG_BT_HCIUART_MRVL
|
|
int mrvl_init(void);
|
|
int mrvl_deinit(void);
|
|
#endif
|