mirror of
https://github.com/torvalds/linux.git
synced 2024-11-26 22:21:42 +00:00
30e88d017f
The driver core ignores the return value of the remove callback, so don't give isa drivers the chance to provide a value. Adapt all isa_drivers with a remove callbacks accordingly; they all return 0 unconditionally anyhow. Acked-by: Marc Kleine-Budde <mkl@pengutronix.de> # for drivers/net/can/sja1000/tscan1.c Acked-by: William Breathitt Gray <vilhelm.gray@gmail.com> Acked-by: Wolfram Sang <wsa@kernel.org> # for drivers/i2c/ Reviewed-by: Takashi Iway <tiwai@suse.de> # for sound/ Reviewed-by: Hans Verkuil <hverkuil-cisco@xs4all.nl> # for drivers/media/ Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org> Link: https://lore.kernel.org/r/20210122092449.426097-4-uwe@kleine-koenig.org Signed-off-by: Takashi Iwai <tiwai@suse.de>
116 lines
2.7 KiB
C
116 lines
2.7 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* AdLib FM card driver.
|
|
*/
|
|
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/isa.h>
|
|
#include <sound/core.h>
|
|
#include <sound/initval.h>
|
|
#include <sound/opl3.h>
|
|
|
|
#define CRD_NAME "AdLib FM"
|
|
#define DEV_NAME "adlib"
|
|
|
|
MODULE_DESCRIPTION(CRD_NAME);
|
|
MODULE_AUTHOR("Rene Herman");
|
|
MODULE_LICENSE("GPL");
|
|
|
|
static int index[SNDRV_CARDS] = SNDRV_DEFAULT_IDX;
|
|
static char *id[SNDRV_CARDS] = SNDRV_DEFAULT_STR;
|
|
static bool enable[SNDRV_CARDS] = SNDRV_DEFAULT_ENABLE;
|
|
static long port[SNDRV_CARDS] = SNDRV_DEFAULT_PORT;
|
|
|
|
module_param_array(index, int, NULL, 0444);
|
|
MODULE_PARM_DESC(index, "Index value for " CRD_NAME " soundcard.");
|
|
module_param_array(id, charp, NULL, 0444);
|
|
MODULE_PARM_DESC(id, "ID string for " CRD_NAME " soundcard.");
|
|
module_param_array(enable, bool, NULL, 0444);
|
|
MODULE_PARM_DESC(enable, "Enable " CRD_NAME " soundcard.");
|
|
module_param_hw_array(port, long, ioport, NULL, 0444);
|
|
MODULE_PARM_DESC(port, "Port # for " CRD_NAME " driver.");
|
|
|
|
static int snd_adlib_match(struct device *dev, unsigned int n)
|
|
{
|
|
if (!enable[n])
|
|
return 0;
|
|
|
|
if (port[n] == SNDRV_AUTO_PORT) {
|
|
dev_err(dev, "please specify port\n");
|
|
return 0;
|
|
}
|
|
return 1;
|
|
}
|
|
|
|
static void snd_adlib_free(struct snd_card *card)
|
|
{
|
|
release_and_free_resource(card->private_data);
|
|
}
|
|
|
|
static int snd_adlib_probe(struct device *dev, unsigned int n)
|
|
{
|
|
struct snd_card *card;
|
|
struct snd_opl3 *opl3;
|
|
int error;
|
|
|
|
error = snd_card_new(dev, index[n], id[n], THIS_MODULE, 0, &card);
|
|
if (error < 0) {
|
|
dev_err(dev, "could not create card\n");
|
|
return error;
|
|
}
|
|
|
|
card->private_data = request_region(port[n], 4, CRD_NAME);
|
|
if (!card->private_data) {
|
|
dev_err(dev, "could not grab ports\n");
|
|
error = -EBUSY;
|
|
goto out;
|
|
}
|
|
card->private_free = snd_adlib_free;
|
|
|
|
strcpy(card->driver, DEV_NAME);
|
|
strcpy(card->shortname, CRD_NAME);
|
|
sprintf(card->longname, CRD_NAME " at %#lx", port[n]);
|
|
|
|
error = snd_opl3_create(card, port[n], port[n] + 2, OPL3_HW_AUTO, 1, &opl3);
|
|
if (error < 0) {
|
|
dev_err(dev, "could not create OPL\n");
|
|
goto out;
|
|
}
|
|
|
|
error = snd_opl3_hwdep_new(opl3, 0, 0, NULL);
|
|
if (error < 0) {
|
|
dev_err(dev, "could not create FM\n");
|
|
goto out;
|
|
}
|
|
|
|
error = snd_card_register(card);
|
|
if (error < 0) {
|
|
dev_err(dev, "could not register card\n");
|
|
goto out;
|
|
}
|
|
|
|
dev_set_drvdata(dev, card);
|
|
return 0;
|
|
|
|
out: snd_card_free(card);
|
|
return error;
|
|
}
|
|
|
|
static void snd_adlib_remove(struct device *dev, unsigned int n)
|
|
{
|
|
snd_card_free(dev_get_drvdata(dev));
|
|
}
|
|
|
|
static struct isa_driver snd_adlib_driver = {
|
|
.match = snd_adlib_match,
|
|
.probe = snd_adlib_probe,
|
|
.remove = snd_adlib_remove,
|
|
|
|
.driver = {
|
|
.name = DEV_NAME
|
|
}
|
|
};
|
|
|
|
module_isa_driver(snd_adlib_driver, SNDRV_CARDS);
|