mirror of
https://github.com/torvalds/linux.git
synced 2024-11-07 12:41:55 +00:00
c32fa99f0b
Enabling '-Wsign-compare' compiler warnings on code that includes
include/linux/bitops.h can generate the following warning:
In file included from include/linux/kernel.h:10:0,
from <random filename>:48:
include/linux/bitops.h: In function 'hweight_long':
include/linux/bitops.h:77:26: error: signed and unsigned type in conditional expression [-Werror=sign-compare]
(converted to an error with -Werror)
This is due to the use of the logical negation operator '!' in the
__const_hweight8 macro in include/asm-generic/bitops/const_hweight.h.
The use of that operator here results in a signed value.
Fix by explicitly casting the __const_hweight8 macro expansion to
'unsigned int'. While here, clean up several checkpatch.pl warnings.
Signed-off-by: Paul Walmsley <pwalmsley@nvidia.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/alpine.DEB.2.02.1312180459580.30198@tamien
Signed-off-by: Ingo Molnar <mingo@kernel.org>
|
||
|---|---|---|
| .. | ||
| __ffs.h | ||
| __fls.h | ||
| arch_hweight.h | ||
| atomic.h | ||
| builtin-__ffs.h | ||
| builtin-__fls.h | ||
| builtin-ffs.h | ||
| builtin-fls.h | ||
| const_hweight.h | ||
| count_zeros.h | ||
| ext2-atomic-setbit.h | ||
| ext2-atomic.h | ||
| ffs.h | ||
| ffz.h | ||
| find.h | ||
| fls64.h | ||
| fls.h | ||
| hweight.h | ||
| le.h | ||
| lock.h | ||
| non-atomic.h | ||
| sched.h | ||