mirror of
https://github.com/torvalds/linux.git
synced 2024-12-11 13:41:55 +00:00
0da05a040d
`strncpy` is deprecated for use on NUL-terminated destination strings [1]. We know `hw.partname` is supposed to be NUL-terminated by its later use with seq_printf: | nitrox_debugfs.c +25 | seq_printf(s, " Part Name: %s\n", ndev->hw.partname); Let's prefer a more robust and less ambiguous string interface. A suitable replacement is `strscpy` [2] due to the fact that it guarantees NUL-termination on the destination buffer. Link: https://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings [1] Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [2] Link: https://github.com/KSPP/linux/issues/90 Cc: linux-hardening@vger.kernel.org Signed-off-by: Justin Stitt <justinstitt@google.com> Reviewed-by: Kees Cook <keescook@chromium.org> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au> |
||
---|---|---|
.. | ||
Kconfig | ||
Makefile | ||
nitrox_aead.c | ||
nitrox_algs.c | ||
nitrox_common.h | ||
nitrox_csr.h | ||
nitrox_debugfs.c | ||
nitrox_debugfs.h | ||
nitrox_dev.h | ||
nitrox_hal.c | ||
nitrox_hal.h | ||
nitrox_isr.c | ||
nitrox_isr.h | ||
nitrox_lib.c | ||
nitrox_main.c | ||
nitrox_mbx.c | ||
nitrox_mbx.h | ||
nitrox_req.h | ||
nitrox_reqmgr.c | ||
nitrox_skcipher.c | ||
nitrox_sriov.c |