Enric Balletbo i Serra a8f62f1830 Revert "thermal: mediatek: fix register index error" ... This reverts commit eb9aecd90d The above patch is supposed to fix a register index error on mt2701. It is not clear if the problem solved is a hang or just an invalid value returned, my guess is the second. The patch introduces, though, a new hang on MT8173 device making them unusable. So, seems reasonable, revert the patch because introduces a worst issue. The reason I send a revert instead of trying to fix the issue for MT8173 is because the information needed to fix the issue is in the datasheet and is not public. So I am not really able to fix it. Fixes the following bug when CONFIG_MTK_THERMAL is set on MT8173 devices. [ 2.222488] Unable to handle kernel paging request at virtual address ffff8000125f5001 [ 2.230421] Mem abort info: [ 2.233207] ESR = 0x96000021 [ 2.236261] EC = 0x25: DABT (current EL), IL = 32 bits [ 2.241571] SET = 0, FnV = 0 [ 2.244623] EA = 0, S1PTW = 0 [ 2.247762] Data abort info: [ 2.250640] ISV = 0, ISS = 0x00000021 [ 2.254473] CM = 0, WnR = 0 [ 2.257544] swapper pgtable: 4k pages, 48-bit VAs, pgdp=0000000041850000 [ 2.264251] [ffff8000125f5001] pgd=000000013ffff003, pud=000000013fffe003, pmd=000000013fff9003, pte=006800001100b707 [ 2.274867] Internal error: Oops: 96000021 [#1] PREEMPT SMP [ 2.280432] Modules linked in: [ 2.283483] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.7.0-rc6+ #162 [ 2.289914] Hardware name: Google Elm (DT) [ 2.294003] pstate: 20000005 (nzCv daif -PAN -UAO) [ 2.298792] pc : mtk_read_temp+0xb8/0x1c8 [ 2.302793] lr : mtk_read_temp+0x7c/0x1c8 [ 2.306794] sp : ffff80001003b930 [ 2.310100] x29: ffff80001003b930 x28: 0000000000000000 [ 2.315404] x27: 0000000000000002 x26: ffff0000f9550b10 [ 2.320709] x25: ffff0000f9550a80 x24: 0000000000000090 [ 2.326014] x23: ffff80001003ba24 x22: 00000000610344c0 [ 2.331318] x21: 0000000000002710 x20: 00000000000001f4 [ 2.336622] x19: 0000000000030d40 x18: ffff800011742ec0 [ 2.341926] x17: 0000000000000001 x16: 0000000000000001 [ 2.347230] x15: ffffffffffffffff x14: ffffff0000000000 [ 2.352535] x13: ffffffffffffffff x12: 0000000000000028 [ 2.357839] x11: 0000000000000003 x10: ffff800011295ec8 [ 2.363143] x9 : 000000000000291b x8 : 0000000000000002 [ 2.368447] x7 : 00000000000000a8 x6 : 0000000000000004 [ 2.373751] x5 : 0000000000000000 x4 : ffff800011295cb0 [ 2.379055] x3 : 0000000000000002 x2 : ffff8000125f5001 [ 2.384359] x1 : 0000000000000001 x0 : ffff0000f9550a80 [ 2.389665] Call trace: [ 2.392105] mtk_read_temp+0xb8/0x1c8 [ 2.395760] of_thermal_get_temp+0x2c/0x40 [ 2.399849] thermal_zone_get_temp+0x78/0x160 [ 2.404198] thermal_zone_device_update.part.0+0x3c/0x1f8 [ 2.409589] thermal_zone_device_update+0x34/0x48 [ 2.414286] of_thermal_set_mode+0x58/0x88 [ 2.418375] thermal_zone_of_sensor_register+0x1a8/0x1d8 [ 2.423679] devm_thermal_zone_of_sensor_register+0x64/0xb0 [ 2.429242] mtk_thermal_probe+0x690/0x7d0 [ 2.433333] platform_drv_probe+0x5c/0xb0 [ 2.437335] really_probe+0xe4/0x448 [ 2.440901] driver_probe_device+0xe8/0x140 [ 2.445077] device_driver_attach+0x7c/0x88 [ 2.449252] __driver_attach+0xac/0x178 [ 2.453082] bus_for_each_dev+0x78/0xc8 [ 2.456909] driver_attach+0x2c/0x38 [ 2.460476] bus_add_driver+0x14c/0x230 [ 2.464304] driver_register+0x6c/0x128 [ 2.468131] __platform_driver_register+0x50/0x60 [ 2.472831] mtk_thermal_driver_init+0x24/0x30 [ 2.477268] do_one_initcall+0x50/0x298 [ 2.481098] kernel_init_freeable+0x1ec/0x264 [ 2.485450] kernel_init+0x1c/0x110 [ 2.488931] ret_from_fork+0x10/0x1c [ 2.492502] Code: f9401081 f9400402 b8a67821 8b010042 (b9400042) [ 2.498599] ---[ end trace e43e3105ed27dc99 ]--- [ 2.503367] Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b [ 2.511020] SMP: stopping secondary CPUs [ 2.514941] Kernel Offset: disabled [ 2.518421] CPU features: 0x090002,25006005 [ 2.522595] Memory Limit: none [ 2.525644] ---[ end Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b ]-- Cc: Michael Kao <michael.kao@mediatek.com> Fixes: eb9aecd90d ("thermal: mediatek: fix register index error") Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org> Link: https://lore.kernel.org/r/20200707103412.1010823-1-enric.balletbo@collabora.com		2020-07-15 11:12:48 +02:00
..
broadcom	thermal: brcmstb_thermal: Register different ops per process	2020-01-27 11:41:08 +01:00
intel	thermal: int3403_thermal: Downgrade error message	2020-07-15 09:10:28 +08:00
qcom	drivers: thermal: tsens: Merge tsens-common.c into tsens.c	2020-05-22 18:53:04 +02:00
samsung	thermal: exynos: Silence warning during deferred probe	2020-03-12 11:56:53 +01:00
st	thermal: Delete an error message in four functions	2020-04-14 11:41:12 +02:00
tegra	thermal: tegra: Appease the kernel-doc deity	2020-01-27 10:24:32 +01:00
ti-soc-thermal	thermal/drivers/ti-soc-thermal: Avoid dereferencing ERR_PTR	2020-04-29 16:38:58 +02:00
amlogic_thermal.c	thermal: amlogic: Appease the kernel-doc deity	2020-01-27 10:24:32 +01:00
armada_thermal.c	thermal: armada: remove unused TO_MCELSIUS macro	2020-01-31 10:30:40 -08:00
clock_cooling.c	thermal/drivers/clock_cooling: Include export.h	2020-05-22 18:48:54 +02:00
cpufreq_cooling.c	thermal/drivers/cpufreq_cooling: Replace module.h with export.h	2020-05-22 18:48:54 +02:00
cpuidle_cooling.c	thermal/drivers/cpuidle_cooling: Change the registration function	2020-05-19 12:55:29 +02:00
da9062-thermal.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 157	2019-05-30 11:26:37 -07:00
db8500_thermal.c	thermal: db8500: Depromote debug print	2020-01-27 10:24:32 +01:00
devfreq_cooling.c	thermal: devfreq_cooling: Use PM QoS to set frequency limits	2020-04-14 11:41:12 +02:00
dove_thermal.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 282	2019-06-05 17:36:37 +02:00
gov_bang_bang.c	thermal: step_wise: Appease the kernel-doc deity	2020-01-27 10:24:32 +01:00
gov_fair_share.c	thermal/governors: Prefix all source files with gov_	2020-05-22 18:48:54 +02:00
gov_power_allocator.c	thermal/governors: Prefix all source files with gov_	2020-05-22 18:48:54 +02:00
gov_step_wise.c	thermal/governors: Prefix all source files with gov_	2020-05-22 18:48:54 +02:00
gov_user_space.c	thermal/governors: Prefix all source files with gov_	2020-05-22 18:48:54 +02:00
hisi_thermal.c	thermal/drivers/hisi: Fix number of sensors on hi3660	2018-12-10 20:13:09 -08:00
imx8mm_thermal.c	thermal: imx8mm: Replace zero-length array with flexible-array	2020-05-22 18:45:15 +02:00
imx_sc_thermal.c	- Add the hwmon support on the i.MX SC (Anson Huang)	2020-06-12 14:10:21 -07:00
imx_thermal.c	thermal: imx: Calling imx_thermal_unregister_legacy_cooling() in .remove	2020-03-20 12:17:48 +01:00
k3_bandgap.c	thermal: k3: Add support for bandgap sensors	2020-04-14 11:41:12 +02:00
Kconfig	thermal: qoriq: Add platform dependencies	2020-05-22 18:56:29 +02:00
kirkwood_thermal.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 282	2019-06-05 17:36:37 +02:00
Makefile	thermal/of: Rename of-thermal.c	2020-05-22 18:48:54 +02:00
max77620_thermal.c	thermal: max77620: Appease the kernel-doc deity	2020-01-27 10:24:32 +01:00
mtk_thermal.c	Revert "thermal: mediatek: fix register index error"	2020-07-15 11:12:48 +02:00
qoriq_thermal.c	thermal: qoriq: Update the settings for TMUv2	2020-05-29 20:26:51 +02:00
rcar_gen3_thermal.c	thermal: rcar_gen3_thermal: Add r8a77961 support	2020-03-20 12:17:48 +01:00
rcar_thermal.c	thermal: rcar_thermal: Clean up rcar_thermal_update_temp()	2020-05-22 21:09:59 +02:00
rockchip_thermal.c	thermal: Delete an error message in four functions	2020-04-14 11:41:12 +02:00
spear_thermal.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 282	2019-06-05 17:36:37 +02:00
sprd_thermal.c	thermal: sprd: Add Spreadtrum thermal driver support	2020-03-12 11:40:57 +01:00
sun8i_thermal.c	thermal: sun8i: Add hwmon support	2020-01-27 11:41:08 +01:00
tango_thermal.c	treewide: Add SPDX license identifier for more missed files	2019-05-21 10:50:45 +02:00
thermal_core.c	thermal/core: Replace module.h with export.h	2020-05-22 18:48:53 +02:00
thermal_core.h	thermal: Move get_thermal_instance to the internal header	2020-04-14 11:41:12 +02:00
thermal_helpers.c	thermal/drivers/thermal_helpers: Include export.h	2020-05-22 18:48:53 +02:00
thermal_hwmon.c	thermal/drivers/thermal_hwmon: Include export.h	2020-05-22 18:48:53 +02:00
thermal_hwmon.h	thermal_hwmon: Add devres wrapper for thermal_add_hwmon_sysfs()	2020-01-27 10:24:32 +01:00
thermal_mmio.c	thermal: no need to set .owner when using module_platform_driver	2019-11-07 07:00:26 +01:00
thermal_of.c	thermal/of: Rename of-thermal.c	2020-05-22 18:48:54 +02:00
thermal_sysfs.c	thermal: Fix locking in cooling device sysfs update cur_state	2018-11-30 16:57:51 +08:00
thermal-generic-adc.c	thermal: generic-adc: silence info message for IIO_TEMP channels	2020-01-27 10:24:32 +01:00
uniphier_thermal.c	thermal: uniphier: Convert to SPDX identifier	2019-01-02 04:47:16 -08:00
zx2967_thermal.c	thermal: zx2967: Appease the kernel-doc deity	2020-01-27 10:24:32 +01:00