Li Lingfeng d483001206 dm thin metadata: Fix ABBA deadlock by resetting dm_bufio_client ... As described in commit 8111964f1b ("dm thin: Fix ABBA deadlock between shrink_slab and dm_pool_abort_metadata"), ABBA deadlocks will be triggered because shrinker_rwsem currently needs to held by dm_pool_abort_metadata() as a side-effect of thin-pool metadata operation failure. The following three problem scenarios have been noticed: 1) Described by commit 8111964f1b ("dm thin: Fix ABBA deadlock between shrink_slab and dm_pool_abort_metadata") 2) shrinker_rwsem and throttle->lock P1(drop cache) P2(kworker) drop_caches_sysctl_handler drop_slab shrink_slab down_read(&shrinker_rwsem) - LOCK A do_shrink_slab super_cache_scan prune_icache_sb dispose_list evict ext4_evict_inode ext4_clear_inode ext4_discard_preallocations ext4_mb_load_buddy_gfp ext4_mb_init_cache ext4_wait_block_bitmap __ext4_error ext4_handle_error ext4_commit_super ... dm_submit_bio do_worker throttle_work_update down_write(&t->lock) -- LOCK B process_deferred_bios commit metadata_operation_failed dm_pool_abort_metadata dm_block_manager_create dm_bufio_client_create register_shrinker down_write(&shrinker_rwsem) -- LOCK A thin_map thin_bio_map thin_defer_bio_with_throttle throttle_lock down_read(&t->lock) - LOCK B 3) shrinker_rwsem and wait_on_buffer P1(drop cache) P2(kworker) drop_caches_sysctl_handler drop_slab shrink_slab down_read(&shrinker_rwsem) - LOCK A do_shrink_slab ... ext4_wait_block_bitmap __ext4_error ext4_handle_error jbd2_journal_abort jbd2_journal_update_sb_errno jbd2_write_superblock submit_bh // LOCK B // RELEASE B do_worker throttle_work_update down_write(&t->lock) - LOCK B process_deferred_bios process_bio commit metadata_operation_failed dm_pool_abort_metadata dm_block_manager_create dm_bufio_client_create register_shrinker register_shrinker_prepared down_write(&shrinker_rwsem) - LOCK A bio_endio wait_on_buffer __wait_on_buffer Fix these by resetting dm_bufio_client without holding shrinker_rwsem. Fixes: 8111964f1b ("dm thin: Fix ABBA deadlock between shrink_slab and dm_pool_abort_metadata") Cc: stable@vger.kernel.org Signed-off-by: Li Lingfeng <lilingfeng3@huawei.com> Signed-off-by: Mike Snitzer <snitzer@kernel.org>		2023-06-16 18:24:13 -04:00
..
acpi	Power management updates for 6.4-rc1	2023-04-25 18:44:10 -07:00
asm-generic	Locking changes in v6.4:	2023-05-05 12:56:55 -07:00
clocksource
crypto	This update includes the following changes:	2023-04-26 08:32:52 -07:00
drm	Merge tag 'drm-misc-fixes-2023-05-11' of git://anongit.freedesktop.org/drm/drm-misc into drm-fixes	2023-05-12 05:32:36 +10:00
dt-bindings	- mailbox api: allow direct registration to a channel	2023-05-07 10:17:33 -07:00
keys
kunit
kvm	s390:	2023-05-01 12:06:20 -07:00
linux	dm thin metadata: Fix ABBA deadlock by resetting dm_bufio_client	2023-06-16 18:24:13 -04:00
math-emu
media	media: i2c: Drop unused sr030pc30 camera sensor driver	2023-04-15 09:56:49 +01:00
memory
misc
net	bonding: fix send_peer_notif overflow	2023-05-10 09:27:20 +01:00
pcmcia
ras
rdma	RDMA: Add ib_virt_dma_to_page()	2023-04-16 11:08:07 +03:00
rv
scsi	scsi: replace the fmode_t argument to scsi_ioctl with a simple bool	2023-06-12 08:04:04 -06:00
soc	Nothing looks out of the ordinary in this batch of clk driver updates. There	2023-04-29 17:29:39 -07:00
sound	ASoC: Updates for v6.4	2023-04-24 15:15:31 +02:00
target
trace	block: introduce block_io_start/block_io_done tracepoints	2023-05-24 08:38:59 -06:00
uapi	pktcdvd: Get rid of custom printing macros	2023-06-07 14:26:09 -06:00
ufs	SCSI misc on 20230426	2023-04-26 15:39:25 -07:00
vdso
video
xen