mirror of
https://github.com/torvalds/linux.git
synced 2024-11-27 14:41:39 +00:00
a7ec7a4193
An HFS+ filesystem can be mounted read-only without having a metadata directory, which is needed to support hardlinks. But if the catalog data is corrupted, a directory lookup may still find dentries claiming to be hardlinks. hfsplus_lookup() does check that ->hidden_dir is not NULL in such a situation, but mistakenly does so after dereferencing it for the first time. Reorder this check to prevent a crash. This happens when looking up corrupted catalog data (dentry) on a filesystem with no metadata directory (this could only ever happen on a read-only mount). Wen Xu sent the replication steps in detail to the fsdevel list: https://bugzilla.kernel.org/show_bug.cgi?id=200297 Link: http://lkml.kernel.org/r/20180712215344.q44dyrhymm4ajkao@eaf Signed-off-by: Ernesto A. Fernández <ernesto.mnd.fernandez@gmail.com> Reported-by: Wen Xu <wen.xu@gatech.edu> Cc: Viacheslav Dubeyko <slava@dubeyko.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> |
||
---|---|---|
.. | ||
attributes.c | ||
bfind.c | ||
bitmap.c | ||
bnode.c | ||
brec.c | ||
btree.c | ||
catalog.c | ||
dir.c | ||
extents.c | ||
hfsplus_fs.h | ||
hfsplus_raw.h | ||
inode.c | ||
ioctl.c | ||
Kconfig | ||
Makefile | ||
options.c | ||
part_tbl.c | ||
super.c | ||
tables.c | ||
unicode.c | ||
wrapper.c | ||
xattr_security.c | ||
xattr_trusted.c | ||
xattr_user.c | ||
xattr.c | ||
xattr.h |